Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MetricKit] Add support for Xcode 13 beta4. #12326

Merged
merged 6 commits into from
Aug 4, 2021
Merged

[MetricKit] Add support for Xcode 13 beta4. #12326

merged 6 commits into from
Aug 4, 2021

Conversation

mandel-macaque
Copy link
Member

No description provided.

@mandel-macaque mandel-macaque added the note-highlight Worth calling out specifically in release notes label Aug 2, 2021
@vs-mobiletools-engineering-service2
Copy link
Collaborator

❌ [PR Build] Tests failed on Build ❌

Tests failed on Build.

API diff

✅ API Diff from stable

View API diff

API & Generator diff

ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

Test results

1 tests failed, 91 tests passed.

Failed tests

  • introspection/Mac Catalyst/Debug: Failed (Tests run: 44 Passed: 38 Inconclusive: 0 Failed: 1 Ignored: 5)

Pipeline on Agent XAMBOT-1094.BigSur'
Merge 9bb680c into 0ca2038

rolfbjarne
rolfbjarne requested changes Aug 3, 2021
View reviewed changes
src/metrickit.cs Outdated Show resolved Hide resolved
tests/xtro-sharpie/MacCatalyst-MetricKit.ignore Outdated Show resolved Hide resolved
tests/xtro-sharpie/iOS-MetricKit.ignore Outdated Show resolved Hide resolved
@vs-mobiletools-engineering-service2
Copy link
Collaborator

❌ [PR Build] Tests failed on Build ❌

Tests failed on Build.

API diff

✅ API Diff from stable

View API diff

API & Generator diff

ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

Test results

1 tests failed, 91 tests passed.

Failed tests

  • Xtro/Mac: Failed (Test run failed.)

Pipeline on Agent XAMBOT-1094.BigSur'
Merge d7820ef into f375881

@mandel-macaque @rolfbjarne
Apply suggestions from code review
ff7f52d 
Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com>
spouliot
spouliot reviewed Aug 3, 2021
View reviewed changes
src/metrickit.cs Outdated
@@ -311,39 +321,51 @@ interface MXMetricPayload : NSSecureCoding {
[Export ("timeStampEnd", ArgumentSemantic.Strong)]
NSDate TimeStampEnd { get; }

[NoMac]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor: not needed, there's a [NoMac] on the type-level

src/metrickit.cs Outdated
[NullAllowed, Export ("cpuMetrics", ArgumentSemantic.Strong)]
MXCpuMetric CpuMetrics { get; }

[NoMac]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor: not needed, there's a [NoMac] on the type-level

src/metrickit.cs Outdated
[NullAllowed, Export ("gpuMetrics", ArgumentSemantic.Strong)]
MXGpuMetric GpuMetrics { get; }

[NoMac]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor: not needed, there's a [NoMac] on the type-level

src/metrickit.cs Outdated
[NullAllowed, Export ("cellularConditionMetrics", ArgumentSemantic.Strong)]
MXCellularConditionMetric CellularConditionMetrics { get; }

[NoMac]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor: not needed, there's a [NoMac] on the type-level

src/metrickit.cs Outdated
[NullAllowed, Export ("applicationTimeMetrics", ArgumentSemantic.Strong)]
MXAppRunTimeMetric ApplicationTimeMetrics { get; }

[NoMac]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor: not needed, there's a [NoMac] on the type-level

src/metrickit.cs Outdated
[NullAllowed, Export ("memoryMetrics", ArgumentSemantic.Strong)]
MXMemoryMetric MemoryMetrics { get; }

[NoMac]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor: not needed, there's a [NoMac] on the type-level

src/metrickit.cs Outdated
[NullAllowed, Export ("displayMetrics", ArgumentSemantic.Strong)]
MXDisplayMetric DisplayMetrics { get; }

[NoMac]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor: not needed, there's a [NoMac] on the type-level

src/metrickit.cs Outdated
@@ -352,7 +374,7 @@ interface MXMetricPayload : NSSecureCoding {

[Export ("JSONRepresentation")]
NSData JsonRepresentation { get; }

#if !MONOMAC
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor: not needed, there's a [NoMac] on the type-level

src/metrickit.cs Outdated

[iOS (14,0)]
[NoMac, iOS (14,0)]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor: not needed, there's a [NoMac] on the type-level

src/metrickit.cs Outdated
[MacCatalyst (14,0)]
[NullAllowed]
[Export ("animationMetrics", ArgumentSemantic.Strong)]
MXAnimationMetric AnimationMetrics { get; }

[iOS (14,0)]
[NoMac, iOS (14,0)]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor: not needed, there's a [NoMac] on the type-level

@vs-mobiletools-engineering-service2
Copy link
Collaborator

❌ [PR Build] Tests failed on Build ❌

Tests failed on Build.

API diff

✅ API Diff from stable

View API diff

API & Generator diff

ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

Test results

1 tests failed, 92 tests passed.

Failed tests

  • introspection/Mac Catalyst/Debug [dotnet]: TimedOut (Execution timed out after 1200 seconds.
    No test log file was produced)

Pipeline on Agent XAMBOT-1098.BigSur'
Merge 7acbade into eafe528

@mandel-macaque
Copy link
Member Author

Unrelated issue: https://github.com/xamarin/maccore/issues/2414

@mandel-macaque mandel-macaque merged commit 62eec28 into xamarin:main Aug 4, 2021
@mandel-macaque mandel-macaque deleted the metrickit-xcode13-beta4 branch August 4, 2021 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spouliot spouliot spouliot left review comments

@rolfbjarne rolfbjarne rolfbjarne approved these changes

@dalexsoto dalexsoto dalexsoto approved these changes

Assignees
No one assigned
Labels
note-highlight Worth calling out specifically in release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mandel-macaque @vs-mobiletools-engineering-service2 @dalexsoto @rolfbjarne @spouliot