Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[VideoToolbox] Add support for Xcode13 beta5. #12466

Merged
merged 3 commits into from
Aug 19, 2021
Merged

[VideoToolbox] Add support for Xcode13 beta5. #12466

merged 3 commits into from
Aug 19, 2021

Conversation

mandel-macaque
Copy link
Member

No description provided.

@mandel-macaque mandel-macaque added the note-highlight Worth calling out specifically in release notes label Aug 17, 2021
@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [PR Build] Tests passed on Build. ✅

Tests passed on Build.

API diff

✅ API Diff from stable

View API diff

API & Generator diff

ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

🎉 All 105 tests passed 🎉

Pipeline on Agent XAMBOT-1094.BigSur'
Merge 6341b4b into 0b01c40

rolfbjarne
rolfbjarne requested changes Aug 18, 2021
View reviewed changes
src/videotoolbox.cs Outdated Show resolved Hide resolved
src/videotoolbox.cs Outdated Show resolved Hide resolved
src/videotoolbox.cs Outdated Show resolved Hide resolved
src/videotoolbox.cs Outdated Show resolved Hide resolved
spouliot
spouliot suggested changes Aug 18, 2021
View reviewed changes
Copy link
Contributor

@spouliot spouliot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

forgot to submit review yesterday :(
largely identical to Rolf's comments

src/videotoolbox.cs Outdated

[TV (15,0), Mac (12,0), iOS (15,0), MacCatalyst (15,0)]
[Field ("kVTEncodeFrameOptionKey_AcknowledgedLTRTokens")]
NSString AcknowledgedLTRTokens { get; }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-> Ltr

src/videotoolbox.cs Outdated

[TV (15,0), Mac (12,0), iOS (15,0), MacCatalyst (15,0)]
[Field ("kVTEncodeFrameOptionKey_ForceLTRRefresh")]
NSString ForceLTRRefresh { get; }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-> Ltr

src/videotoolbox.cs Outdated

[TV (15,0), Mac (12,0), iOS (15,0), MacCatalyst (15,0)]
[Field ("kVTSampleAttachmentKey_RequireLTRAcknowledgementToken")]
NSString RequireLTRAcknowledgementToken { get; }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-> Ltr

@mandel-macaque @rolfbjarne
Apply suggestions from code review
6edaf83 
Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com>
@vs-mobiletools-engineering-service2
Copy link
Collaborator

❌ [PR Build] Tests failed on Build ❌

Tests failed on Build.

API diff

✅ API Diff from stable

View API diff

API & Generator diff

ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

Test results

4 tests failed, 104 tests passed.

Failed tests

  • xammac tests/Mac Modern/Release (all optimizations): Failed (Test run failed.
    Tests run: 2469 Passed: 2402 Inconclusive: 10 Failed: 1 Ignored: 66)
  • monotouch-test/Mac Catalyst/Debug [dotnet]: Failed (Tests run: 2638 Passed: 2489 Inconclusive: 35 Failed: 1 Ignored: 148)
  • link sdk/Mac [dotnet]/Debug [dotnet]: BuildFailure
  • link sdk/Mac [dotnet]/Release [dotnet]: BuildFailure

Pipeline on Agent XAMBOT-1104.BigSur'
Merge 6edaf83 into e3bbec4

@vs-mobiletools-engineering-service2
Copy link
Collaborator

❌ [PR Build] Tests failed on Build ❌

Tests failed on Build.

API diff

✅ API Diff from stable

View API diff

API & Generator diff

ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

Test results

4 tests failed, 104 tests passed.

Failed tests

  • monotouch-test/Mac Catalyst/Debug [dotnet]: TimedOut (Execution timed out after 1200 seconds.
    No test log file was produced)
  • dont link/Mac Catalyst/Debug [dotnet]: Failed (Test run crashed (exit code: 134).
    Tests run: 11 Passed: 6 Inconclusive: 0 Failed: 0 Ignored: 5)
  • link sdk/Mac [dotnet]/Debug [dotnet]: BuildFailure
  • link sdk/Mac [dotnet]/Release [dotnet]: BuildFailure

Pipeline on Agent XAMBOT-1094.BigSur'
Merge 6edaf83 into e3bbec4

@mandel-macaque
Copy link
Member Author

Unrelated failures: https://github.com/xamarin/maccore/issues/2409

@mandel-macaque mandel-macaque merged commit 509b099 into xamarin:main Aug 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spouliot spouliot spouliot approved these changes

@rolfbjarne rolfbjarne rolfbjarne approved these changes

@dalexsoto dalexsoto Awaiting requested review from dalexsoto dalexsoto is a code owner

Assignees
No one assigned
Labels
note-highlight Worth calling out specifically in release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mandel-macaque @vs-mobiletools-engineering-service2 @rolfbjarne @spouliot