Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[LocalAuthenticationEmbeddedUI] Update bindings for Xcode 13.0 beta 2 and 3 #12535

Merged
merged 3 commits into from
Sep 1, 2021
Merged

[LocalAuthenticationEmbeddedUI] Update bindings for Xcode 13.0 beta 2 and 3 #12535

merged 3 commits into from
Sep 1, 2021

Conversation

rachelkang
Copy link
Contributor

No diffs for betas 1, 4, 5

Should I transfer the MacCatalyst.todo to .ignore? AFAICT, this framework doesn't have catalyst availability.

@rachelkang rachelkang added the note-highlight Worth calling out specifically in release notes label Aug 24, 2021
@rachelkang rachelkang added this to the xcode13.0 milestone Aug 24, 2021
@rachelkang rachelkang requested a review from rolfbjarne as a code owner August 24, 2021 22:26
spouliot
spouliot approved these changes Aug 25, 2021
View reviewed changes
Copy link
Contributor

@spouliot spouliot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should I transfer the MacCatalyst.todo to .ignore?

Yes! There's no LocalAuthentication support (for Catalyst) and other types, like NSControlSize are not available either.

@vs-mobiletools-engineering-service2
Copy link
Collaborator

❌ [PR Build] Tests failed on Build ❌

Tests failed on Build.

API diff

✅ API Diff from stable

View API diff

API & Generator diff

ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

Test results

4 tests failed, 107 tests passed.

Failed tests

  • xammac tests/Mac Modern/Debug: TimedOut (Execution timed out after 1200 seconds.
    Test run crashed)
  • xammac tests/Mac Modern/Release: TimedOut (Execution timed out after 1200 seconds.
    Test run crashed)
  • xammac tests/Mac Modern/Release (all optimizations): TimedOut (Execution timed out after 1200 seconds.
    Test run crashed)
  • MSBuild tests/Integration: Failed (Execution failed with exit code 50)

Pipeline on Agent XAMBOT-1100.BigSur'
Merge 254d372 into 3847fe0

@mandel-macaque mandel-macaque added the do-not-merge Do not merge this pull request label Aug 25, 2021
mandel-macaque
mandel-macaque approved these changes Aug 25, 2021
View reviewed changes
Copy link
Member

@mandel-macaque mandel-macaque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 adding do not merge until we moved the MacCatalyst todo to ignore.

@vs-mobiletools-engineering-service2
Copy link
Collaborator

❌ [PR Build] Tests failed on Build ❌

Tests failed on Build.

API diff

✅ API Diff from stable

View API diff

API & Generator diff

ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

Test results

1 tests failed, 110 tests passed.

Failed tests

  • monotouch-test/Mac Catalyst/Debug [dotnet]: Failed (Tests run: 2642 Passed: 2490 Inconclusive: 35 Failed: 1 Ignored: 151)

Pipeline on Agent XAMBOT-1103.BigSur'
Merge abb7b3a into 53988e1

@rachelkang @tj-devel709
Update src/localauthenticationembeddedui.cs
f7efc61 
Co-authored-by: TJ Lambert <50846373+tj-devel709@users.noreply.github.com>
@rachelkang rachelkang removed the do-not-merge Do not merge this pull request label Aug 31, 2021
@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [PR Build] Tests passed on Build. ✅

Tests passed on Build.

API diff

✅ API Diff from stable

View API diff

API & Generator diff

ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

🎉 All 111 tests passed 🎉

Pipeline on Agent XAMBOT-1097.BigSur
Merge f7efc61 into 066d5b5

@rachelkang rachelkang merged commit 3fc6b06 into xamarin:main Sep 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tj-devel709 tj-devel709 tj-devel709 approved these changes

@mandel-macaque mandel-macaque mandel-macaque approved these changes

@spouliot spouliot spouliot approved these changes

@rolfbjarne rolfbjarne rolfbjarne approved these changes

@dalexsoto dalexsoto Awaiting requested review from dalexsoto

Assignees
No one assigned
Labels
note-highlight Worth calling out specifically in release notes
Projects
None yet
Milestone
xcode13.0
Development

Successfully merging this pull request may close these issues.
6 participants
@rachelkang @vs-mobiletools-engineering-service2 @rolfbjarne @spouliot @mandel-macaque @tj-devel709