[Foundation] Add bindings for Xcode 13 rc 1. #13328

mandel-macaque · 2021-11-09T18:46:44Z

No description provided.

src/Foundation/Enums.cs

chamons

Looks reasonable. There are a lot of tests, but I'm not sure enough given how much manual bindings/wraps there were.

I want @rolfbjarne 's blessing before this goes in.

Good work, this was messy.

src/foundation.cs

chamons · 2021-11-09T18:58:35Z

src/generator.cs

@@ -1785,7 +1785,7 @@ public TrampolineInfo MakeTrampoline (Type t)
 		}

 		var rt = mi.ReturnType;
-		var rts = IsNativeEnum (rt) ? "var" : rt.ToString ();


@mandel-macaque - Can you explain this bit?

Yes, without this fix you will get an issue with the trampolines that use generics because you get the class name like NSArra'1 rather than NSArray

Ideally this would be in a separate PR to make blaming it in the future more obvious.

Consider calling it out with explaination in the PR/commit description for possible future us.

This can be a diff fix. The issue where is that the rt.ToString() ois doing the wrong thing and is generating a non-compilable name. I'll add this as a separate branch with a decent explanation.

tests/monotouch-test/Foundation/NSOrderedCollectionChange1Test.cs

chamons · 2021-11-09T19:00:19Z

tests/monotouch-test/monotouch-test.csproj

@@ -394,7 +394,7 @@
    <Exec Command="xcrun -sdk $(_SmeltingSdk) metal -c @(CustomMetalSmeltingInput) -o $(IntermediateOutputPath)\fragmentShader.air $(_SmeltingMinOS)" EnvironmentVariables="DEVELOPER_DIR=$(_SdkDevPath)" />
    <Exec Command="xcrun -sdk $(_SmeltingSdk) metallib $(IntermediateOutputPath)\fragmentShader.air -o $(AppBundleDir)\fragmentShader.metallib" EnvironmentVariables="DEVELOPER_DIR=$(_SdkDevPath)" />
  </Target>
-  <Target Name="BeforeBuild" Inputs="@(GeneratedTestInput)" Outputs="@(GeneratedTestOutput)" DependsOnTargets="CustomMetalSmelting" >


Seems unrelated to PR?

IDE being stupid.

tj-devel709

Just some small things I noticed!

src/Foundation/Enums.cs

tj-devel709 · 2021-11-09T18:56:10Z

src/foundation.cs

@@ -3569,7 +3668,10 @@ interface NSMutableArray {
 		[iOS (8,0), Mac(10,10)]
 		[Static, Export ("arrayWithContentsOfURL:")]
 		NSMutableArray FromUrl (NSUrl url);
-


nit: Extra line removed

It was not removed. Someone left a tab and is added in the diff.

src/foundation.cs

tests/monotouch-test/Foundation/NSArray1Test.cs

tj-devel709 · 2021-11-09T19:02:58Z

tests/monotouch-test/Foundation/NSOrderedCollectionChange1Test.cs

+			TestRuntime.AssertXcodeVersion (13,0);
+
+			var str = new NSString ("Test");
+			var change = NSOrderedCollectionChange<NSString>.ChangeWithObject(str, NSCollectionChangeType.Insert, 0, 1);


Suggested change

var change = NSOrderedCollectionChange<NSString>.ChangeWithObject(str, NSCollectionChangeType.Insert, 0, 1);

var change = NSOrderedCollectionChange<NSString>.ChangeWithObject (str, NSCollectionChangeType.Insert, 0, 1);

```nit

Co-authored-by: TJ Lambert <50846373+tj-devel709@users.noreply.github.com> Co-authored-by: Chris Hamons <chris.hamons@xamarin.com>

dalexsoto

Nice! 👍++ for the generator fix and the tests!

vs-mobiletools-engineering-service2 · 2021-11-10T01:05:00Z

❌ [PR Build] Tests failed on Build ❌

Tests failed on Build.

API diff

✅ API Diff from stable

View API diff

iOS vsdrops gist
macOS vsdrops gist
tvOS vsdrops gist
watchOS vsdrops gist
macCatiOS vsdrops gist
macCat vsdrops gist

View dotnet API diff

dotnet-iOS vsdrops gist
dotnet-macOS vsdrops gist
dotnet-tvOS vsdrops gist
dotnet-MacCatalyst vsdrops gist

View dotnet legacy API diff

dotnet-legacy-iOS vsdrops gist
dotnet-legacy-macOS vsdrops gist
dotnet-legacy-tvOS vsdrops gist
dotnet-legacy-MacCatalyst vsdrops gist

View dotnet iOS-MacCatalayst API diff

dotnet-macCatiOS vsdrops gist

API & Generator diff

ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

Test results

11 tests failed, 90 tests passed.

Failed tests

introspection/Mac Catalyst [dotnet]/Debug [dotnet]: Failed (Tests run: 44 Passed: 41 Inconclusive: 0 Failed: 1 Ignored: 2)
introspection/iOS Unified 64-bits - simulator/Debug: Failed
introspection/tvOS - simulator/Debug: Failed
introspection/watchOS 32-bits - simulator/Debug: Failed
monotouch-test/Mac [dotnet]/Debug [dotnet]: Failed (Test run failed.
Tests run: 2569 Passed: 2415 Inconclusive: 10 Failed: 1 Ignored: 153)
monotouch-test/Mac Catalyst [dotnet]/Debug [dotnet]: Failed (Tests run: 2734 Passed: 2502 Inconclusive: 35 Failed: 1 Ignored: 231)
monotouch-test/iOS Unified 64-bits - simulator/Release (all optimizations): Failed
monotouch-test/tvOS - simulator/Release (all optimizations): Failed
xammac tests/Mac Modern/Debug: Failed (Test run failed.
Tests run: 2575 Passed: 2425 Inconclusive: 10 Failed: 1 Ignored: 149)
xammac tests/Mac Modern/Release: Failed (Test run failed.
Tests run: 2572 Passed: 2421 Inconclusive: 10 Failed: 1 Ignored: 150)
xammac tests/Mac Modern/Release (all optimizations): Failed (Test run failed.
Tests run: 2572 Passed: 2420 Inconclusive: 10 Failed: 1 Ignored: 151)

Pipeline on Agent XAMBOT-1104.BigSur'
Merge ea91c10 into f0ff01f

rolfbjarne · 2021-11-10T10:35:08Z

tests/monotouch-test/Foundation/NSArray1Test.cs

+						return first.ToString ().Equals (second.ToString ());
+					});
+			}, "Not throws");
+			Assert.NotNull (diff, "Not null");


Maybe assert that we get a specific diff result as well?

rolfbjarne · 2021-11-10T10:37:08Z

tests/monotouch-test/Foundation/NSOrderedCollectionDifference1Test.cs

+			var changes = new NSOrderedCollectionChange<NSString> [] { change };
+			using var diff = new NSOrderedCollectionDifference<NSString> (changes);
+			Assert.DoesNotThrow (() => {
+				var i = diff.Insertions;


Any reason for not asserting on the returned value?

Assert.AreEqual (1, diff.Insertions.Length, "insertions");

(or whatever it's supposed to return)

rolfbjarne · 2021-11-10T10:37:23Z

tests/monotouch-test/Foundation/NSOrderedCollectionDifferenceTest.cs

+			var changes = new NSOrderedCollectionChange [] { change };
+			using var diff = new NSOrderedCollectionDifference (changes);
+			Assert.DoesNotThrow (() => {
+				var i = diff.Insertions;


Same: assert on the returned value

rolfbjarne · 2021-11-10T11:36:51Z

src/Foundation/NSMutableOrderedSet_1.cs

+		[SupportedOSPlatform ("ios13.0"), SupportedOSPlatform ("tvos13.0"), SupportedOSPlatform ("macos10.15")]
+#endif
+		public void ApplyDifference (NSOrderedCollectionDifference<TKey> difference)
+			=> _ApplyDifference (difference.Handle);


NRE if difference is null

src/Foundation/NSOrderedCollectionChange.cs

src/Foundation/NSOrderedSet_1.cs

rolfbjarne · 2021-11-10T11:51:23Z

src/foundation.cs

+		[Watch (6,0), TV (13,0), Mac (10,15), iOS (13,0)]
+		[Static]
+		[Export ("stringFromMeasurement:countStyle:")]
+		string StringFromMeasurement (NSUnitInformationStorage  measurement, NSByteCountFormatterCountStyle countStyle);


This needs a verb:

Suggested change

string StringFromMeasurement (NSUnitInformationStorage measurement, NSByteCountFormatterCountStyle countStyle);

string Create (NSUnitInformationStorage measurement, NSByteCountFormatterCountStyle countStyle);

src/foundation.cs

rolfbjarne · 2021-11-10T11:53:25Z

src/foundation.cs

@@ -7278,6 +7393,10 @@ partial interface NSUrlSessionTask : NSCopying, NSProgressReporting
 		[Export ("countOfBytesClientExpectsToReceive")]
 		long CountOfBytesClientExpectsToReceive { get; set; }

+		[Watch (8, 0), TV (15, 0), Mac (12, 0), iOS (15, 0), MacCatalyst (15,0)]
+		[NullAllowed, Export ("delegate", ArgumentSemantic.Retain)]
+		NSObject WeakDelegate { get; set; }


Is there a strongly typed Delegate property?

src/foundation.cs

Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com>

mandel-macaque · 2021-11-11T19:58:39Z

/azp run

azure-pipelines · 2021-11-11T19:58:44Z

Pull request contains merge conflicts.

dalexsoto · 2022-01-20T03:51:20Z

@mandel-macaque is this still a thing? we may want to land it before @chamons converts attributes on Foundation

- This is based upon Manuel's xamarin#13328

- Based upon xamarin#13328

- Xcode 13 section Based upon #13328 - Some disabled due to https://github.com/xamarin/maccore/issues/2608

mandel-macaque added 6 commits October 22, 2021 09:19

[Foundation] Add support for xcode 13.1 rc.

573c769

[Foundation] Providing bindings up to Xcode 13.1

012f27c

Merge branch 'main' into foundation-xcode13-beta5

8df609e

Merge branch 'main' into foundation-xcode13-beta5

dab9ab2

Remove attr.

8725ebf

Merge branch 'main' into foundation-xcode13-beta5

a4e3195

mandel-macaque added the note-highlight Worth calling out specifically in release notes label Nov 9, 2021

mandel-macaque requested review from chamons, dalexsoto and rolfbjarne as code owners November 9, 2021 18:46

tj-devel709 reviewed Nov 9, 2021

View reviewed changes

src/Foundation/Enums.cs Outdated Show resolved Hide resolved

chamons approved these changes Nov 9, 2021

View reviewed changes

tj-devel709 reviewed Nov 9, 2021

View reviewed changes

Apply suggestions from code review

ea91c10

Co-authored-by: TJ Lambert <50846373+tj-devel709@users.noreply.github.com> Co-authored-by: Chris Hamons <chris.hamons@xamarin.com>

dalexsoto approved these changes Nov 9, 2021

View reviewed changes

rolfbjarne requested changes Nov 10, 2021

View reviewed changes

Apply suggestions from code review

6335730

Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com>

mandel-macaque added 5 commits November 30, 2021 12:57

Merge branch 'main' into foundation-xcode13-beta5

40cdd53

Merge branch 'main' into foundation-xcode13-beta5

8fa7ac7

Fix xtro issues after the merge with main.

18668a8

Merge branch 'main' into foundation-xcode13-beta5

512f27c

Address reviews.

ae50278

mandel-macaque closed this Mar 31, 2022

chamons pushed a commit to chamons/xamarin-macios that referenced this pull request Jul 22, 2022

[Foundation] Add support for xcode 13.1 rc.

0dcf5fc

- This is based upon Manuel's xamarin#13328

chamons mentioned this pull request Jul 26, 2022

NSOrderedCollectionDifference binding in Xcode 13 has issue with generic MonoPInvokeCallback and generator #15577

Open

chamons added a commit to chamons/xamarin-macios that referenced this pull request Jul 26, 2022

[xcode13] Add Foundation from Xcode 13.0

b945c2d

- Based upon xamarin#13328

chamons mentioned this pull request Jul 26, 2022

[foundation] Xcode 13 & Xcode 14 beta 1-3 bindings #15579

Merged

chamons added a commit that referenced this pull request Aug 1, 2022

[foundation] Xcode 13 & Xcode 14 beta 1-3 bindings (#15579)

3c359f5

- Xcode 13 section Based upon #13328 - Some disabled due to https://github.com/xamarin/maccore/issues/2608

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Foundation] Add bindings for Xcode 13 rc 1. #13328

[Foundation] Add bindings for Xcode 13 rc 1. #13328

mandel-macaque commented Nov 9, 2021

chamons left a comment

chamons Nov 9, 2021

mandel-macaque Nov 9, 2021

chamons Nov 9, 2021

mandel-macaque Jul 26, 2022

chamons Nov 9, 2021

mandel-macaque Nov 9, 2021

tj-devel709 left a comment

tj-devel709 Nov 9, 2021

mandel-macaque Nov 9, 2021

tj-devel709 Nov 9, 2021

dalexsoto left a comment

vs-mobiletools-engineering-service2 commented Nov 10, 2021

Failed tests

rolfbjarne Nov 10, 2021

rolfbjarne Nov 10, 2021

rolfbjarne Nov 10, 2021

rolfbjarne Nov 10, 2021

rolfbjarne Nov 10, 2021

rolfbjarne Nov 10, 2021

mandel-macaque commented Nov 11, 2021

azure-pipelines bot commented Nov 11, 2021

dalexsoto commented Jan 20, 2022

	var change = NSOrderedCollectionChange<NSString>.ChangeWithObject(str, NSCollectionChangeType.Insert, 0, 1);
	var change = NSOrderedCollectionChange<NSString>.ChangeWithObject (str, NSCollectionChangeType.Insert, 0, 1);
	```nit

	string StringFromMeasurement (NSUnitInformationStorage measurement, NSByteCountFormatterCountStyle countStyle);
	string Create (NSUnitInformationStorage measurement, NSByteCountFormatterCountStyle countStyle);

[Foundation] Add bindings for Xcode 13 rc 1. #13328

[Foundation] Add bindings for Xcode 13 rc 1. #13328

Conversation

mandel-macaque commented Nov 9, 2021

chamons left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tj-devel709 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dalexsoto left a comment

Choose a reason for hiding this comment

vs-mobiletools-engineering-service2 commented Nov 10, 2021

❌ [PR Build] Tests failed on Build ❌

API diff

API & Generator diff

GitHub pages

Test results

Failed tests

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mandel-macaque commented Nov 11, 2021

azure-pipelines bot commented Nov 11, 2021

dalexsoto commented Jan 20, 2022