[WebKit] Unseal a few members in XAMCORE_3_0+ that don't need to be sealed anymore. #14054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ealed anymore. In all cases these members were sealed to avoid a duplicate selector error, but all those duplications don't exist anymore in XAMCORE_3_0, so we can unseal these members.
rolfbjarne
added
not-notes-worthy
tj-devel709
approved these changes
Feb 3, 2022
chamons
approved these changes
Feb 3, 2022
mandel-macaque
approved these changes
Feb 3, 2022
❌ [PR Build] Tests failed on Build ❌Tests failed on Build. API diff✅ API Diff from stable View dotnet API diffView dotnet legacy API diffView dotnet iOS-MacCatalayst API diff
API Current PR diffℹ️ API Diff (from PR only) (please review changes) View dotnet API diffView dotnet legacy API diffView dotnet iOS-MacCatalayst API diff
Generator diffℹ️ Generator Diff (please review changes) GitHub pagesResults can be found in the following github pages (it might take some time to publish): Test results1 tests failed, 147 tests passed.Failed tests
Pipeline on Agent XAMBOT-1098.BigSur' |
dalexsoto
approved these changes
Feb 4, 2022
|
Test failure is unrelated (https://github.com/xamarin/maccore/issues/2443). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In all cases these members were sealed to avoid a duplicate selector error,
but all those duplications don't exist anymore in XAMCORE_3_0, so we can
unseal these members.