[WebKit] Add support for Xcode 14 beta 1, 2 & 3 #15525

SotoiGhost · 2022-07-15T19:57:07Z

No description provided.

dalexsoto

Looking good!

src/wkwebkit.cs

SotoiGhost · 2022-07-15T20:54:48Z

These methods depend on new API on UIKit. Already created an issue and added the issue here.

xamarin-macios/src/wkwebkit.cs

Lines 1049 to 1055 in e05ad13

    
           // [iOS (16,0), MacCatalyst (16,0), NoMac, NoWatch, NoTV] 
        
           // [Export ("findInteractionEnabled")] 
        
           // bool FindInteractionEnabled { [Bind ("isFindInteractionEnabled")] get; set; } 
        
           // [iOS (16,0), MacCatalyst (16,0), NoMac, NoWatch, NoTV] 
        
           // [Export ("findInteraction")] 
        
           // UIFindInteraction FindInteraction { get; }

mandel-macaque

+1 but I'd like answers before landing.

src/wkwebkit.cs

tj-devel709

Looks good to me after other comments are addressed!

mandel-macaque · 2022-07-20T16:41:24Z

src/wkwebkit.cs

+
+		[Mac (13,0), iOS (16,0), MacCatalyst (16,0), NoWatch, NoTV]
+		[Export ("lockdownModeEnabled")]
+		bool LockdownModeEnabled { [Bind ("isLockdownModeEnabled")] get; set; }


Intro says that te property does NOT work on iOS.

mandel-macaque · 2022-07-20T16:41:32Z

@SotoiGhost the intro tests failures must be fixed:

FAIL] Selector not found for WebKit.WKWebpagePreferences : isLockdownModeEnabled in Boolean get_LockdownModeEnabled() on WebKit.WKWebpagePreferences 
[FAIL] Selector not found for WebKit.WKWebpagePreferences : setLockdownModeEnabled: in Void set_LockdownModeEnabled(Boolean) on WebKit.WKWebpagePreferences

* xamarin#15526 * Removed some todo files

Those selectors are available within the framework but for some reason they cannot be called. Doing so will end with the app crashing

SotoiGhost · 2022-07-29T23:30:29Z

PR already rebased with xcode14 b4 bump. Waiting for CI results

vs-mobiletools-engineering-service2 · 2022-08-04T16:28:33Z

💻 [PR Build] Tests on macOS Mac Catalina (10.15) passed 💻

✅ All tests on macOS Mac Catalina (10.15) passed.

Pipeline on Agent
Hash: 5b5998f387e7da6ea24405ec35fabdc5dd6c2eb6 [PR build]

vs-mobiletools-engineering-service2 · 2022-08-04T16:30:24Z

📚 [PR Build] Artifacts 📚

Packages generated

View packages

Pipeline on Agent XAMBOT-1181.Monterey'
Hash: 5b5998f387e7da6ea24405ec35fabdc5dd6c2eb6 [PR build]

vs-mobiletools-engineering-service2 · 2022-08-04T16:39:36Z

✅ API diff for current PR / commit

Legacy Xamarin (No breaking changes)

iOS: vsdrops gist (No breaking changes)
tvOS: vsdrops gist (No breaking changes)
watchOS: vsdrops gist (No breaking changes)
macOS: vsdrops gist (No breaking changes)

.NET (No breaking changes)

iOS: vsdrops gist (No breaking changes)
tvOS: vsdrops gist (No breaking changes)
MacCatalyst: vsdrops gist (No breaking changes)
macOS: vsdrops gist (No breaking changes)

❗ API diff vs stable (Breaking changes)

Legacy Xamarin (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)

iOS: vsdrops gist (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
tvOS: vsdrops gist (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
watchOS: vsdrops gist (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
macOS: vsdrops gist (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)

.NET (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)

iOS: vsdrops gist (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
tvOS: vsdrops gist (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
MacCatalyst: vsdrops gist (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
macOS: vsdrops gist (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
Microsoft.iOS vs Microsoft.MacCatalyst: vsdrops gist

Legacy Xamarin (stable) vs .NET

iOS: vsdrops gist
tvOS: vsdrops gist
macOS: vsdrops gist

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 5b5998f387e7da6ea24405ec35fabdc5dd6c2eb6 [PR build]

vs-mobiletools-engineering-service2 · 2022-08-04T16:42:39Z

❌ [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) failed ❌

Failed tests are:

monotouch-test

Pipeline on Agent
Hash: 5b5998f387e7da6ea24405ec35fabdc5dd6c2eb6 [PR build]

vs-mobiletools-engineering-service2 · 2022-08-04T20:46:55Z

🔥 [CI Build] Test results 🔥

Test results

❌ Tests failed on VSTS: simulator tests

0 tests crashed, 4 tests failed, 224 tests passed.

Failures

❌ cecil tests

1 tests failed, 0 tests passed.

Cecil-based tests/NUnit: Failed (Execution failed with exit code 6)

Html Report (VSDrops) Download

❌ introspection tests

1 tests failed, 12 tests passed.

introspection/watchOS 32-bits - simulator/Debug (watchOS 6.0): Crashed Known issue: HE0038)

Html Report (VSDrops) Download

❌ xtro tests

2 tests failed, 0 tests passed.

Xtro/Legacy Xamarin: Failed (Test run failed.)
Xtro/.NET: BuildFailure

Html Report (VSDrops) Download

Successes

✅ bcl: All 69 tests passed. Html Report (VSDrops) Download
✅ dotnettests: All 1 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 7 tests passed. Html Report (VSDrops) Download
✅ framework: All 8 tests passed. Html Report (VSDrops) Download
✅ generator: All 2 tests passed. Html Report (VSDrops) Download
✅ interdependent_binding_projects: All 7 tests passed. Html Report (VSDrops) Download
✅ install_source: All 1 tests passed. Html Report (VSDrops) Download
✅ linker: All 65 tests passed. Html Report (VSDrops) Download
✅ mac_binding_project: All 1 tests passed. Html Report (VSDrops) Download
✅ mmp: All 2 tests passed. Html Report (VSDrops) Download
✅ mononative: All 12 tests passed. Html Report (VSDrops) Download
✅ monotouch: All 23 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ mtouch: All 1 tests passed. Html Report (VSDrops) Download
✅ xammac: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 8 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: [PR build]

mandel-macaque · 2022-08-04T21:05:18Z

xtro failures are fixed here: #15625
intro is known: https://github.com/xamarin/maccore/issues/581
cecil tests are fixed here: #15610

dalexsoto requested changes Jul 15, 2022

View reviewed changes

src/wkwebkit.cs Show resolved Hide resolved

src/wkwebkit.cs Outdated Show resolved Hide resolved

src/wkwebkit.cs Show resolved Hide resolved

src/wkwebkit.cs Outdated Show resolved Hide resolved

src/wkwebkit.cs Outdated Show resolved Hide resolved

src/wkwebkit.cs Show resolved Hide resolved

dalexsoto added this to the xcode14 milestone Jul 15, 2022

dalexsoto added the notes-mention Deserves a mention in release notes label Jul 15, 2022

SotoiGhost requested a review from dalexsoto July 15, 2022 20:55

mandel-macaque approved these changes Jul 15, 2022

View reviewed changes

src/wkwebkit.cs Show resolved Hide resolved

src/wkwebkit.cs Outdated Show resolved Hide resolved

This comment has been minimized.

Sign in to view

tj-devel709 approved these changes Jul 18, 2022

View reviewed changes

dalexsoto approved these changes Jul 18, 2022

View reviewed changes

This comment has been minimized.

Sign in to view

mandel-macaque requested changes Jul 20, 2022

View reviewed changes

This comment has been minimized.

Sign in to view

Israel Soto added 8 commits July 29, 2022 17:46

[WebKit] Added support for Xcode 14 beta1

df78555

[WebKit] Added support for Xcode 14 beta2

7e3a587

[WebKit] Added support for Xcode 14 beta3

529db08

[WebKit] Added suggestions

5cc2658

[WebKit] Added files modified by auto sanitize

6514efd

[WebKit] Ignored pending missing selectors

df106a1

* xamarin#15526 * Removed some todo files

[WebKit] Removing LockdownModeEnabled property as it cannot be called

be2f09b

Those selectors are available within the framework but for some reason they cannot be called. Doing so will end with the app crashing

[WebKit] Added an issue link to common-WebKit.ignore

e75e1b0

SotoiGhost force-pushed the xcode14-WebKit branch from 980399d to e75e1b0 Compare July 29, 2022 23:29

This comment has been minimized.

Sign in to view

Merge branch 'xcode14' into xcode14-WebKit

5b5998f

mandel-macaque merged commit f850a20 into xamarin:xcode14 Aug 4, 2022

[WebKit] Add support for Xcode 14 beta 1, 2 & 3 #15525

[WebKit] Add support for Xcode 14 beta 1, 2 & 3 #15525

Conversation

SotoiGhost commented Jul 15, 2022

dalexsoto left a comment

Choose a reason for hiding this comment

SotoiGhost commented Jul 15, 2022

mandel-macaque left a comment

Choose a reason for hiding this comment

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

tj-devel709 left a comment

Choose a reason for hiding this comment

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

mandel-macaque Jul 20, 2022

Choose a reason for hiding this comment

mandel-macaque commented Jul 20, 2022

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

SotoiGhost commented Jul 29, 2022

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Aug 4, 2022

💻 [PR Build] Tests on macOS Mac Catalina (10.15) passed 💻

vs-mobiletools-engineering-service2 commented Aug 4, 2022

📚 [PR Build] Artifacts 📚

Packages generated

vs-mobiletools-engineering-service2 commented Aug 4, 2022

✅ API diff for current PR / commit

❗ API diff vs stable (Breaking changes)

ℹ️ Generator diff

vs-mobiletools-engineering-service2 commented Aug 4, 2022

❌ [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) failed ❌

vs-mobiletools-engineering-service2 commented Aug 4, 2022

🔥 [CI Build] Test results 🔥

Test results

Failures

❌ cecil tests

❌ introspection tests

❌ xtro tests

Successes

mandel-macaque commented Aug 4, 2022