Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ExtensionKit] Add support for Xcode 14 beta 1 & 2 #15548

Merged
merged 5 commits into from
Sep 6, 2022

Conversation

SotoiGhost
Copy link
Contributor

No description provided.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

Copy link
Member

@mandel-macaque mandel-macaque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a few things that are missing for this to work.

  1. You need to update https://github.com/xamarin/xamarin-macios/blob/main/src/frameworks.sources since you need to process the code
  2. You need to add the new library paths here: https://github.com/xamarin/xamarin-macios/blob/main/tools/common/Frameworks.cs

I think that is all since this is a mac framework.

@mandel-macaque mandel-macaque added the notes-mention Deserves a mention in release notes label Jul 19, 2022
@mandel-macaque mandel-macaque added this to the xcode14 milestone Jul 19, 2022
@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@SotoiGhost SotoiGhost force-pushed the ExtensionKit-xcode14 branch from 1fc4c8c to d71d0d9 Compare July 25, 2022 21:19
@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

Copy link
Member

@rolfbjarne rolfbjarne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You also need to add an entry in this list:

static IntPtr fl = Dlfcn.dlopen (Constants.FoundationLibrary, 1);
static IntPtr al = Dlfcn.dlopen (Constants.AppKitLibrary, 1);
static IntPtr ab = Dlfcn.dlopen (Constants.AddressBookLibrary, 1);
static IntPtr ct = Dlfcn.dlopen (Constants.CoreTextLibrary, 1);
static IntPtr wl = Dlfcn.dlopen (Constants.WebKitLibrary, 1);
static IntPtr zl = Dlfcn.dlopen (Constants.QuartzLibrary, 1);
#if !NET
static IntPtr ql = Dlfcn.dlopen (Constants.QTKitLibrary, 1);
#endif
static IntPtr cl = Dlfcn.dlopen (Constants.CoreLocationLibrary, 1);
static IntPtr ll = Dlfcn.dlopen (Constants.SecurityLibrary, 1);
static IntPtr zc = Dlfcn.dlopen (Constants.QuartzComposerLibrary, 1);
static IntPtr cw = Dlfcn.dlopen (Constants.CoreWlanLibrary, 1);
static IntPtr pk = Dlfcn.dlopen (Constants.PdfKitLibrary, 1);
static IntPtr ik = Dlfcn.dlopen (Constants.ImageKitLibrary, 1);
static IntPtr sb = Dlfcn.dlopen (Constants.ScriptingBridgeLibrary, 1);
static IntPtr av = Dlfcn.dlopen (Constants.AVFoundationLibrary, 1);
static IntPtr js = Dlfcn.dlopen (Constants.JavaScriptCoreLibrary, 1);
static IntPtr sk = Dlfcn.dlopen (Constants.SceneKitLibrary, 1);
static IntPtr bl = Dlfcn.dlopen (Constants.CoreBluetoothLibrary, 1);
static IntPtr st = Dlfcn.dlopen (Constants.StoreKitLibrary, 1);
static IntPtr gk = Dlfcn.dlopen (Constants.GameKitLibrary, 1);
static IntPtr ib = Dlfcn.dlopen (Constants.IOBluetoothLibrary, 1);
static IntPtr bu = Dlfcn.dlopen (Constants.IOBluetoothUILibrary, 1);
static IntPtr ca = Dlfcn.dlopen (Constants.CoreAudioKitLibrary, 1);
static IntPtr im = Dlfcn.dlopen (Constants.InputMethodKitLibrary, 1);
static IntPtr ol = Dlfcn.dlopen (Constants.OpenALLibrary, 1);
static IntPtr ma = Dlfcn.dlopen (Constants.MediaAccessibilityLibrary, 1);
static IntPtr mi = Dlfcn.dlopen (Constants.CoreMidiLibrary, 1);
static IntPtr ic = Dlfcn.dlopen (Constants.ImageCaptureCoreLibrary, 1);
static IntPtr it = Dlfcn.dlopen (Constants.IntentsLibrary, 1);
static IntPtr me = Dlfcn.dlopen (Constants.MediaLibraryLibrary, 1);
static IntPtr gl = Dlfcn.dlopen (Constants.GLKitLibrary, 1);
static IntPtr sp = Dlfcn.dlopen (Constants.SpriteKitLibrary, 1);
static IntPtr ck = Dlfcn.dlopen (Constants.CloudKitLibrary, 1);
static IntPtr la = Dlfcn.dlopen (Constants.LocalAuthenticationLibrary, 1);
static IntPtr ac = Dlfcn.dlopen (Constants.AccountsLibrary, 1);
// Contacts must come before MapKit to fix 33576 due to spam in MKContactsShim
static IntPtr cn = Dlfcn.dlopen (Constants.ContactsLibrary, 1);
static IntPtr cu = Dlfcn.dlopen (Constants.ContactsUILibrary, 1);
static IntPtr mk = Dlfcn.dlopen (Constants.MapKitLibrary, 1);
static IntPtr ek = Dlfcn.dlopen (Constants.EventKitLibrary, 1);
static IntPtr so = Dlfcn.dlopen (Constants.SocialLibrary, 1);
static IntPtr gc = Dlfcn.dlopen (Constants.GameControllerLibrary, 1);
static IntPtr ak = Dlfcn.dlopen (Constants.AVKitLibrary, 1);
static IntPtr vt = Dlfcn.dlopen (Constants.VideoToolboxLibrary, 1);
static IntPtr gp = Dlfcn.dlopen (Constants.GameplayKitLibrary, 1);
static IntPtr ne = Dlfcn.dlopen (Constants.NetworkExtensionLibrary, 1);
static IntPtr mc = Dlfcn.dlopen (Constants.MultipeerConnectivityLibrary, 1);
static IntPtr fs = Dlfcn.dlopen (Constants.FinderSyncLibrary, 1);
static IntPtr ml = Dlfcn.dlopen (Constants.MetalKitLibrary, 1);
static IntPtr io = Dlfcn.dlopen (Constants.ModelIOLibrary, 1);
static IntPtr nc = Dlfcn.dlopen (Constants.NotificationCenterLibrary, 1);
static IntPtr pl = Dlfcn.dlopen (Constants.PhotosLibrary, 1);
static IntPtr pu = Dlfcn.dlopen (Constants.PhotosUILibrary, 1);
static IntPtr mp = Dlfcn.dlopen (Constants.MediaPlayerLibrary, 1);
static IntPtr pc = Dlfcn.dlopen (Constants.PrintCoreLibrary, 1);
static IntPtr cml = Dlfcn.dlopen (Constants.CoreMLLibrary, 1);
static IntPtr vn = Dlfcn.dlopen (Constants.VisionLibrary, 1);
static IntPtr ios = Dlfcn.dlopen (Constants.IOSurfaceLibrary, 1);
static IntPtr ex = Dlfcn.dlopen (Constants.ExternalAccessoryLibrary, 1);
static IntPtr ms = Dlfcn.dlopen (Constants.MetalPerformanceShadersLibrary, 1);
static IntPtr msg = Dlfcn.dlopen (Constants.MetalPerformanceShadersGraphLibrary, 1);
static IntPtr bc = Dlfcn.dlopen (Constants.BusinessChatLibrary, 1);
static IntPtr ad = Dlfcn.dlopen (Constants.AdSupportLibrary, 1);
static IntPtr nl = Dlfcn.dlopen (Constants.NaturalLanguageLibrary, 1);
static IntPtr vs = Dlfcn.dlopen (Constants.VideoSubscriberAccountLibrary, 1);
static IntPtr un = Dlfcn.dlopen (Constants.UserNotificationsLibrary, 1);
static IntPtr il = Dlfcn.dlopen (Constants.iTunesLibraryLibrary, 1);

@@ -277,6 +277,7 @@ public Framework Find (string framework)
{ "ScreenCaptureKit", "ScreenCaptureKit", 12,3 },

{ "BackgroundAssets", "BackgroundAssets", 13,0},
{ "ExtensionKit", "ExtensionKit", 13,0 },
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spaces -> tabs

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird...

image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a rebase, I'm seeing this now, don't know what happened

@rolfbjarne
Copy link
Member

Also make sure to update the PR to the latest beta

@SotoiGhost SotoiGhost force-pushed the ExtensionKit-xcode14 branch from 6e56ccc to 1aa4706 Compare August 22, 2022 18:09
@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@dalexsoto
Copy link
Member

@SotoiGhost please look at the intro failures

@SotoiGhost SotoiGhost force-pushed the ExtensionKit-xcode14 branch from 1aa4706 to a3c510f Compare August 26, 2022 16:25
@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@mandel-macaque mandel-macaque merged commit a869ea0 into xamarin:xcode14 Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
notes-mention Deserves a mention in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants