[UIKit] Add support for Xcode 14 up to beta 5. #15694

mandel-macaque · 2022-08-18T12:37:13Z

No description provided.

src/UIKit/UIEnums.cs

rolfbjarne · 2022-08-18T12:40:14Z

tests/xtro-sharpie/tvOS-UIKit.ignore

@@ -330,11 +330,11 @@
 !missing-null-allowed! 'UIKit.UIWindow UIKit.UIView::get_Window()' is missing an [NullAllowed] on return type

 ## not available on tvOS (iOS 14+ only)


This comment is commenting about nothing now

src/xkit.cs

src/uikit.cs

stephen-hawley · 2022-08-18T13:29:59Z

src/UIKit/UIEnums.cs

@@ -779,6 +779,10 @@ public enum UIDataDetectorType : ulong {
 		FlightNumber           = 1 << 5,
 		[iOS (10,0)]
 		LookupSuggestion       = 1 << 6,
+		[NoWatch, NoTV, iOS (16,0), MacCatalyst (16,0)]
+		Money = 1uL << 7,


minor - either use 1 << 7 here to be consistent with all the others or change the others to be 1uL << n. I would personally do the former since the backing type is ulong so the uL is redundant.

tj-devel709

Great work! Left some suggestions :)

src/UIKit/UIEnums.cs

src/uikit.cs

src/xkit.cs

stephen-hawley

That was a Herculean task. Nice.

stephen-hawley · 2022-08-18T13:37:04Z

src/uikit.cs

@@ -2900,10 +3091,12 @@ interface UIContextMenuInteractionDelegate {
 		[return: NullAllowed]
 		UIContextMenuConfiguration GetConfigurationForMenu (UIContextMenuInteraction interaction, CGPoint location);

+		[Deprecated (PlatformName.iOS, 16, 0)]


Should there be a message for this? I don't know our typical policy for this. Personally, I view deprecation as either a detour sign (what's my alternative?) or an apology.

There should, but we do not know the reason, so I can only say it was deprecated by apple.

stephen-hawley · 2022-08-18T13:40:12Z

src/uikit.cs

+		[Watch (9,0), TV (16,0), MacCatalyst (16,0), iOS (16,0)]
+		[Static]
+		[Export ("configurationPreferringMonochrome")]
+		UIImageSymbolConfiguration GetConfigurationPreferringMonochrome ();


Should this be a property instead of a method? It takes no parameters and returns a single value...

I don't know, let me check with the rest of the API what is what we usually done. Is better to be consistent.

src/uikit.cs

Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com> Co-authored-by: TJ Lambert <50846373+tj-devel709@users.noreply.github.com>

src/uikit.cs

dalexsoto · 2022-08-18T20:10:34Z

src/uikit.cs

-		// TODO: Enable when Foundation return type is bound
-		// [Export ("difference")]
-		// NSOrderedCollectionDifference<ItemIdentifierType> Difference { get; }
+#if false // https://github.com/xamarin/xamarin-macios/issues/15577


src/uikit.cs

dalexsoto · 2022-08-18T20:33:05Z

src/uikit.cs

+		string ReplacementText { get; set; }
+
+		[NullAllowed, Export ("optionsMenuProvider", ArgumentSemantic.Copy)]
+		Func<NSArray<UIMenuElement>, UIMenu> OptionsMenuProvider { get; set; }


Maybe use this instead of the func? to avoid the NSArray

delegate UIMenu OptionsMenuProviderHandler (UIMenuElement [] elements);

Co-authored-by: Alex Soto <alex@alexsoto.me>

…ios into uikit-xcode14

Also we need to use named parameters so the C# overload resolution actually resolves the right constructor to call when using our convenience ctor.

vs-mobiletools-engineering-service2 · 2022-08-26T21:17:50Z

✅ API diff for current PR / commit

Legacy Xamarin (No breaking changes)

iOS: vsdrops gist (No breaking changes)
tvOS: vsdrops gist (No breaking changes)
watchOS: vsdrops gist (No breaking changes)
macOS: vsdrops gist (No breaking changes)

.NET (No breaking changes)

iOS: vsdrops gist (No breaking changes)
tvOS: vsdrops gist (No breaking changes)
MacCatalyst: vsdrops gist (No breaking changes)
macOS: vsdrops gist (No breaking changes)

✅ API diff vs stable

Legacy Xamarin (No breaking changes)

iOS: vsdrops gist (No breaking changes)
tvOS: vsdrops gist (No breaking changes)
watchOS: vsdrops gist (No breaking changes)
macOS: vsdrops gist (No breaking changes)

.NET (No breaking changes)

iOS: vsdrops gist (No breaking changes)
tvOS: vsdrops gist (No breaking changes)
MacCatalyst: vsdrops gist (No breaking changes)
macOS: vsdrops gist (No breaking changes)
Microsoft.iOS vs Microsoft.MacCatalyst: vsdrops gist

Legacy Xamarin (stable) vs .NET

iOS: vsdrops gist
tvOS: vsdrops gist
macOS: vsdrops gist

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: f7494ac827bcc466a863f7a0c532d76ba8a6a21a [PR build]

vs-mobiletools-engineering-service2 · 2022-08-26T21:21:07Z

💻 [PR Build] Tests on macOS Mac Catalina (10.15) passed 💻

✅ All tests on macOS Mac Catalina (10.15) passed.

Pipeline on Agent
Hash: f7494ac827bcc466a863f7a0c532d76ba8a6a21a [PR build]

vs-mobiletools-engineering-service2 · 2022-08-26T21:23:07Z

📚 [PR Build] Artifacts 📚

Packages generated

View packages

Pipeline on Agent XAMBOT-1171.Monterey'
Hash: f7494ac827bcc466a863f7a0c532d76ba8a6a21a [PR build]

vs-mobiletools-engineering-service2 · 2022-08-26T21:42:19Z

❌ [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) failed ❌

Failed tests are:

xammac_tests
monotouch-test

Pipeline on Agent
Hash: f7494ac827bcc466a863f7a0c532d76ba8a6a21a [PR build]

vs-mobiletools-engineering-service2 · 2022-08-26T23:54:02Z

🔥 [CI Build] Test results 🔥

Test results

❌ Tests failed on VSTS: simulator tests

0 tests crashed, 1 tests failed, 227 tests passed.

Failures

❌ introspection tests

1 tests failed, 12 tests passed.

introspection/watchOS 32-bits - simulator/Debug (watchOS 6.0): Crashed Known issue: HE0038)

Html Report (VSDrops) Download

Successes

✅ bcl: All 69 tests passed. Html Report (VSDrops) Download
✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests: All 1 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 7 tests passed. Html Report (VSDrops) Download
✅ framework: All 8 tests passed. Html Report (VSDrops) Download
✅ generator: All 2 tests passed. Html Report (VSDrops) Download
✅ interdependent_binding_projects: All 7 tests passed. Html Report (VSDrops) Download
✅ install_source: All 1 tests passed. Html Report (VSDrops) Download
✅ linker: All 65 tests passed. Html Report (VSDrops) Download
✅ mac_binding_project: All 1 tests passed. Html Report (VSDrops) Download
✅ mmp: All 2 tests passed. Html Report (VSDrops) Download
✅ mononative: All 12 tests passed. Html Report (VSDrops) Download
✅ monotouch: All 23 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ mtouch: All 1 tests passed. Html Report (VSDrops) Download
✅ xammac: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 8 tests passed. Html Report (VSDrops) Download
✅ xtro: All 2 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: [PR build]

dalexsoto · 2022-08-27T00:01:16Z

Crashed Known issue: https://github.com/xamarin/maccore/issues/581

mandel-macaque added 4 commits August 10, 2022 11:10

[UIKit] Add support for Xcode 14 up to beta 5.

6209233

Merge branch 'xcode14' into uikit-xcode14

49e3519

Bump for xcode 14 beta5.

52a49c5

Implement the missing selectors and changes for beta 5

071ae73

mandel-macaque added the notes-mention Deserves a mention in release notes label Aug 18, 2022

mandel-macaque added this to the xcode14 milestone Aug 18, 2022

mandel-macaque requested review from dalexsoto, rolfbjarne and chamons as code owners August 18, 2022 12:37

rolfbjarne requested changes Aug 18, 2022

View reviewed changes

stephen-hawley reviewed Aug 18, 2022

View reviewed changes

tj-devel709 reviewed Aug 18, 2022

View reviewed changes

stephen-hawley reviewed Aug 18, 2022

View reviewed changes

This comment has been minimized.

Sign in to view

mandel-macaque commented Aug 18, 2022

View reviewed changes

src/uikit.cs Outdated Show resolved Hide resolved

mandel-macaque and others added 3 commits August 18, 2022 11:47

Apply suggestions from code review

a858fbe

Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com> Co-authored-by: TJ Lambert <50846373+tj-devel709@users.noreply.github.com>

Address the last changes needed from the reviews.

60ab4c1

Wrong xcode version.

b63b613

This comment has been minimized.

Sign in to view

dalexsoto approved these changes Aug 18, 2022

View reviewed changes

mandel-macaque and others added 3 commits August 18, 2022 16:55

Apply suggestions from code review

41da5dd

Co-authored-by: Alex Soto <alex@alexsoto.me>

Address reviews.

749aadc

Merge branch 'uikit-xcode14' of github.com:mandel-macaque/xamarin-mac…

3a03b1f

…ios into uikit-xcode14

This comment has been minimized.

Sign in to view

tj-devel709 approved these changes Aug 22, 2022

View reviewed changes

Merge branch 'xcode14' into uikit-xcode14

ccb4c58

This comment has been minimized.

Sign in to view

Merge branch 'xcode14' into uikit-xcode14

127531d

This comment has been minimized.

Sign in to view

Fix tests

0a2c963

Also we need to use named parameters so the C# overload resolution actually resolves the right constructor to call when using our convenience ctor.

This comment has been minimized.

Sign in to view

Fix incomplete bindings on UITableViewSource

f38c30e

This comment has been minimized.

Sign in to view

Add missing tvos attributes

f7494ac

dalexsoto merged commit 8cecb96 into xamarin:xcode14 Aug 27, 2022

		@@ -330,11 +330,11 @@
		!missing-null-allowed! 'UIKit.UIWindow UIKit.UIView::get_Window()' is missing an [NullAllowed] on return type

		## not available on tvOS (iOS 14+ only)

[UIKit] Add support for Xcode 14 up to beta 5. #15694

[UIKit] Add support for Xcode 14 up to beta 5. #15694

Conversation

mandel-macaque commented Aug 18, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tj-devel709 left a comment

Choose a reason for hiding this comment

stephen-hawley left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Choose a reason for hiding this comment

Choose a reason for hiding this comment

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Aug 26, 2022

✅ API diff for current PR / commit

✅ API diff vs stable

ℹ️ Generator diff

vs-mobiletools-engineering-service2 commented Aug 26, 2022

💻 [PR Build] Tests on macOS Mac Catalina (10.15) passed 💻

vs-mobiletools-engineering-service2 commented Aug 26, 2022

📚 [PR Build] Artifacts 📚

Packages generated

vs-mobiletools-engineering-service2 commented Aug 26, 2022

❌ [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) failed ❌

vs-mobiletools-engineering-service2 commented Aug 26, 2022

🔥 [CI Build] Test results 🔥

Test results

Failures

❌ introspection tests

Successes

dalexsoto commented Aug 27, 2022