Merge main into net7.0. #15993
Merge main into net7.0. #15993
Conversation
… results. (xamarin#15911) Don't try to publish test results unless there are any tests results. Fixes this [horribly/amusingly incorrect error][1] in the publish task: ##[error]Error: Failed find: ENOENT: no such file or directory, lstat '/System/Library/Frameworks/iTunesLibrary.framework/Versions/Versions' ##[section]Finishing: Publish NUnit Device Test Results Also stop failing the task on failing tests, because we already have another task that fail if there are failing tests (the task that runs the tests). [1]: microsoft/azure-pipelines-tasks#16786
…arin#15938) Otherwise this happens if the directory is empty: + test -d /Users/runner/Library/Logs/DiagnosticReports + zip -9rj /Users/runner/work/1/s/crash-reports.zip /Users/runner/Library/Logs/DiagnosticReports zip error: Nothing to do! (try: zip -9rj /Users/runner/work/1/s/crash-reports.zip . -i /Users/runner/Library/Logs/DiagnosticReports)
It seems this file hasn't been used since b1ea4b5.
…5947) The 'Expand tests.' step sometimes fails with: > ##[error]Bash exited with code '1'. Which is very unhelpful. Make bash more verbose to see if we can figure out what's going wrong.
Adds missing css files needed on Maui Blazor apps and avoids copying unnecessary files into the bundle (overdue task since the .NET migration). Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com>
This was used in the old Xamarin days.
Because we use mtouch and mmp to build the partial static registrar code for .NET. Eventually we'll look into generating the partial static registrar some other way, but that's for another time.
…json. (xamarin#15973) Also move bash code from yml to a .sh file for easier reading, writing and debugging.
) Just do `make show-versions`: $ make show-versions Building: The legacy package(s): Xamarin.iOS 15.13.0.132 Xamarin.Mac 8.13.0.132 The .NET NuGet(s): Microsoft.iOS 15.4.436-ci.show-versions+sha.405ff7c275 Microsoft.tvOS 15.4.436-ci.show-versions+sha.405ff7c275 Microsoft.MacCatalyst 15.4.436-ci.show-versions+sha.405ff7c275 Microsoft.macOS 12.3.436-ci.show-versions+sha.405ff7c275
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This pull request updates the following dependencies ## Coherency Updates The following updates ensure that dependencies with a *CoherentParentDependency* attribute were produced in a build used as input to the parent dependency's build. See [Dependency Description Format](https://github.com/dotnet/arcade/blob/master/Documentation/DependencyDescriptionFormat.md#dependency-description-overview) - **Coherency Updates**: - **Microsoft.AspNetCore.App.Ref**: from 6.0.5 to 6.0.9 (parent: Microsoft.Dotnet.Sdk.Internal) ## From https://github.com/dotnet/installer - **Subscription**: be6e1947-9e64-4217-c50e-08da52a3899f - **Build**: 20220915.1 - **Date Produced**: September 15, 2022 7:51:35 AM UTC - **Commit**: 1c38151cabb5771a1503aff6e5cecb435be4c69c - **Branch**: refs/heads/release/6.0.4xx - **Updates**: - **Microsoft.Dotnet.Sdk.Internal**: [from 6.0.301-rtm.22280.1 to 6.0.402-servicing.22465.1][147] - **Microsoft.AspNetCore.App.Ref**: [from 6.0.5 to 6.0.9][148] [147]: dotnet/installer@283e9cf...1c38151 [148]: https://dev.azure.com/dnceng/internal/_git/dotnet-aspnetcore/branches?baseVersion=GCe5f183b&targetVersion=GC3fe12b9&_a=files Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com> Co-authored-by: GitHub Actions <github-actions@xamarin.com>
) Implement a GitHub action to automatically format our source code. This is implemented in two steps: 1. A restricted action is used to check if the code has any formatting issues, and if so, creates a patch to fix the code. 2. Another action is used to commit and push the patch (and add a comment to the PR notifying the submitter about the problems found). This is because the first action will call 'dotnet format', which might be insecure in that it can execute code from the repository. This is not safe in a context that is allowed to push commits (because there are secrets in the environment) - so anyone could create a PR that would be executed as a part of 'dotnet format' and then look for our secrets and make them public. The restricted action's environment does not have any secrets, and it's thus safe to execute random code. The second action will only execute if the corresponding file is in main, so this PR need to be merged before this can be fully implemented, and as such I've made the autoformatting opt-in (by adding the `actions-enable-autoformat` label). Once everything is confirmed to work properly, it will become opt-out instead. Also, for now only a very simple project is autoformatted (xibuild.csproj), but the idea is to fix source code incrementally, and add to the list of projects/code we autoformat.
…led. (xamarin#15997) We use mono in a number of places.
…marin#15986) 'bool' isn't a blittable type, so it can't be used in an [UnmanagedCallersOnly] method. FWIW it's a bug in the C# compiler to not complain about this: dotnet/roslyn#64086. Fixes this crash in the AOT compiler: > * Assertion at /Users/runner/work/1/s/src/mono/mono/mini/aot-compiler.c:5142, condition `is_ok (error)' not met, function:add_wrappers, method CoreMedia.CMBufferQueue:GetDataReady (intptr,intptr) with UnmanagedCallersOnlyAttribute has non-blittable parameters or return type assembly:<unknown assembly> type:<unknown type> member:(null) Also exclude some unused delegates from .NET code.
rolfbjarne
requested review from
mandel-macaque and
dalexsoto
as code owners
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Test failures are unrelated (#15986). |
💻 [PR Build] Tests on macOS Mac Catalina (10.15) passed 💻✅ All tests on macOS Mac Catalina (10.15) passed. Pipeline on Agent |
💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻✅ All tests on macOS M1 - Mac Big Sur (11.5) passed. Pipeline on Agent |
✅ API diff for current PR / commitLegacy Xamarin (No breaking changes).NET (No breaking changes)✅ API diff vs stableLegacy Xamarin (No breaking changes).NET (No breaking changes)ℹ️ Generator diffGenerator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes) Pipeline on Agent |
🔥 [CI Build] Test results 🔥Test results❌ Tests failed on VSTS: simulator tests 2 tests crashed, 0 tests failed, 219 tests passed. Failures❌ generator tests🔥 Failed catastrophically on VSTS: simulator tests - generator (no summary found). Html Report (VSDrops) Download ❌ msbuild tests🔥 Failed catastrophically on VSTS: simulator tests - msbuild (no summary found). Html Report (VSDrops) Download Successes✅ bcl: All 69 tests passed. Html Report (VSDrops) Download Pipeline on Agent |
🚀 [CI Build] Test results 🚀Test results✅ All tests passed on VSTS: simulator tests. 🎉 All 223 tests passed 🎉 Tests counts✅ bcl: All 69 tests passed. Html Report (VSDrops) Download Pipeline on Agent |
No description provided.