Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[foundation] Fix POST/PUT issues with NSUrlSessionHandler. Fixes #52682 (#1772) #1778

Merged
merged 1 commit into from
Feb 28, 2017

Conversation

spouliot
Copy link
Contributor

The latest NSUrlSessionHandler implementation switched from loading the
request into memory (NSData) to loading it from a stream (NSInputStream).
The later is more efficient, at least for large POST'ed requests which
could, in theory, not even fit in memory.

Now using a stream means a different API is used. NSMutableUrlRequest
Body and BodyStream properties are exclusive but also a bit different as
the later won't set Content-Length [1] and switch to chunked encoding [2]

Even if the current code is compliant with HTTP/1.1 this breaks some
common POST/PUT usage that worked "as expected" in the previous (C8)
release.

To fix this we ask for the stream's length. We assume that if the length
is known then it's (likely) already (or fitting) in memory and use the
(old, in memory) Body property, which will set Content-Length.

If the length is unknown then we use the BodyStream approach so large
POST will continue to work (well over past/C8 limits).

Finally there might be case where developers will prefer to avoid the
extra memory (of Body) so a new property MaxInputInMemory is added
to set a maximum. It defaults to Int64.MaxValue so Body will be
used whenever possible. It can be set to 0 to get back the original C9
(always use a stream) behavior.

references:
[1] https://bugzilla.xamarin.com/show_bug.cgi?id=52682
[2] https://bugzilla.xamarin.com/show_bug.cgi?id=52711
[3] https://devforums.apple.com/message/919330#919330

…82 (xamarin#1772)

The latest NSUrlSessionHandler implementation switched from loading the
request into memory (NSData) to loading it from a stream (NSInputStream).
The later is more efficient, at least for large POST'ed requests which
could, in theory, not even fit in memory.

Now using a stream means a different API is used. NSMutableUrlRequest
Body and BodyStream properties are exclusive but also a bit different as
the later won't set Content-Length [1] and switch to chunked encoding [2]

Even if the current code is compliant with HTTP/1.1 this breaks some
common POST/PUT usage that worked "as expected" in the previous (C8)
release.

To fix this we ask for the stream's length. We assume that if the length
is known then it's (likely) already (or fitting) in memory and use the
(old, in memory) Body property, which will set Content-Length.

If the length is unknown then we use the BodyStream approach so large
POST will continue to work (well over past/C8 limits).

Finally there might be case where developers will prefer to avoid the
extra memory (of `Body`) so a new property `MaxInputInMemory` is added
to set a maximum. It defaults to `Int64.MaxValue` so `Body` will be
used whenever possible. It can be set to `0` to get back the original C9
(always use a stream) behavior.

references:
[1] https://bugzilla.xamarin.com/show_bug.cgi?id=52682
[2] https://bugzilla.xamarin.com/show_bug.cgi?id=52711
[3] https://devforums.apple.com/message/919330#919330
@spouliot spouliot added this to the d15-1 milestone Feb 27, 2017
@monojenkins
Copy link
Collaborator

Build success

@spouliot spouliot merged commit 76e2b74 into xamarin:d15-1 Feb 28, 2017
@spouliot spouliot deleted the bug52682-d15-1 branch February 28, 2017 13:10
spouliot added a commit to spouliot/xamarin-macios that referenced this pull request Feb 28, 2017
…82 (xamarin#1772) (xamarin#1778)

The latest NSUrlSessionHandler implementation switched from loading the
request into memory (NSData) to loading it from a stream (NSInputStream).
The later is more efficient, at least for large POST'ed requests which
could, in theory, not even fit in memory.

Now using a stream means a different API is used. NSMutableUrlRequest
Body and BodyStream properties are exclusive but also a bit different as
the later won't set Content-Length [1] and switch to chunked encoding [2]

Even if the current code is compliant with HTTP/1.1 this breaks some
common POST/PUT usage that worked "as expected" in the previous (C8)
release.

To fix this we ask for the stream's length. We assume that if the length
is known then it's (likely) already (or fitting) in memory and use the
(old, in memory) Body property, which will set Content-Length.

If the length is unknown then we use the BodyStream approach so large
POST will continue to work (well over past/C8 limits).

Finally there might be case where developers will prefer to avoid the
extra memory (of `Body`) so a new property `MaxInputInMemory` is added
to set a maximum. It defaults to `Int64.MaxValue` so `Body` will be
used whenever possible. It can be set to `0` to get back the original C9
(always use a stream) behavior.

references:
[1] https://bugzilla.xamarin.com/show_bug.cgi?id=52682
[2] https://bugzilla.xamarin.com/show_bug.cgi?id=52711
[3] https://devforums.apple.com/message/919330#919330
spouliot added a commit that referenced this pull request Mar 7, 2017
…82 (#1772) (#1778) (#1790)

The latest NSUrlSessionHandler implementation switched from loading the
request into memory (NSData) to loading it from a stream (NSInputStream).
The later is more efficient, at least for large POST'ed requests which
could, in theory, not even fit in memory.

Now using a stream means a different API is used. NSMutableUrlRequest
Body and BodyStream properties are exclusive but also a bit different as
the later won't set Content-Length [1] and switch to chunked encoding [2]

Even if the current code is compliant with HTTP/1.1 this breaks some
common POST/PUT usage that worked "as expected" in the previous (C8)
release.

To fix this we ask for the stream's length. We assume that if the length
is known then it's (likely) already (or fitting) in memory and use the
(old, in memory) Body property, which will set Content-Length.

If the length is unknown then we use the BodyStream approach so large
POST will continue to work (well over past/C8 limits).

Finally there might be case where developers will prefer to avoid the
extra memory (of `Body`) so a new property `MaxInputInMemory` is added
to set a maximum. It defaults to `Int64.MaxValue` so `Body` will be
used whenever possible. It can be set to `0` to get back the original C9
(always use a stream) behavior.

references:
[1] https://bugzilla.xamarin.com/show_bug.cgi?id=52682
[2] https://bugzilla.xamarin.com/show_bug.cgi?id=52711
[3] https://devforums.apple.com/message/919330#919330
spouliot added a commit to spouliot/xamarin-macios that referenced this pull request Mar 27, 2017
…82 (xamarin#1772) (xamarin#1778) (xamarin#1790)

The latest NSUrlSessionHandler implementation switched from loading the
request into memory (NSData) to loading it from a stream (NSInputStream).
The later is more efficient, at least for large POST'ed requests which
could, in theory, not even fit in memory.

Now using a stream means a different API is used. NSMutableUrlRequest
Body and BodyStream properties are exclusive but also a bit different as
the later won't set Content-Length [1] and switch to chunked encoding [2]

Even if the current code is compliant with HTTP/1.1 this breaks some
common POST/PUT usage that worked "as expected" in the previous (C8)
release.

To fix this we ask for the stream's length. We assume that if the length
is known then it's (likely) already (or fitting) in memory and use the
(old, in memory) Body property, which will set Content-Length.

If the length is unknown then we use the BodyStream approach so large
POST will continue to work (well over past/C8 limits).

Finally there might be case where developers will prefer to avoid the
extra memory (of `Body`) so a new property `MaxInputInMemory` is added
to set a maximum. It defaults to `Int64.MaxValue` so `Body` will be
used whenever possible. It can be set to `0` to get back the original C9
(always use a stream) behavior.

references:
[1] https://bugzilla.xamarin.com/show_bug.cgi?id=52682
[2] https://bugzilla.xamarin.com/show_bug.cgi?id=52711
[3] https://devforums.apple.com/message/919330#919330
VincentDondain added a commit to VincentDondain/xamarin-macios that referenced this pull request Aug 13, 2019
Hopefully fixes xamarin/maccore#1912

New commits in xamarin/macios-binaries:

* xamarin/macios-binaries@37a7bf9 Bump mlaunch to xamarin/maccore@46d5f822fe (xamarin#23)

Diff: https://github.com/xamarin/macios-binaries/compare/c4773043c5aa941bddaedf6c0fe5ae56db84342a..37a7bf9ac7208aed810257ccc06d09e4aaa94471

New commits in xamarin/maccore:

* xamarin/maccore@46d5f822fe [sample tests] Switch to devdiv AzDO instance instead of the xamarin one. (xamarin#1851)
* xamarin/maccore@b3b8e8bfee [Xamarin.Hosting] Remove an unavailable SimDevice.RegisterNotificationHandler overload. (xamarin#1724)
* xamarin/maccore@63bf859723 [mlaunch] Connect to devices on a background thread. (xamarin#1778)

Diff: https://github.com/xamarin/maccore/compare/f26319899f55394e61ef17ee0e399e38fc65ea63..46d5f822fec0dec2513d64a9390033bdead3fe45
VincentDondain added a commit that referenced this pull request Aug 13, 2019
Hopefully fixes xamarin/maccore#1912

New commits in xamarin/macios-binaries:

* xamarin/macios-binaries@37a7bf9 Bump mlaunch to xamarin/maccore@46d5f822fe (#23)

Diff: https://github.com/xamarin/macios-binaries/compare/c4773043c5aa941bddaedf6c0fe5ae56db84342a..37a7bf9ac7208aed810257ccc06d09e4aaa94471

New commits in xamarin/maccore:

* xamarin/maccore@46d5f822fe [sample tests] Switch to devdiv AzDO instance instead of the xamarin one. (#1851)
* xamarin/maccore@b3b8e8bfee [Xamarin.Hosting] Remove an unavailable SimDevice.RegisterNotificationHandler overload. (#1724)
* xamarin/maccore@63bf859723 [mlaunch] Connect to devices on a background thread. (#1778)

Diff: https://github.com/xamarin/maccore/compare/f26319899f55394e61ef17ee0e399e38fc65ea63..46d5f822fec0dec2513d64a9390033bdead3fe45
VincentDondain added a commit to VincentDondain/xamarin-macios that referenced this pull request Aug 21, 2019
This is in part so we get xamarin/maccore#1924 -> [mlaunch] Connect to devices on a background thread.
That should hopefully fix device not found issues we're having on some bots/

New commits in xamarin/macios-binaries:

* xamarin/macios-binaries@01d34af Bump mlaunch to xamarin/maccore@809b2def39 (xamarin#24)

Diff: https://github.com/xamarin/macios-binaries/compare/b474fa2e732974fde2edbfe054f23c5eefd0255b..01d34af6b03e81cefbb30d964e58fca66da86c4a

New commits in xamarin/maccore:

* xamarin/maccore@809b2def39 [mlaunch] Connect to devices on a background thread. (xamarin#1778) (xamarin#1924)
* xamarin/maccore@5215c09e8c Merge pull request xamarin#1923 from xamarin/swift-o-matic-hello-protocol-list-type
* xamarin/maccore@21447e2538 I. Can't. Believe. I'm. Checking. This. In.
* xamarin/maccore@da6518f920 Added ProtocolListTypeSpec
* xamarin/maccore@a9b9a0f5b3 Merge pull request xamarin#1920 from xamarin/swift-o-matic-bye-swift-protocol
* xamarin/maccore@01e9420598 Lose all the SwiftProtocol related types.
* xamarin/maccore@ca3bd0ab5b Merge pull request xamarin#1919 from xamarin/swift-redo-regular-protocols
* xamarin/maccore@f534abee12 Now with existential containers
* xamarin/maccore@9e180a823a Merge pull request xamarin#1911 from xamarin/swift-o-matic-string-convertible
* xamarin/maccore@9874985856 Typo
* xamarin/maccore@26731ff5cb Next step in Protocol revamp
* xamarin/maccore@9fe4cdd652 Merge pull request xamarin#1904 from xamarin/swift-o-matic-hashable
* xamarin/maccore@a1cd988dda iOS include
* xamarin/maccore@f1fc694da6 Revamped hashable.
* xamarin/maccore@16a6629a43 Merge pull request xamarin#1902 from xamarin/swift-o-matic-comparable
* xamarin/maccore@a98db5b976 Dead symbol, changed symbol.
* xamarin/maccore@3c38895694 Reworked Swift.Comparable to be defined in terms of EveryProtocol
* xamarin/maccore@ef1d3c1397 Merge pull request xamarin#1895 from xamarin/swift-o-matic-equatable
* xamarin/maccore@1c1a57fa4f Try again and get all the files, thanks.
* xamarin/maccore@ec0a5b99b7 Revised EveryProtocol, updated Equatable
* xamarin/maccore@198a489387 Simplified EveryProtocol, revised Equatable
* xamarin/maccore@ee7710a186 Merge pull request xamarin#1894 from xamarin/swift-o-matic-every-protocol
* xamarin/maccore@4fc0810fd2 Let's not leak memory, OK?
* xamarin/maccore@451c0ba18d Try a little dispose magic.
* xamarin/maccore@864854e407 Minor tweak to public API
* xamarin/maccore@052990af11 Adding in EveryProtocol object
* xamarin/maccore@b7f1347fcf Merge pull request xamarin#1893 from xamarin/swift-o-matic-protocol-binding
* xamarin/maccore@df4aefe447 no swap files, vi.
* xamarin/maccore@1e6bf8d4ef Merge pull request xamarin#1892 from xamarin/swift-o-matic-protocol-binding
* xamarin/maccore@e46a543544 Typo
* xamarin/maccore@fea9514c69 Let's document!
* xamarin/maccore@9b5ecdfdce Merge pull request xamarin#1890 from xamarin/swift-o-matic-fail-on-wrong-version
* xamarin/maccore@0b4afae5f3 Put in a hard fail on compiler version mismatch errors.
* xamarin/maccore@d1475a43d1 Merge pull request xamarin#1881 from xamarin/swift-o-matic-NRE
* xamarin/maccore@900e453695 Fixes and NRE from SCLAlertView
* xamarin/maccore@0164c0ae83 Merge pull request xamarin#1873 from xamarin/swift-o-matic-README
* xamarin/maccore@211b05a515 READMEs for errors, reminder to check README and associated issues in Makefile
* xamarin/maccore@74650bf3f8 [SoM] Add '/usr/lib/swift' as an rpath before any other rpaths. (xamarin#1857)
* xamarin/maccore@73dd23d00b Merge pull request xamarin#1859 from xamarin/swift-o-matic-SwiftLocation
* xamarin/maccore@6704604de1 Add SwiftLocation
* xamarin/maccore@e96ab505d8 Merge pull request xamarin#1855 from xamarin/swift-o-matic-bye-bye-dormant-3rd-party
* xamarin/maccore@c17c506738 Remove dormant 3rd Party Tests
* xamarin/maccore@366e201f11 Merge pull request xamarin#1854 from xamarin/swift-o-matic-update-3rd-party
* xamarin/maccore@da748a9a1d Updated makefiles for projects that have updated to Swift 4.2 or >
* xamarin/maccore@2e371bdaf2 Merge pull request xamarin#1849 from xamarin/swift-o-matic-gentler-errors
* xamarin/maccore@921c21251d Lighten up on errors, get paper-switch
* xamarin/maccore@f4fc280efe Merge pull request xamarin#1844 from xamarin/swift-o-matic-lottie
* xamarin/maccore@e47aa6b50c Adding lottie-ios
* xamarin/maccore@cf09fd4c59 [SoM] Copy swift libraries to foo.app/Frameworks for non-macOS apps. (xamarin#1842)
* xamarin/maccore@a4af9cdd2d Merge pull request xamarin#1841 from xamarin/swift-o-matic-gentler-skip
* xamarin/maccore@fc7cd38f64 [SoM] Handle the new BuildVersion load command. (xamarin#1827)
* xamarin/maccore@8666e81b7d Ha-ha! When you make errors become warnings, tests that depend on errors change.
* xamarin/maccore@e42a8c394f continue...
* xamarin/maccore@3b0d6bc0e6 [SoM] Don't duplicate the nuget version number. (xamarin#1838)
* xamarin/maccore@143afaf991 [msbuild] No need to use a shell function to resolve a relative path in make. (xamarin#1839)
* xamarin/maccore@cbe86e0152 [SoM] Add a helpful make target to create a nuget and setup a local feed repository for it. (xamarin#1837)
* xamarin/maccore@cfaaf1c5a5 [SoM] Enable swift's Stable ABI. (xamarin#1836)
* xamarin/maccore@79166d9755 Made errors more lenient, added Hue framework.
* xamarin/maccore@f4b0feeb55 Merge pull request xamarin#1830 from xamarin/swift-o-matic-prop-closure
* xamarin/maccore@a14198fdee whitespace
* xamarin/maccore@285874eceb handle ()->() and ()->type properly
* xamarin/maccore@4785afe4ea Handle closures as return values.
* xamarin/maccore@e89b80ca53 [SoM] Don't redownload the swift toolchain if we already have the file. (xamarin#1825)
* xamarin/maccore@217a608e72 [SoM] Improve installed scripts. (xamarin#1826)
* xamarin/maccore@ff283225b6 [SoM] Fix typo in type name. (xamarin#1824)
* xamarin/maccore@189ea0cba7 Merge pull request xamarin#1818 from xamarin/swift-o-matic-SwiftMessages-NRE
* xamarin/maccore@937541e0a6 restore back original code.
* xamarin/maccore@30be8a354a continue on null
* xamarin/maccore@dfceb83692 Merge pull request xamarin#1816 from xamarin/swift-o-matic-warn-not-fail
* xamarin/maccore@b32e33e71d Make warnings, not errors.
* xamarin/maccore@84504ced5e Merge pull request xamarin#1814 from xamarin/swift-o-matic-fix-predicate
* xamarin/maccore@82000e1a63 [submission] Fix makefile and clarify README (xamarin#1805)
* xamarin/maccore@d0ebe3b175 Remove stale predicate.
* xamarin/maccore@de6143449a Merge pull request xamarin#1806 from xamarin/swift-o-matic-c-structs
* xamarin/maccore@e10ef79504 C struct exceptions
* xamarin/maccore@a272402c7c Add the developerid required to run the notarization tests (xamarin#1804)
* xamarin/maccore@747c18c482 Merge pull request xamarin#1803 from xamarin/swift-o-matic-date-nuance
* xamarin/maccore@716082fd5e Moved string constants to SwiftFoundationConstants
* xamarin/maccore@f250ca5418 Merge pull request xamarin#1799 from xamarin/swift-o-matic-date
* xamarin/maccore@4d9a764e90 Basic support for Foundation.Date
* xamarin/maccore@5ef84bc50c Merge pull request xamarin#1795 from xamarin/swift-o-matic-ctor-finding
* xamarin/maccore@0899c35771 Demote error to warning.
* xamarin/maccore@ba80294413 Drop the mono-extensions dependency. (xamarin#1789)
* xamarin/maccore@ca616ef842 Merge pull request xamarin#1793 from xamarin/swift-o-matic-spring-fwk
* xamarin/maccore@f0cd48c28c Fix name conflict
* xamarin/maccore@beef68bf1e Merge pull request xamarin#1792 from xamarin/swift-o-matic-demangle-static
* xamarin/maccore@558b62da62 typo
* xamarin/maccore@5905981ad5 Added existential metatype
* xamarin/maccore@ed7d4b8b19 Merge pull request xamarin#1784 from xamarin/swift-o-matic-bound-generics
* xamarin/maccore@84f0bed939 Promote bound generics in closures to warnings, not errors.

Diff: https://github.com/xamarin/maccore/compare/348833cb21c75ce1e82b477f405c8ef4bed9812c..809b2def3933d59811c3761e55c64351be94f6d3
VincentDondain added a commit that referenced this pull request Aug 22, 2019
This is in part so we get xamarin/maccore#1924 -> [mlaunch] Connect to devices on a background thread.
That should hopefully fix device not found issues we're having on some bots/

New commits in xamarin/macios-binaries:

* xamarin/macios-binaries@01d34af Bump mlaunch to xamarin/maccore@809b2def39 (#24)

Diff: https://github.com/xamarin/macios-binaries/compare/b474fa2e732974fde2edbfe054f23c5eefd0255b..01d34af6b03e81cefbb30d964e58fca66da86c4a

New commits in xamarin/maccore:

* xamarin/maccore@809b2def39 [mlaunch] Connect to devices on a background thread. (#1778) (#1924)
* xamarin/maccore@5215c09e8c Merge pull request #1923 from xamarin/swift-o-matic-hello-protocol-list-type
* xamarin/maccore@21447e2538 I. Can't. Believe. I'm. Checking. This. In.
* xamarin/maccore@da6518f920 Added ProtocolListTypeSpec
* xamarin/maccore@a9b9a0f5b3 Merge pull request #1920 from xamarin/swift-o-matic-bye-swift-protocol
* xamarin/maccore@01e9420598 Lose all the SwiftProtocol related types.
* xamarin/maccore@ca3bd0ab5b Merge pull request #1919 from xamarin/swift-redo-regular-protocols
* xamarin/maccore@f534abee12 Now with existential containers
* xamarin/maccore@9e180a823a Merge pull request #1911 from xamarin/swift-o-matic-string-convertible
* xamarin/maccore@9874985856 Typo
* xamarin/maccore@26731ff5cb Next step in Protocol revamp
* xamarin/maccore@9fe4cdd652 Merge pull request #1904 from xamarin/swift-o-matic-hashable
* xamarin/maccore@a1cd988dda iOS include
* xamarin/maccore@f1fc694da6 Revamped hashable.
* xamarin/maccore@16a6629a43 Merge pull request #1902 from xamarin/swift-o-matic-comparable
* xamarin/maccore@a98db5b976 Dead symbol, changed symbol.
* xamarin/maccore@3c38895694 Reworked Swift.Comparable to be defined in terms of EveryProtocol
* xamarin/maccore@ef1d3c1397 Merge pull request #1895 from xamarin/swift-o-matic-equatable
* xamarin/maccore@1c1a57fa4f Try again and get all the files, thanks.
* xamarin/maccore@ec0a5b99b7 Revised EveryProtocol, updated Equatable
* xamarin/maccore@198a489387 Simplified EveryProtocol, revised Equatable
* xamarin/maccore@ee7710a186 Merge pull request #1894 from xamarin/swift-o-matic-every-protocol
* xamarin/maccore@4fc0810fd2 Let's not leak memory, OK?
* xamarin/maccore@451c0ba18d Try a little dispose magic.
* xamarin/maccore@864854e407 Minor tweak to public API
* xamarin/maccore@052990af11 Adding in EveryProtocol object
* xamarin/maccore@b7f1347fcf Merge pull request #1893 from xamarin/swift-o-matic-protocol-binding
* xamarin/maccore@df4aefe447 no swap files, vi.
* xamarin/maccore@1e6bf8d4ef Merge pull request #1892 from xamarin/swift-o-matic-protocol-binding
* xamarin/maccore@e46a543544 Typo
* xamarin/maccore@fea9514c69 Let's document!
* xamarin/maccore@9b5ecdfdce Merge pull request #1890 from xamarin/swift-o-matic-fail-on-wrong-version
* xamarin/maccore@0b4afae5f3 Put in a hard fail on compiler version mismatch errors.
* xamarin/maccore@d1475a43d1 Merge pull request #1881 from xamarin/swift-o-matic-NRE
* xamarin/maccore@900e453695 Fixes and NRE from SCLAlertView
* xamarin/maccore@0164c0ae83 Merge pull request #1873 from xamarin/swift-o-matic-README
* xamarin/maccore@211b05a515 READMEs for errors, reminder to check README and associated issues in Makefile
* xamarin/maccore@74650bf3f8 [SoM] Add '/usr/lib/swift' as an rpath before any other rpaths. (#1857)
* xamarin/maccore@73dd23d00b Merge pull request #1859 from xamarin/swift-o-matic-SwiftLocation
* xamarin/maccore@6704604de1 Add SwiftLocation
* xamarin/maccore@e96ab505d8 Merge pull request #1855 from xamarin/swift-o-matic-bye-bye-dormant-3rd-party
* xamarin/maccore@c17c506738 Remove dormant 3rd Party Tests
* xamarin/maccore@366e201f11 Merge pull request #1854 from xamarin/swift-o-matic-update-3rd-party
* xamarin/maccore@da748a9a1d Updated makefiles for projects that have updated to Swift 4.2 or >
* xamarin/maccore@2e371bdaf2 Merge pull request #1849 from xamarin/swift-o-matic-gentler-errors
* xamarin/maccore@921c21251d Lighten up on errors, get paper-switch
* xamarin/maccore@f4fc280efe Merge pull request #1844 from xamarin/swift-o-matic-lottie
* xamarin/maccore@e47aa6b50c Adding lottie-ios
* xamarin/maccore@cf09fd4c59 [SoM] Copy swift libraries to foo.app/Frameworks for non-macOS apps. (#1842)
* xamarin/maccore@a4af9cdd2d Merge pull request #1841 from xamarin/swift-o-matic-gentler-skip
* xamarin/maccore@fc7cd38f64 [SoM] Handle the new BuildVersion load command. (#1827)
* xamarin/maccore@8666e81b7d Ha-ha! When you make errors become warnings, tests that depend on errors change.
* xamarin/maccore@e42a8c394f continue...
* xamarin/maccore@3b0d6bc0e6 [SoM] Don't duplicate the nuget version number. (#1838)
* xamarin/maccore@143afaf991 [msbuild] No need to use a shell function to resolve a relative path in make. (#1839)
* xamarin/maccore@cbe86e0152 [SoM] Add a helpful make target to create a nuget and setup a local feed repository for it. (#1837)
* xamarin/maccore@cfaaf1c5a5 [SoM] Enable swift's Stable ABI. (#1836)
* xamarin/maccore@79166d9755 Made errors more lenient, added Hue framework.
* xamarin/maccore@f4b0feeb55 Merge pull request #1830 from xamarin/swift-o-matic-prop-closure
* xamarin/maccore@a14198fdee whitespace
* xamarin/maccore@285874eceb handle ()->() and ()->type properly
* xamarin/maccore@4785afe4ea Handle closures as return values.
* xamarin/maccore@e89b80ca53 [SoM] Don't redownload the swift toolchain if we already have the file. (#1825)
* xamarin/maccore@217a608e72 [SoM] Improve installed scripts. (#1826)
* xamarin/maccore@ff283225b6 [SoM] Fix typo in type name. (#1824)
* xamarin/maccore@189ea0cba7 Merge pull request #1818 from xamarin/swift-o-matic-SwiftMessages-NRE
* xamarin/maccore@937541e0a6 restore back original code.
* xamarin/maccore@30be8a354a continue on null
* xamarin/maccore@dfceb83692 Merge pull request #1816 from xamarin/swift-o-matic-warn-not-fail
* xamarin/maccore@b32e33e71d Make warnings, not errors.
* xamarin/maccore@84504ced5e Merge pull request #1814 from xamarin/swift-o-matic-fix-predicate
* xamarin/maccore@82000e1a63 [submission] Fix makefile and clarify README (#1805)
* xamarin/maccore@d0ebe3b175 Remove stale predicate.
* xamarin/maccore@de6143449a Merge pull request #1806 from xamarin/swift-o-matic-c-structs
* xamarin/maccore@e10ef79504 C struct exceptions
* xamarin/maccore@a272402c7c Add the developerid required to run the notarization tests (#1804)
* xamarin/maccore@747c18c482 Merge pull request #1803 from xamarin/swift-o-matic-date-nuance
* xamarin/maccore@716082fd5e Moved string constants to SwiftFoundationConstants
* xamarin/maccore@f250ca5418 Merge pull request #1799 from xamarin/swift-o-matic-date
* xamarin/maccore@4d9a764e90 Basic support for Foundation.Date
* xamarin/maccore@5ef84bc50c Merge pull request #1795 from xamarin/swift-o-matic-ctor-finding
* xamarin/maccore@0899c35771 Demote error to warning.
* xamarin/maccore@ba80294413 Drop the mono-extensions dependency. (#1789)
* xamarin/maccore@ca616ef842 Merge pull request #1793 from xamarin/swift-o-matic-spring-fwk
* xamarin/maccore@f0cd48c28c Fix name conflict
* xamarin/maccore@beef68bf1e Merge pull request #1792 from xamarin/swift-o-matic-demangle-static
* xamarin/maccore@558b62da62 typo
* xamarin/maccore@5905981ad5 Added existential metatype
* xamarin/maccore@ed7d4b8b19 Merge pull request #1784 from xamarin/swift-o-matic-bound-generics
* xamarin/maccore@84f0bed939 Promote bound generics in closures to warnings, not errors.

Diff: https://github.com/xamarin/maccore/compare/348833cb21c75ce1e82b477f405c8ef4bed9812c..809b2def3933d59811c3761e55c64351be94f6d3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants