[msbuild] Several updates to the ScnTool task. #19976

rolfbjarne · 2024-01-31T08:46:02Z

Enable nullability and fix the resulting issues.
Convert to XamarinTask (instead of XaxmarinToolTask): this allows us to run multiple
'scntool' invocations in parallel.
Use 'xcrun' to call 'scntool' instead of computing the path 1.
Fix bug in the Cancel method: it shouldn't call base.Execute.
Change the targets logic to match the pattern of other resource-related targets.
- This makes it easier to understand the code, since understanding one resource-related target works for the other ones too.
- Not using the CollectBundleResources task means computing LogicalName in the ScnTool task directly.

github-actions · 2024-01-31T08:49:43Z

⚠️ Your code has been reformatted. ⚠️

If this is not desired, add the actions-disable-autoformat label, and revert the reformatting commit.

If files unrelated to your change were modified, try reverting the reformatting commit + merging with the target branch (and push those changes).

* Enable nullability and fix the resulting issues. * Convert to XamarinTask (instead of XaxmarinToolTask): this allows us to run multiple 'scntool' invocations in parallel. * Use 'xcrun' to call 'scntool' instead of computing the path.

rolfbjarne · 2024-02-01T15:14:30Z

/azp run

azure-pipelines · 2024-02-01T15:14:42Z

Azure Pipelines successfully started running 1 pipeline(s).

…tool

vs-mobiletools-engineering-service2 · 2024-02-07T11:59:45Z

📚 [PR Build] Artifacts 📚

Packages generated

View packages

Pipeline on Agent
Hash: [PR build]

vs-mobiletools-engineering-service2 · 2024-02-07T12:04:35Z

💻 [CI Build] Windows Integration Tests passed 💻

✅ All Windows Integration Tests passed.

Pipeline on Agent
Hash: eb0c335f6a6c2cf44229e9a45985b2c67afcb821 [PR build]

vs-mobiletools-engineering-service2 · 2024-02-07T12:08:08Z

💻 [PR Build] Tests on macOS X64 - Mac Sonoma (14) passed 💻

✅ All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent
Hash: [PR build]

vs-mobiletools-engineering-service2 · 2024-02-07T12:10:03Z

💻 [PR Build] Tests on macOS M1 - Mac Monterey (12) passed 💻

✅ All tests on macOS M1 - Mac Monterey (12) passed.

Pipeline on Agent
Hash: [PR build]

vs-mobiletools-engineering-service2 · 2024-02-07T12:10:49Z

💻 [PR Build] Tests on macOS M1 - Mac Ventura (13) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13) passed.

Pipeline on Agent
Hash: [PR build]

vs-mobiletools-engineering-service2 · 2024-02-07T12:11:47Z

💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11) passed 💻

✅ All tests on macOS M1 - Mac Big Sur (11) passed.

Pipeline on Agent
Hash: [PR build]

vs-mobiletools-engineering-service2 · 2024-02-07T12:30:47Z

✅ API diff for current PR / commit

Legacy Xamarin (No breaking changes)

~~iOS~~ (no change detected)
~~tvOS~~ (no change detected)
~~watchOS~~ (no change detected)
~~macOS~~ (no change detected)

NET (empty diffs)

~~iOS~~: (empty diff detected)
~~tvOS~~: (empty diff detected)
~~MacCatalyst~~: (empty diff detected)
~~macOS~~: (empty diff detected)

✅ API diff vs stable

Legacy Xamarin (No breaking changes)

iOS: vsdrops gist (No breaking changes)
tvOS: vsdrops gist (No breaking changes)
watchOS: vsdrops gist (No breaking changes)
macOS: vsdrops gist (No breaking changes)

.NET (No breaking changes)

iOS: vsdrops gist (No breaking changes)
tvOS: vsdrops gist (No breaking changes)
MacCatalyst: vsdrops gist (No breaking changes)
macOS: vsdrops gist (No breaking changes)
Microsoft.iOS vs Microsoft.MacCatalyst: vsdrops gist

Legacy Xamarin (stable) vs .NET

iOS: vsdrops gist
tvOS: vsdrops gist
macOS: vsdrops gist

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: eb0c335f6a6c2cf44229e9a45985b2c67afcb821 [PR build]

vs-mobiletools-engineering-service2 · 2024-02-07T15:36:59Z

🚀 [CI Build] Test results 🚀

Test results

✅ All tests passed on VSTS: simulator tests.

🎉 All 170 tests passed 🎉