Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Migrate Messaging Build agent to .NET 8 (#20705)" #20790

Merged
merged 2 commits into from
Jul 1, 2024
Merged

Revert "Migrate Messaging Build agent to .NET 8 (#20705)" #20790

merged 2 commits into from
Jul 1, 2024

Conversation

rolfbjarne
Copy link
Member

This reverts commit f8552e9.

This change is only supposed to be released with .NET 9, and we might
release new .NET 8 updates from main. Thus we need to make sure these
changes are only in the net9.0 branch (they already are).

@rolfbjarne
Revert "Migrate Messaging Build agent to .NET 8 (#20705)"
224870a 
This reverts commit f8552e9.

This change is only supposed to be released with .NET 9, and we might release
new .NET 8 updates from main. Thus we need to make sure these changes are only
in the net9.0 branch (they already are).
@rolfbjarne
Revert the list of files to sign as well.
25509d7
@rolfbjarne rolfbjarne requested review from emaf and mauroa as code owners June 28, 2024 10:39
@vs-mobiletools-engineering-service2
Copy link
Collaborator

📚 [CI Build] Artifacts 📚

Packages generated

View packages

Pipeline on Agent
Hash: [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build] Tests on macOS X64 - Mac Sonoma (14) passed 💻

✅ All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent
Hash: 25509d79171fd5cb4ecb7c6db54bbecd83b297ec [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build] Tests on macOS M1 - Mac Ventura (13) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13) passed.

Pipeline on Agent
Hash: 25509d79171fd5cb4ecb7c6db54bbecd83b297ec [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build] Tests on macOS M1 - Mac Big Sur (11) passed 💻

✅ All tests on macOS M1 - Mac Big Sur (11) passed.

Pipeline on Agent
Hash: 25509d79171fd5cb4ecb7c6db54bbecd83b297ec [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build] Tests on macOS M1 - Mac Monterey (12) passed 💻

✅ All tests on macOS M1 - Mac Monterey (12) passed.

Pipeline on Agent
Hash: 25509d79171fd5cb4ecb7c6db54bbecd83b297ec [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build] Windows Integration Tests passed 💻

✅ All Windows Integration Tests passed.

Pipeline on Agent
Hash: 25509d79171fd5cb4ecb7c6db54bbecd83b297ec [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ API diff for current PR / commit

Legacy Xamarin (No breaking changes)
  • iOS (no change detected)
  • tvOS (no change detected)
  • watchOS (no change detected)
  • macOS (no change detected)
NET (empty diffs)
  • iOS: (empty diff detected)
  • tvOS: (empty diff detected)
  • MacCatalyst: (empty diff detected)
  • macOS: (empty diff detected)

✅ API diff vs stable

Legacy Xamarin (No breaking changes)
.NET (No breaking changes)
Legacy Xamarin (stable) vs .NET

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 25509d79171fd5cb4ecb7c6db54bbecd83b297ec [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

🚀 [CI Build] Test results 🚀

Test results

✅ All tests passed on VSTS: test results.

🎉 All 168 tests passed 🎉

Tests counts

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 6 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 7 tests passed. Html Report (VSDrops) Download
✅ generator: All 2 tests passed. Html Report (VSDrops) Download
✅ install-source: All 1 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 7 tests passed. Html Report (VSDrops) Download
✅ introspection: All 8 tests passed. Html Report (VSDrops) Download
✅ linker: All 65 tests passed. Html Report (VSDrops) Download
✅ mac-binding-project: All 1 tests passed. Html Report (VSDrops) Download
✅ mmp: All 2 tests passed. Html Report (VSDrops) Download
✅ mononative: All 6 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 11 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 7 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 8 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 11 tests passed. Html Report (VSDrops) Download
✅ monotouch (watchOS): All 4 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ mtouch: All 1 tests passed. Html Report (VSDrops) Download
✅ xammac: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 8 tests passed. Html Report (VSDrops) Download
✅ xtro: All 2 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: 25509d79171fd5cb4ecb7c6db54bbecd83b297ec [PR build]

@emaf
Copy link
Contributor

emaf commented Jul 1, 2024

@dalexsoto @rolfbjarne How can we ensure this will be back on main once you won't release .NET 8 updates from main anymore? Also, from now own, should any Messaging changes be made directly into the .NET 9 branch?

@rolfbjarne
Copy link
Member Author

@dalexsoto @rolfbjarne How can we ensure this will be back on main once you won't release .NET 8 updates from main anymore?

We'll merge the net9.0 branch into main when .NET 9 goes public.

Also, from now own, should any Messaging changes be made directly into the .NET 9 branch?

Yes, any changes that depend on these changes should go into the net9.0 branch.

@rolfbjarne rolfbjarne merged commit b30dc91 into main Jul 1, 2024
28 checks passed
@rolfbjarne rolfbjarne deleted the dev/rolf/revert-20705 branch July 1, 2024 16:25
@rolfbjarne rolfbjarne mentioned this pull request Sep 18, 2024
Merged
dalexsoto added a commit that referenced this pull request Sep 27, 2024
@dalexsoto
[net9.0] Bring back missing change from #20790 to SignList
8583021 
This change is missing from the last revert 25509d7 that happened on #21264
dalexsoto added a commit that referenced this pull request Sep 27, 2024
@dalexsoto
[net9.0] Bring back missing change from #20790 to SignList (#21323)
60a7ae1 
This change is missing from the last revert
25509d7
that happened on #21264
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emaf emaf emaf approved these changes

@mauroa mauroa mauroa approved these changes

@mandel-macaque mandel-macaque mandel-macaque approved these changes

@dalexsoto dalexsoto dalexsoto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@rolfbjarne @vs-mobiletools-engineering-service2 @emaf @dalexsoto @mandel-macaque @mauroa