Xcode9 appkit #2245

chamons · 2017-06-23T15:03:56Z

No description provided.

chamons · 2017-06-23T15:04:36Z

src/appkit.cs

@@ -760,6 +760,30 @@ interface NSApplication : NSAccessibilityElementProtocol, NSAccessibility {
 		void EnumerateWindows (NSWindowListOptions options, NSApplicationEnumerateWindowsHandler block);
 	}

+	[Static]
+	interface NSAboutPanelOption


These are keys for a dictionary as really aren't easily Smart Enum'ed

not clear why ? can you expand on the difficulty ?

So the use of these is something like this:

NSDictionary options = NSDictionary.FromObjectsAndKeys(new NSObject [] {(NSString)"Name", (NSString)"Version", new NSAttributedString("Credits")}, new NSObject [] {NSAboutPanelOption.ApplicationName, NSAboutPanelOption.ApplicationVersion, NSAboutPanelOption.Credits}); NSApplication.SharedApplication.OrderFrontStandardAboutPanelWithOptions2 (options);

(Needs https://bugzilla.xamarin.com/show_bug.cgi?id=57718 to build)

So if we were going to improve it, I'd assume we do so by adding a OrderFrontStandardAboutPanelWithOptions that takes some strongly typed item and not a dictionary of smart enums.

spouliot · 2017-06-23T15:14:22Z

src/AppKit/Enums.cs

@@ -138,7 +138,11 @@ public enum NSComposite : nuint_compat_int {

 	[Native]
 	public enum NSBackingStore : nuint_compat_int {
-		Retained, Nonretained, Buffered
+		[Availability (Introduced = Platform.Mac_10_0, Deprecated = Platform.Mac_10_13, Message = "Use 'Buffered' instead")]


iirc from @VincentDondain PR this (and all others) needs to end with a dot (.)

spouliot · 2017-06-23T15:15:33Z

src/AppKit/Enums.cs

@@ -2112,6 +2122,7 @@ public static class NSFileTypeForHFSTypeCode {

 	// These constants specify the possible states of a drawer.
 	[Native]
+	[Deprecated (PlatformName.MacOSX, 10, 13, message: "Drawers are deprecated; consider using 'NSSplitViewController'")]


also it should not say deprecated since the IDE already knowns from the attribute

Yup exactly: https://github.com/xamarin/xamarin-macios/wiki/BINDINGS#rule-4

Here you can just say: Use 'NSSplitViewController' instead.

The IDE will show the user the following tooltip:

'NSDrawerState' was deprecated in macOS 10.13. Use 'NSSplitViewController' instead.

I copy pasted all of the spam from the various deprecation attributes and then went back and fixed things like 's and such, but missed ones like this who's text is completely wrong.

spouliot · 2017-06-23T15:16:42Z

src/AppKit/Enums.cs

+	{
+		FullRange,
+		Start,
+		End


minor: better end with a comma (,) so adding future values results in smaller diffs

Applies to all your enums

spouliot · 2017-06-23T15:20:14Z

src/AppKit/NSBezierPath.cs

@@ -110,5 +110,15 @@ public unsafe void AppendPathWithGlyphs (uint[] glyphs, NSFont font)
 				_AppendPathWithGlyphs ((IntPtr)ptr, glyphs.Length, font);
 		}

+		public unsafe void AppendBezierPathWithCGGlyphs (uint[] glyphs, NSFont font)


whats the difference with the previous method ? obviously they call a different API but I thought CGGlyphs were mapped to uint ? so it seems identical

maybe i'm wrong I see CGGlyph [] glyphs later.. so the signature looks wrong

I missed some deprecations from the diff.

The other one was calling

[Export ("appendBezierPathWithGlyphs:count:inFont:"), Internal]

which is deprecated

the new one is calling

[Export ("appendBezierPathWithCGGlyphs:count:inFont:")]

which is 10.13

There are "new" glyph APIs and Apple deprecated a whole mess of "old" ones. The diff was really ugly when I was parsing through it, and it appears I missed some.

Things were double confusing because we were not distinguishing between NSGlyph and CGGlyph correctly in "ancient" bindings.

spouliot · 2017-06-23T15:20:57Z

src/AppKit/NSBezierPath.cs

@@ -110,5 +110,15 @@ public unsafe void AppendPathWithGlyphs (uint[] glyphs, NSFont font)
 				_AppendPathWithGlyphs ((IntPtr)ptr, glyphs.Length, font);
 		}

+		public unsafe void AppendBezierPathWithCGGlyphs (uint[] glyphs, NSFont font)


Also it's a new public API so it must be decorated with Mac (10,13) and others if applicable since the internal version won't be visible to developers

spouliot · 2017-06-23T15:52:51Z

src/appkit.cs

+	interface NSObject_NSFontPanelValidationAdditions
+	{
+		[Export ("validModesForFontPanel:")]
+		NSFontPanelModeMask ValidModesForFontPanel (NSFontPanel fontPanel);


GetValidModes ?

spouliot · 2017-06-23T15:53:54Z

src/appkit.cs

+		IntPtr Constructor (NSSet<NSUserInterfaceCompressionOptions> options);
+
+		[Export ("containsOptions:")]
+		bool ContainsOptions (NSUserInterfaceCompressionOptions options);


not sure we need Options in the method name

spouliot · 2017-06-23T15:54:04Z

src/appkit.cs

+		bool ContainsOptions (NSUserInterfaceCompressionOptions options);
+
+		[Export ("intersectsOptions:")]
+		bool IntersectsOptions (NSUserInterfaceCompressionOptions options);


spouliot · 2017-06-23T15:54:12Z

src/appkit.cs

+		bool Empty { [Bind ("isEmpty")] get; }
+
+		[Export ("optionsByAddingOptions:")]
+		NSUserInterfaceCompressionOptions CreateOptionsByAdding (NSUserInterfaceCompressionOptions options);


Actually since we return NSUserInterfaceCompressionOptions this should be GetOptionsByAdding.

We kinda need ByAdding because there's a ByRemoving method.

However, maybe we could introduce an enum there and do something like:

NSUserInterfaceCompressionOptions GetOptions (NSUserInterfaceCompressionOptions options, NSUserInterfaceCompressionOptionsMode mode);

Where NSUserInterfaceCompressionOptions has 2 values: add and remove.

Maybe we'd need to add API doc for that (:

I ❤️ ByAdding / ByRemoving

spouliot · 2017-06-23T15:54:20Z

src/appkit.cs

+		NSUserInterfaceCompressionOptions CreateOptionsByAdding (NSUserInterfaceCompressionOptions options);
+
+		[Export ("optionsByRemovingOptions:")]
+		NSUserInterfaceCompressionOptions CreateOptionsByRemoving (NSUserInterfaceCompressionOptions options);


See comment above for ByAdding. Should be at least GetOptionsByRemoving.

monojenkins · 2017-06-23T16:19:51Z

Build success

timrisi · 2017-06-23T17:19:50Z

src/AppKit/Enums.cs

+		TraitTightLeading = 1 << 15,
+		[Mac (10,13)]
+		TraitLooseLeading = 1 << 16,
+


Extra whitespace

timrisi · 2017-06-23T17:20:42Z

src/AppKit/Enums.cs

@@ -2735,4 +2747,106 @@ public enum NSScrubberAlignment : nint
 		Center
 	}

+	[Mac (10,13)]
+	public enum NSFontError : int {
+


timrisi · 2017-06-23T17:21:08Z

src/AppKit/Enums.cs

+	[Mac (10,13)]
+	[Native]
+	public enum NSAccessibilityAnnotationPosition : nint
+	{


Formatting. { should be at the end of hte previous line (same is true for the rest of the new enums)

timrisi · 2017-06-23T17:21:49Z

src/AppKit/Enums.cs

+
+	[Mac (10,13)]
+	[Native]
+	public enum NSFontPanelModeMask : nuint


Looking at the values, should this have a [Flags] attribute?

VincentDondain · 2017-06-23T17:24:51Z

src/AppKit/Enums.cs

@@ -2148,6 +2159,7 @@ public enum NSRuleEditorNestingMode : nuint_compat_int {
 	}

 	[Native]
+	[Availability (Deprecated = Platform.Mac_10_11, Message = "Use 'NSGlyphProperty' instead")]


Same dot (.)

VincentDondain · 2017-06-23T17:27:51Z

src/appkit.cs

+
+		[Mac (10,13)]
+		[Export ("appendBezierPathWithCGGlyph:inFont:")]
+		void AppendBezierPathWithCGGlyph (CGGlyph glyph, NSFont font);


Just AppendBezierPath.

So the problem here is that we already have an AppendBezierPath variant that takes a uint, font and a bunch of older version that use WithFoo.

If I make this one different I think it will be confusing, and I can't convert them all without hitting the collision. :(

Added the simple overloads. I didn't bother converting them all to appends with an enum (https://github.com/xamarin/xamarin-macios/wiki/BINDINGS#different-objective-c-selectors-who-lead-to-identical-c-signatures) because they are both old bindings and I think that's uglier than what we already have.

if there's a better named API then let's not expose that name publicly

VincentDondain · 2017-06-23T17:28:09Z

src/appkit.cs

@@ -1819,6 +1858,7 @@ interface NSBrowserDelegate {
 		[Export ("browser:writeRowsWithIndexes:inColumn:toPasteboard:")]
 		bool WriteRowsWithIndexesToPasteboard (NSBrowser browser, NSIndexSet rowIndexes, nint column, NSPasteboard pasteboard);

+		[Deprecated (PlatformName.MacOSX, 10, 13, message: "Use 'NSFilePromiseReceiver' objects instead")]


Same dot (.)

VincentDondain · 2017-06-23T17:28:30Z

src/appkit.cs

@@ -2902,6 +2950,7 @@ partial interface NSCollectionViewDelegate {
 		[Export ("collectionView:writeItemsAtIndexes:toPasteboard:")]
 		bool WriteItems (NSCollectionView collectionView, NSIndexSet indexes, NSPasteboard toPasteboard);

+		[Deprecated (PlatformName.MacOSX, 10, 13, message: "Use 'NSFilePromiseReceiver' objects instead")]


Same dot (.)

VincentDondain · 2017-06-23T17:28:39Z

src/appkit.cs

@@ -2927,6 +2976,7 @@ partial interface NSCollectionViewDelegate {
 		bool WriteItems (NSCollectionView collectionView, NSSet indexPaths, NSPasteboard pasteboard);

 		[Mac (10,11)]
+		[Deprecated (PlatformName.MacOSX, 10, 13, message: "Use 'NSFilePromiseReceiver' objects instead")]


Same dot (.)

timrisi · 2017-06-23T17:25:03Z

src/appkit.cs

@@ -760,6 +760,30 @@ interface NSApplication : NSAccessibilityElementProtocol, NSAccessibility {
 		void EnumerateWindows (NSWindowListOptions options, NSApplicationEnumerateWindowsHandler block);
 	}

+	[Static]
+	interface NSAboutPanelOption
+	{


{ should be at the end of the previous line

timrisi · 2017-06-23T17:25:22Z

src/appkit.cs

+		[Export ("appendBezierPathWithCGGlyphs:count:inFont:")]
+		[Internal]
+		void _AppendBezierPathWithCGGlyphs (IntPtr glyphs, nint count, NSFont font);
+


timrisi · 2017-06-23T17:27:37Z

src/appkit.cs

@@ -3390,6 +3440,7 @@ interface NSCollectionViewGridLayout
 	}

 	[Mac (10,11)]
+	[DisableDefaultCtor]


Isn't this a breaking change to add to an existing API?

Yes. :(

I'll have to XAMCORE_4_0 and add test exclusions. Not sure why I made this mistake in the haze of test fixing.

Looks like this never got fixed

https://github.com/xamarin/xamarin-macios/pull/2245/files#diff-2da82f43f8c6da1d44cce9f2d17f5117R13

VincentDondain · 2017-06-23T17:30:34Z

src/appkit.cs

@@ -5876,6 +6016,7 @@ partial interface NSFont : NSSecureCoding, NSCopying {
 		NSStringEncoding MostCompatibleStringEncoding { get; }

 		[Export ("glyphWithName:")]
+		[Deprecated (PlatformName.MacOSX, 10, 13, message: "Use CGGlyph APIs instead")]


Please put CGGlyph between apostrophes. 'CGGlyph'.

And make it "Use the 'CGGlyph' APIs instead."

monojenkins · 2017-07-11T20:36:51Z

Build failure

chamons · 2017-07-11T21:24:19Z

I'm testing my changes and will get back to the PR shortly.

chamons · 2017-07-12T20:21:29Z

@timrisi @spouliot I believe all concerns are handled now.

monojenkins · 2017-07-12T21:39:37Z

Build failure

monojenkins · 2017-07-12T23:23:13Z

Build failure

chamons · 2017-07-13T14:44:49Z

Test failure unrelated - https://bugzilla.xamarin.com/show_bug.cgi?id=57762

spouliot · 2017-07-13T19:49:08Z

src/AppKit/Compat.cs

+
+		[EditorBrowsable (EditorBrowsableState.Advanced)]
+		[Export ("init")]
+		public NSCollectionViewTransitionLayout () : base (NSObjectFlag.Empty)


what's the reason for excluding this from XAMCORE_4_0 ?
This should be inside an [Obsolete] attribute so developers can stop using it
Also if it does not work (e.g. crash) then there's no need to include the generated code body.

I tried to follow your suggestion here: #2245 (comment)

You are correct that I forgot the obsolete. Adding.

Sorry but it remains unclear why you're removing it from bindings. The two main reasons are:

It was our mistake and it does not work (the normal case for [Obsolete]). There's no point to have the generated code inside the body, it will make it harder to diagnose if called;

It was Apple mistake and they removed it. Here it should be [Obsoleted] or [Deprecated] (and can be kept part of the bindings).

spouliot · 2017-07-13T19:50:42Z

src/AppKit/Enums.cs

+	public enum NSFontError : int {
+		AssetDownloadError = 66304,  // Generic code when font asset download error occurs.
+		ErrorMinimum = 66304,  // Generic code when font asset download error occurs.
+		ErrorMaximum = 66335,  // Generic code when font asset download error occurs.


comments not really useful in the bindings (and not quite right for min and max)

spouliot · 2017-07-13T19:53:12Z

src/AppKit/NSFont.cs

+			CGRect [] bounds = new CGRect [glyphs.Length]; 
+			fixed (CGRect* boundsPtr = &bounds [0]) {
+				fixed (CGGlyph* glyphsPtr = &glyphs [0]) {
+					_GetBoundingRects ((IntPtr)boundsPtr, (IntPtr)glyphsPtr, (nuint)glyphs.Length);


I meant what happens with the native API, not our managed one :-)

spouliot · 2017-07-13T19:55:51Z

src/AppKit/NSFont.cs

+			CGSize [] advancements = new CGSize [glyphs.Length]; 
+			fixed (CGSize* advancementsPtr = &advancements [0]) {
+				fixed (CGGlyph* glyphsPtr = &glyphs [0]) {
+					_GetAdvancements ((IntPtr)advancementsPtr, (IntPtr)glyphsPtr, (nuint)glyphs.Length);


same - meant the native API, not the managed one.
e.g. is it valid/useful to ask advancement for no glyphs ?

spouliot · 2017-07-13T20:08:20Z

src/appkit.cs

@@ -2026,7 +2071,7 @@ interface NSButtonCell {
 	}

 	[BaseType (typeof (NSControl))]
-	interface NSButton : NSAccessibilityButton {
+	interface NSButton : NSAccessibilityButton, NSUserInterfaceCompression {


@timrisi no, this means that the native type must support it so we can generate the methods that calls it

spouliot · 2017-07-13T20:15:55Z

src/appkit.cs

@@ -4689,22 +4810,28 @@ interface NSCursor : NSCoding {
 		[Export ("set")]
 		void Set ();

+		[Deprecated (PlatformName.MacOSX, 10, 13, message: "'SetOnMouseExited' is unused and should not be called.")]


The message is unclear.
First I don't think it should include the API name (it's obvious in the IDE) <- @VincentDondain that could be a check in the intro tests
Next is it really unused if user code calls it ? ;-)

Maybe "This call will be ignored by the operating system." ? unless I misunderstood the issue :)

same applies to similar messages just below

The message was translated from the header:

- (void)setOnMouseEntered:(BOOL)flag NS_DEPRECATED_MAC(10_0, 10_13, "setOnMouseEntered is unused and should not be called"); @property (getter=isSetOnMouseExited, readonly) BOOL setOnMouseExited NS_DEPRECATED_MAC(10_0, 10_13, "isSetOnMouseExited is unused"); @property (getter=isSetOnMouseEntered, readonly) BOOL setOnMouseEntered NS_DEPRECATED_MAC(10_0, 10_13, "isSetOnMouseEntered is unused"); - (void)mouseEntered:(NSEvent *)event NS_DEPRECATED_MAC(10_0, 10_13, "mouseEntered: is unused and should not be called"); - (void)mouseExited:(NSEvent *)event NS_DEPRECATED_MAC(10_0, 10_13, "mouseExited: is unused and should not be called");

spouliot · 2017-07-13T20:18:05Z

src/appkit.cs

+		[Mac (10,13)]
+		[Internal]
+		[Export ("getBoundingRects:forCGGlyphs:count:")]
+		unsafe void _GetBoundingRects (IntPtr bounds, IntPtr glyphs, nuint glyphCount);


minor: there's nothing unsafe in the signature

spouliot · 2017-07-13T20:18:17Z

src/appkit.cs

+		[Mac (10,13)]
+		[Internal]
+		[Export ("getAdvancements:forCGGlyphs:count:")]
+		unsafe void _GetAdvancements (IntPtr advancements, IntPtr glyphs, nuint glyphCount);


minor: there's nothing unsafe in the signature

spouliot · 2017-07-13T20:20:04Z

src/appkit.cs

@@ -10234,7 +10450,7 @@ partial interface NSLayoutManager : NSCoding {
 		[Export ("intAttribute:forGlyphAtIndex:")]
 		nint IntAttributeforGlyphAtIndex (nint attributeTag, nint glyphIndex);

-		// TODO: bind this with a safe version
+		[Deprecated (PlatformName.MacOSX, 10, 13)]


it's [Internal], has the caller(s) been decorated too ?
if there's none then it can simply be removed

chamons · 2017-07-13T21:15:21Z

Half of @spouliot comments are taken care of. Testing the open native API question now.

monojenkins · 2017-07-13T22:36:05Z

Build failure

chamons · 2017-07-14T16:11:01Z

Failure known - https://bugzilla.xamarin.com/show_bug.cgi?id=55719

monojenkins · 2017-07-14T20:38:17Z

Build success

…o xcode9-appkit

monojenkins · 2017-07-18T21:22:30Z

Build success

Commits: i * [mlaunch] Don't throw if the DVTAnalyticsKit is missing. (xamarin#2243) xamarin/maccore@5529194 * [mlaunch] Improve makefile to detect when the built app changes and re-install properly. xamarin/maccore@cd37e4d * [mlaunch] Use SimDevice.LaunchApplicationAsync to launch applications like Xcode does. xamarin/maccore@1ad15ed * [mlaunch] Launch watch apps directly in the watch simulator for watch iOS 7+. xamarin/maccore@e57ca5b * [mlaunch] Fix makefile to work properly. (xamarin#2247) xamarin/maccore@af172cd * [mlaunch] Automatically set NSUnbufferedIO in more cases to get text to stdout/stderr without delay. (xamarin#2246) xamarin/maccore@2d025ab * [mlaunch] Disable any dock icons. (xamarin#2245) xamarin/maccore@e6eed65 Complete diff: xamarin/maccore@d425378...e6eed65]

Commits: i * [mlaunch] Don't throw if the DVTAnalyticsKit is missing. (#2243) xamarin/maccore@5529194 * [mlaunch] Improve makefile to detect when the built app changes and re-install properly. xamarin/maccore@cd37e4d * [mlaunch] Use SimDevice.LaunchApplicationAsync to launch applications like Xcode does. xamarin/maccore@1ad15ed * [mlaunch] Launch watch apps directly in the watch simulator for watch iOS 7+. xamarin/maccore@e57ca5b * [mlaunch] Fix makefile to work properly. (#2247) xamarin/maccore@af172cd * [mlaunch] Automatically set NSUnbufferedIO in more cases to get text to stdout/stderr without delay. (#2246) xamarin/maccore@2d025ab * [mlaunch] Disable any dock icons. (#2245) xamarin/maccore@e6eed65 Complete diff: xamarin/maccore@d425378...e6eed65]

chamons added 18 commits June 14, 2017 12:49

10.13 Appkit Accessibility

aabd1d6

More work

d263bb8

In work bits

05cd4d8

More appkit work

7b1da93

More appkit work

b7faed6

More work

330c858

More appkit

cf9327e

Add missing attributes

59100e6

Test fixes

fc347f4

[macos] Introspection test fixes for 10.13

1b48c5b

Code review fixes:

3055874

32-bit fixes

25a0f18

Fix classic tests as well

60b3ee1

Fixup some quotes

1b2eab1

Test fixes

e28964e

Cleanup

74eae06

More cleanup

d29d965

Actually expose the NSTextList ctor

dcd854c

dnfclas added the cla-already-signed label Jun 23, 2017

chamons commented Jun 23, 2017

View reviewed changes

spouliot suggested changes Jun 23, 2017

View reviewed changes

timrisi suggested changes Jun 23, 2017

View reviewed changes

VincentDondain reviewed Jun 23, 2017

View reviewed changes

timrisi suggested changes Jun 23, 2017

View reviewed changes

VincentDondain reviewed Jun 23, 2017

View reviewed changes

chamons added 2 commits July 11, 2017 12:28

More PR changes

45b810e

Add missing file

ee76309

chamons added 4 commits July 12, 2017 09:37

Merge branch 'xcode9' into xcode9-appkit

abe5f7a

Fix introspection test failures

79ef5be

Mac API test should not be to literal on description syntax

6623b5e

Fix test to show it does the right thing

6b01395

Fix formatting

bee57b1

timrisi approved these changes Jul 13, 2017

View reviewed changes

spouliot suggested changes Jul 13, 2017

View reviewed changes

More code review changes

196117e

Move NSCollectionViewTransitionLayout back into gen code

24da912

chamons added 2 commits July 18, 2017 13:42

Remove messages from a few deprecations that were less than useful

df79197

Merge branch 'xcode9-appkit' of github.com:chamons/xamarin-macios int…

6810d9b

…o xcode9-appkit

spouliot approved these changes Jul 18, 2017

View reviewed changes

chamons merged commit b59a82e into xamarin:xcode9 Jul 19, 2017

chamons deleted the xcode9-appkit branch July 19, 2017 14:00

mandel-macaque mentioned this pull request Jul 4, 2020

[Bump] Bump maccore to fix issues listing simulators on xcode12. #9003

Merged

Xcode9 appkit #2245

Xcode9 appkit #2245

Conversation

chamons commented Jun 23, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

monojenkins commented Jun 23, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

VincentDondain Jun 23, 2017 • edited Loading

Choose a reason for hiding this comment

monojenkins commented Jul 11, 2017

chamons commented Jul 11, 2017

chamons commented Jul 12, 2017

monojenkins commented Jul 12, 2017

monojenkins commented Jul 12, 2017

chamons commented Jul 13, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

chamons commented Jul 13, 2017

monojenkins commented Jul 13, 2017

chamons commented Jul 14, 2017

monojenkins commented Jul 14, 2017

monojenkins commented Jul 18, 2017

VincentDondain Jun 23, 2017 •

edited

Loading