Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[msbuild][mac][ios] Fix referencing netstandard projects #2643

Merged
merged 1 commit into from
Sep 13, 2017

Commits on Sep 11, 2017

  1. [msbuild][mac][ios] Fix referencing netstandard projects

    Building a XI or XM (Modern) project that references a netstandard 2.0
    project with msbuild fails because of a missing reference to
    `netstandard.dll`.
    
    AppDelegate.cs(21,52): error CS0012: The type 'Object' is defined in an assembly that is not referenced. You must add a reference to assembly 'netstandard, Version=2.0.0.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51'.
    
    The reason is that XI and XM (Modern) projects have
    `$(TargetFrameworkIdentifier) != .NETFramework`, so targets from
    `Microsoft.NET.Build.Extensions` which provide ns2.0 support don't get
    imported. `ImplicitlyExpandNETStandardFacades` in particular, which
    would have added a reference to `netstandard.dll`.
    
    `netstandard.dll` gets included as part of the facades expanded by
    `ImplicitlyExpandDesignTimeFacades`, but this gets skipped if the
    project does not have a `System.Runtime` dependent reference.
    
    Instead, we want to expand the facades if any reference depends on
    `System.Runtime` OR `netstandard`. And for that we scan all the
    references for a `netstandard` dependency using the
    `GetDependsOnNETStandard` task.
    
    Partially fixes bxc #58504 .
    Ankit Jain committed Sep 11, 2017
    Configuration menu
    Copy the full SHA
    cfe80b6 View commit details
    Browse the repository at this point in the history