[xtro] Report missing-protocol-conformance when protocols are defined… #3187

VincentDondain · 2018-01-09T19:46:22Z

… in categories

Fixes bug #59272: [xtro] Report !missing-protocol-conformance! when protocols are defined in categories
(https://bugzilla.xamarin.com/show_bug.cgi?id=59272)
Implemented missing protocol conformances based on tool's new data.

… in categories - Fixes bug #59272: [xtro] Report !missing-protocol-conformance! when protocols are defined in categories (https://bugzilla.xamarin.com/show_bug.cgi?id=59272) - Implemented missing protocol conformances based on tool's new data.

dalexsoto

❤️ Nice!

monojenkins · 2018-01-09T20:59:42Z

Build failure

VincentDondain · 2018-01-09T21:01:17Z

Damn I thought I fixed: [FAIL] Selector not found for MapKit.MKMapItem : encodeWithCoder:. Investigating.

spouliot

Nice!

spouliot · 2018-01-09T19:50:23Z

src/foundation.cs

@@ -3542,7 +3551,7 @@ interface NSDate : NSSecureCoding, NSCopying {
 	}

 	[BaseType (typeof (NSObject))]
-	interface NSDictionary : NSSecureCoding, NSMutableCopying {
+	interface NSDictionary : NSSecureCoding, NSMutableCopying, NSFetchRequestResult, INSFastEnumeration {


we do not have correct support for NSFastEnumeration
it better remains in the .ignore files (like others) until we do (or we'll miss this case when we add support)

Yup I saw that: https://github.com/xamarin/xamarin-macios/blob/master/src/foundation.cs#L13034-L13043

But INSFastEnumeration has a message saying: "Placeholer, just so we can start flagging things" and NSArray is already using INSFastEnumeration so I figured it was valid to add it to NSDictionary.

I already added it to the .ignore file: https://github.com/xamarin/xamarin-macios/pull/3187/files#diff-e909b6d483a4c2c9cbff0a2076e1406aR889

not sure your first link is related - bad copy/paste ?

Oops, updated.

Yes, please add INSFastEnumeration when applicable, that way we'll automatically get it when it's implemented.

spouliot · 2018-01-09T19:52:04Z

src/webkit.cs

-	partial interface WebView {
+	partial interface WebView
+#if MONOMAC
+: NSUserInterfaceValidations


minor: indent

spouliot · 2018-01-09T19:52:20Z

src/wkwebkit.cs

+#if MONOMAC
+: NSUserInterfaceValidations
+#endif
+{


minor: indent

spouliot · 2018-01-09T19:53:58Z

tests/introspection/ApiProtocolTest.cs

@@ -184,6 +184,9 @@ protected virtual bool Skip (Type type, string protocolName)
 					return true;
 				}
 				break;
+			// Undocumented conformance (members were inlinded in 'UIViewController' before so all subtypes should conform)
+			case "UIStateRestoring":
+				return true;


the condition seems a bit too general, i.e. it could hide future failures
if this was inlined (typo above) in UIViewController then it's the (only) case where it should be skipped

But skipping UIViewController doesn't skip all the subtypes and if I manually add all the subtypes (20 or 30) it'll fail whenever we add a new subtype (hence the super general condition :/ )

You have Type type so you should be able to check for subclasses - which, I agree, would be better than adding 20-30 more entries

spouliot · 2018-01-09T19:55:44Z

tests/xtro-sharpie/ObjCInterfaceCheck.cs

+				return;
+
+			if (categoryName.EndsWith ("Internal", StringComparison.Ordinal))
+				return;


that's likely better in the data files - along with a comment
otherwise a valid type, ending with Internal, could be missed

Sure but then that comment also applies to https://github.com/xamarin/xamarin-macios/blob/master/tests/xtro-sharpie/ObjCInterfaceCheck.cs#L70-L72 right?

yes, I thought they were all removed

spouliot · 2018-01-09T20:09:39Z

tests/xtro-sharpie/macOS-QuickLookUI.ignore

@@ -0,0 +1,2 @@
+## Getting "[FAIL] Selector not found for Foundation.NSUrl : previewItemTitle" when NSUrl conforms to 'QLPreviewItem'
+!missing-protocol-conformance! NSURL should conform to QLPreviewItem (defined in 'QLPreviewConvenienceAdditions' category)


interesting, I had never realized some types were duplicated between quicklook[UI].cs files

spouliot · 2018-01-09T20:58:31Z

src/avfoundation.cs

-
-		[Export ("flush")]
-		void Flush ();
+#endif


I assume it's a conflict with the protocol name ?

Conflict it is (:

spouliot · 2018-01-09T20:58:37Z

src/avfoundation.cs

 		void RequestMediaDataWhenReadyOnQueue (DispatchQueue queue, Action enqueuer);
+#endif


spouliot · 2018-01-09T21:03:59Z

src/gamekit.cs

+	interface GKLocalPlayer
+#if !TVOS && !WATCH
+	: GKSavedGameListener
+#endif


that's something that should be fixed

spouliot · 2018-01-09T21:13:48Z

tests/xtro-sharpie/iOS-QuickLook.ignore

@@ -1,2 +1,5 @@
 ## fixed for XAMCORE_4_0
 !incorrect-protocol-member! QLPreviewItem::previewItemTitle is OPTIONAL and should NOT be abstract
+
+## Getting "[FAIL] Selector not found for Foundation.NSUrl : previewItemTitle" when NSUrl conforms to 'QLPreviewItem'
+!missing-protocol-conformance! NSURL should conform to QLPreviewItem (defined in 'QLPreviewConvenienceAdditions' category)


That's probably because of the entry just above - if it's optional then having it not responding is normal

spouliot · 2018-01-10T01:41:48Z

Something looks 🐟 with NSString in API diff, several properties/methods are being added as virtual but they should already exists in NSObject (so at best it would be override).

edit / update

interface CNKeyDescriptor : NSObjectProtocol, NSSecureCoding, NSCopying

it's likely because of NSObjectProtocol which is the name (like swift) used for the NSObject protocol (not type). Not clear why the generator is re-generating them (as non-override)

edit / update 2

Yup, that's the problem and the generated code is incorrect. @VincentDondain please do a diff of the generated code (like if this was a generator change) to see if it's the only place this happens. If that's the case we could ignore that specific case (until fixed) and move along with the PR.

edit / update 3

Yup^2

public new virtual string DebugDescription {

is what's produced (so compiling does not complain) but it's not really what we want - even if it should work (but duplicate the code) in most cases.

rolfbjarne · 2018-01-10T17:53:02Z

src/foundation.cs

@@ -3542,7 +3551,7 @@ interface NSDate : NSSecureCoding, NSCopying {
 	}

 	[BaseType (typeof (NSObject))]
-	interface NSDictionary : NSSecureCoding, NSMutableCopying {
+	interface NSDictionary : NSSecureCoding, NSMutableCopying, NSFetchRequestResult, INSFastEnumeration {


Yes, please add INSFastEnumeration when applicable, that way we'll automatically get it when it's implemented.

…ceDecl

…32-bit

VincentDondain · 2018-01-10T22:27:39Z

@spouliot here's the diff from the generator. Everything other than NSString.g.cs looks fine to me (expected based on the code changes).

spouliot · 2018-01-10T23:00:55Z

src/mapkit.cs

-		, NSItemProviderReading, NSItemProviderWriting
+		: NSItemProviderReading, NSItemProviderWriting
+#if ARCH_64 // [FAIL] Selector not found for MapKit.MKMapItem : encodeWithCoder: on 32-bit iOS
+		, NSSecureCoding


We can't do that in public API, e.g. if 32bits and 64bits signatures are different then this leaks into user code
It also becomes impossible (or at least harder) to de-duplicate the platform assemblies (for fat apps)

This needs to be considered a OS version change (which it is) e.g. when a new version of iOS adds conformance then we add the API (and fix up introspection not to report it for older versions)

My guess is that it's actually tied to the OS version (it works in iOS 11 (64-bit only), but not iOS 10.3 (where we run our 32-bit tests))

That explains why I couldn't find many ARCH_64, thought I was being clever here :P

But yes I now remember how we usually handle NSSecureCoding, I was distracted.

spouliot · 2018-01-10T23:01:07Z

src/mapkit.cs

 #endif
+#endif
+#if WATCH || TVOS || MONOMAC && ARCH_64
+		: NSSecureCoding


spouliot · 2018-01-10T23:03:10Z

tests/xtro-sharpie/iOS-MapKit.ignore

@@ -9,3 +9,6 @@
 !missing-field! MKAnnotationCalloutInfoDidChangeNotification not bound
 !missing-protocol-conformance! MKUserLocation should conform to MKAnnotation
 !missing-protocol-member! MKOverlay::coordinate not found
+
+## Getting "[FAIL] Selector not found for MapKit.MKMapItem : encodeWithCoder:" when 'MKMapItem' implements 'NSSecureCoding' on 32-bit iOS
+!missing-protocol-conformance! MKMapItem should conform to NSSecureCoding (defined in 'MKMapItemSerialization' category)


looks like the previous case, it must be handled like a version change (not an arch specific change)
keep it mind xtro uses the 64bits .pch (from sharpie) to applies the rules

oops, I reviewed the individual commits and some comments are not showing, see the previous in 0f00cb1

spouliot · 2018-01-10T23:03:33Z

tests/xtro-sharpie/macOS-MapKit.ignore

@@ -6,5 +6,5 @@
 !unknown-native-enum! MKFeatureVisibility bound
 !unknown-native-enum! MKUserTrackingMode bound

-## Getting "[FAIL] Selector not found for MapKit.MKMapItem : encodeWithCoder:" when 'MKMapItem' implements 'NSSecureCoding' on macOS
+## Getting "[FAIL] Selector not found for MapKit.MKMapItem : encodeWithCoder:" when 'MKMapItem' implements 'NSSecureCoding' on 32-bit macOS


same (it's also using 64bits .pch for macOS)

spouliot · 2018-01-10T23:05:23Z

tests/introspection/iOS/iOSApiProtocolTest.cs

+
+			// Undocumented conformance (members were inlinded in 'UIViewController' before so all subtypes should conform)
+			case "UIStateRestoring":
+				return type.Name == "UIViewController" || type.IsSubclassOf (typeof (UIViewController));


spouliot · 2018-01-10T23:23:22Z

@VincentDondain there's a small problem with https://gist.github.com/VincentDondain/36cd2ca79628bb4b07a5145e46f0150c
and it does show why (at least some) delegates where not inlined.

AVQueuedSampleBufferRendering (iOS 11) was added after AVSampleBufferDisplayLayer (iOS 8) so members, like Enqueue are now shown to require iOS11 (which is not true). Same for AVSampleBufferDisplayLayer

UIViewController also has a similar issue with DecodeRestorableState and EncodeRestorableState

There are also an extra (generated, the one I mentioned before were after the final compilation) new https://gist.github.com/VincentDondain/36cd2ca79628bb4b07a5145e46f0150c#file-diff-L228 https://gist.github.com/VincentDondain/36cd2ca79628bb4b07a5145e46f0150c#file-diff-L883

note: I only looked at iOS (not others platforms) so there might be a few more.

We might need to split the commit (a few things, like availability, likely requires a generator changes) to get merge most of it soonish

monojenkins · 2018-01-11T00:07:13Z

Build failure

VincentDondain · 2018-01-11T19:03:35Z

@spouliot not sure what's "breaking" when adding a new interface to an existing protocol (the new protocol I'm adding is empty on tvOS). It's not like I'm adding a member (doc).

See https://jenkins.mono-project.com/job/xamarin-macios-pr-builder/5929/API_diff

Also no idea why MetalPerformanceShaders breaking changes are raised (does not happen locally).

…er based on Xcode version)

spouliot · 2018-01-11T20:08:23Z

@VincentDondain sorry, too many comments :) I need context for not sure what's "breaking" when adding a new interface to an existing protocol (the new protocol I'm adding is empty on tvOS

monojenkins · 2018-01-11T20:10:08Z

Build failure

monojenkins · 2018-01-11T20:15:12Z

Build failure

VincentDondain · 2018-01-11T20:17:48Z

@spouliot about the breaking change that shows up on the tvOS API diff (link above).

Namespace GameKit

Type Changed: GameKit.IGKLocalPlayerListener

Added interface:

	IGKSavedGameListener

GKLocalPlayerListener.g.cs show:

public interface IGKLocalPlayerListener : INativeObject, IDisposable, 
		GameKit.IGKChallengeListener
		, GameKit.IGKInviteEventListener
		, GameKit.IGKSavedGameListener
		, GameKit.IGKTurnBasedEventListener
		
{
}

and

public unsafe partial class GKLocalPlayerListener : NSObject, IGKLocalPlayerListener, IGKChallengeListener, IGKInviteEventListener, IGKSavedGameListener, IGKTurnBasedEventListener {
(...)

Why is adding a new interface a breaking change? It's different from adding a new required member to an existing protocol.

spouliot · 2018-01-11T20:29:03Z

@VincentDondain oh, that's one we have to tolerate. It's not a problem with the protocol, but with .net.

E.g. If you have an existing binary A.dll with a type that implements IGKLocalPlayerListener and then update to the new XI+1 then this type becomes invalid (because the type does not implement all the interface members).

It's one of place where the (upcoming) default interface methods will help us.

monojenkins · 2018-01-11T21:26:33Z

Build success

rolfbjarne · 2018-01-11T22:20:53Z

tests/xtro-sharpie/iOS-MapKit.ignore

For the future: make sure to end files with a newline to avoid diff noise 😄

And I should stop commenting until I've read all the commits...

VincentDondain · 2018-01-11T22:31:43Z

this type becomes invalid (because the type does not implement all the interface members)

@spouliot but in the case of this PR, there are no new interface members since IGKSavedGameListener is empty. So IGKLocalPlayerListener still implements all the interface members...

Also what did you mean by: "that's one we have to tolerate" ignore the API diff? Special case?

spouliot · 2018-01-12T01:50:23Z

@VincentDondain api-diff is not that smart :) it's also a bad practice (in .net) to use empty interface (it's better to use attributes). Of course since ours are mapped to protocols we must add them (even if empty).

The tolerance is for the case I mentioned before. We cannot stop adding new protocols even if, in some case, they could break things (we take more care for members).

…utes xamarin#3213

xamarin#3217

VincentDondain · 2018-01-12T21:03:37Z

New generated code diff: https://gist.github.com/VincentDondain/dbd1efe6976e748a2d72df10775a4524

A breaking change should be reported for AUViewController, it's expected, the method was moved to the parent, nothing's broken (:

Also I went for the option of inlining the protocol members that weren’t there already.

e.g: https://gist.github.com/VincentDondain/36cd2ca79628bb4b07a5145e46f0150c#file-diff-L638-L677
and https://gist.github.com/VincentDondain/36cd2ca79628bb4b07a5145e46f0150c#file-diff-L146-L164

monojenkins · 2018-01-12T22:12:36Z

Build failure

[FAIL] Selector not found for UIKit.UIViewController : objectRestorationClass [FAIL] Selector not found for UIKit.UIViewController : restorationParent

monojenkins · 2018-01-13T00:32:39Z

Build failure

VincentDondain · 2018-01-16T14:12:20Z

Xamarin.iOS.Tasks.TargetTests.RebuildExecutable_NoModifications: #1: ../MySingleView/bin/iPhoneSimulator/Debug/MySingleView.app/MySingleView Expected: 2018-01-13 00:15:29.000 But was: 2018-01-13 00:15:30.000

Known issue https://github.com/xamarin/maccore/issues/592

spouliot · 2018-01-17T21:29:04Z

src/gamekit.cs

 		[Export ("player:didModifySavedGame:")]
 		void DidModifySavedGame (GKPlayer player, GKSavedGame savedGame);

+		[NoTV]


Let me go back one step (I might have induced you into an error earlier)

This looks like the protocol does not really exists in tvOS and that Apple just annotated the members and not the type itself. In doubt let's open a radar and add a comment/link into the xtro data

Yea this is confusing.

Also one comment in xtro said:

## all members are not available so the protocol is empty ## however this is confusing because some protocols have no members (so it can't just be ignored)

I was thinking they added the conformance (even if the protocol is empty on tvOS) for later.

But yea I can also revert that, open a radar and annotate xtro.

it's tricky since exposing the protocol (if not supported) could be considered a private API (when apps are analyzed) on tvOS. Since I don't see any benefit from an empty protocol then let's play it safe :)

spouliot · 2018-01-17T21:29:47Z

src/webkit.cs

+#if MONOMAC
+		: NSUserInterfaceValidations
+#endif
+{


minor: indent

spouliot · 2018-01-17T21:29:53Z

src/wkwebkit.cs

+#if MONOMAC
+		: NSUserInterfaceValidations
+#endif
+{


minor: indent

spouliot · 2018-01-17T21:30:49Z

tests/introspection/ApiSelectorTest.cs

+					// 'previewItemTitle' should be optional (fixed in XAMCORE_4_0)
+					return true;
+				}
+				break;


minor: that block could have been inside a #if !XAMCORE_4_0

spouliot · 2018-01-17T21:31:55Z

tests/xtro-sharpie/tvOS-GameKit.ignore

@@ -7,7 +7,6 @@
 ## all members are not available so the protocol is empty
 ## however this is confusing because some protocols have no members (so it can't just be ignored)
 !missing-protocol! GKFriendRequestComposeViewControllerDelegate not bound
-!missing-protocol! GKSavedGameListener not bound


see comment above

This reverts commit a391212.

monojenkins · 2018-01-18T18:17:40Z

Build success

rolfbjarne · 2018-01-29T09:40:32Z

src/coreaudiokit.cs

@@ -28,7 +28,7 @@ namespace XamCore.CoreAudioKit {
 #if XAMCORE_2_0 || !MONOMAC
 	[iOS (9,0)][Mac (10,11, onlyOn64 : true)]
 	[BaseType (typeof(AUViewControllerBase))]
-	interface AUViewController : NSExtensionRequestHandling {
+	interface AUViewController {


@VincentDondain: This is a breaking change:

@rolfbjarne It's UIViewController that implements NSExtensionRequestHandling now (as part of this PR).

Then based on https://github.com/dotnet/corefx/blob/master/Documentation/coding-guidelines/breaking-change-rules.md#types:

Allowed

Removing an interface implementation from a type when the interface is already implemented lower in the hierarchy

Also I asked about this exact case and you answered me :P

https://xamarinhq.slack.com/archives/C03CCJNR7/p1515786537000437

Vincent:

I’m getting a breaking change from API diff but I don’t understand how come it’s a breaking change
I move a protocol from a subclass to its parent. So the generated method from the protocol is removed from the subclass (that’s what’s reported as a breaking change) but that method is now on the base class…
so even if a subclass of a subclass was overriding that virtual method, it should still be fine
https://gist.github.com/VincentDondain/dbd1efe6976e748a2d72df10775a4524#file-new-diff-L189-L213 and https://gist.github.com/VincentDondain/dbd1efe6976e748a2d72df10775a4524#file-new-diff-L599-L623

Rolf:

You’re assuming apidiff is infallible 🙂
Moving members to a base class is one case where it will say it’s a breaking change when it isn’t

@VincentDondain heh, ok, hopefully I'll remember the next time I run into this 😄 👍

VincentDondain requested review from chamons, dalexsoto, mandel-macaque, rolfbjarne and spouliot as code owners January 9, 2018 19:46

dalexsoto approved these changes Jan 9, 2018

View reviewed changes

spouliot suggested changes Jan 9, 2018

View reviewed changes

rolfbjarne approved these changes Jan 10, 2018

View reviewed changes

VincentDondain added 5 commits January 10, 2018 16:18

Fix indentation

d9ce8eb

Fix encodeWithCoder not found

0f00cb1

Remove Internal check from VisitObjCCategoryDecl and VisitObjCInterfa…

b641107

…ceDecl

Ignore NSSecureCoding missing-protocol-conformance (not available on …

75e4646

…32-bit

Fix GKSavedGameListener

a391212

VincentDondain added 2 commits January 10, 2018 17:47

Ignore previewItemTitle failure (normal since it's optional)

9b80dc8

Only skip UIStateRestoring for subclasses of UIViewController

90d1d8e

spouliot reviewed Jan 10, 2018

View reviewed changes

Ignore UIStateRestoring test on watchOS (UIViewController not available)

6996ac0

VincentDondain added 2 commits January 11, 2018 15:02

Properly implement NSSecureCoding for MKMapItem (ignore encodeWithCod…

6268870

…er based on Xcode version)

Cleanup MapKit.ignore files

ac6346e

Fix newline noise

cd007c3

rolfbjarne reviewed Jan 11, 2018

View reviewed changes

VincentDondain added 2 commits January 12, 2018 11:45

Remove protocol conformances that generated wrong availability attrib…

57ef7c4

…utes xamarin#3213

Avoid new virtual or virtual when adding protocol conformance

fc3aee5

xamarin#3217

Removed objectRestorationClass and restorationParent (optional)

e942535

[FAIL] Selector not found for UIKit.UIViewController : objectRestorationClass [FAIL] Selector not found for UIKit.UIViewController : restorationParent

spouliot suggested changes Jan 17, 2018

View reviewed changes

VincentDondain added 3 commits January 18, 2018 10:24

Fix indentation in webkit

4fe8324

Add XAMCORE_4_0 to previewItemTitle case

94bb764

Revert "Fix GKSavedGameListener"

0f89482

This reverts commit a391212.

spouliot approved these changes Jan 18, 2018

View reviewed changes

VincentDondain merged commit 4da8016 into xamarin:master Jan 18, 2018

VincentDondain deleted the bug-59272 branch January 18, 2018 18:42

rolfbjarne reviewed Jan 29, 2018

View reviewed changes

		@@ -0,0 +1,2 @@
		## Getting "[FAIL] Selector not found for Foundation.NSUrl : previewItemTitle" when NSUrl conforms to 'QLPreviewItem'
		!missing-protocol-conformance! NSURL should conform to QLPreviewItem (defined in 'QLPreviewConvenienceAdditions' category)

		void RequestMediaDataWhenReadyOnQueue (DispatchQueue queue, Action enqueuer);
		#endif

[xtro] Report missing-protocol-conformance when protocols are defined… #3187

[xtro] Report missing-protocol-conformance when protocols are defined… #3187

Conversation

VincentDondain commented Jan 9, 2018

dalexsoto left a comment

Choose a reason for hiding this comment

monojenkins commented Jan 9, 2018

VincentDondain commented Jan 9, 2018

spouliot left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

VincentDondain Jan 9, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

VincentDondain Jan 9, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

spouliot commented Jan 10, 2018 • edited Loading

Choose a reason for hiding this comment

VincentDondain commented Jan 10, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

VincentDondain Jan 11, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

spouliot commented Jan 10, 2018

monojenkins commented Jan 11, 2018

VincentDondain commented Jan 11, 2018

spouliot commented Jan 11, 2018

monojenkins commented Jan 11, 2018

monojenkins commented Jan 11, 2018

VincentDondain commented Jan 11, 2018

spouliot commented Jan 11, 2018

monojenkins commented Jan 11, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

VincentDondain commented Jan 11, 2018

spouliot commented Jan 12, 2018

VincentDondain commented Jan 12, 2018

monojenkins commented Jan 12, 2018

monojenkins commented Jan 13, 2018

VincentDondain commented Jan 16, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

monojenkins commented Jan 18, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

VincentDondain Jan 9, 2018 •

edited

Loading

VincentDondain Jan 9, 2018 •

edited

Loading

spouliot commented Jan 10, 2018 •

edited

Loading

VincentDondain commented Jan 10, 2018 •

edited

Loading

VincentDondain Jan 11, 2018 •

edited

Loading