Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[XHarness] Remove not needed bcl tests for Mono.Runtime. #5400

Conversation

mandel-macaque
Copy link
Member

Remove tests that are not provided in the Mono iOS SDK for Mono.Runtime.

Fixes https://github.com/xamarin/maccore/issues/1141

Remove tests that are not provided in the Mono iOS SDK for Mono.Runtime.

Fixes xamarin/maccore#1141
@mandel-macaque
Copy link
Member Author

As with a previous PR, the test assembly was added when we built the tests locally, but this dll is not present in the iOS Mono SDK.

You can double check with:

tree builds/downloads/ios-release-Darwin-25a8be91115255341dd80ce4a225415feec46f56/ios-bcl/ | grep monotouch_Mono.Runtime.Tests_test.dll

@mandel-macaque mandel-macaque changed the title [XHarness] Remove not needed bcl tests for [XHarness] Remove not needed bcl tests for Mono.Runtime. Jan 14, 2019
@monojenkins
Copy link
Collaborator

Build failure
Build was aborted

@monojenkins
Copy link
Collaborator

Build success
Build succeeded
API Diff (from stable)
ℹ️ API Diff (from PR only) (please review changes)
Generator Diff (no change)
Test run succeeded

@mandel-macaque mandel-macaque merged commit 20595ce into xamarin:master Jan 14, 2019
@mandel-macaque mandel-macaque deleted the remove-not-needed-tests-Mono.Runtime branch January 17, 2019 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants