[apidiff] Fix location for XI (when comparing), otherwise we get the full (not PR) diff #5700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…full (not PR) diff
mandel-macaque
approved these changes
Mar 1, 2019
|
Build success |
chamons
approved these changes
Mar 1, 2019
dalexsoto
referenced
this pull request
Mar 4, 2019
Tests are reenabled and a small typo fixed. Fixes xamarin/maccore#1187
dalexsoto
referenced
this pull request
Mar 4, 2019
…5695) Ensure that when the importer sources are changed, xharness is recompiled.
dalexsoto
referenced
this pull request
Mar 4, 2019
…5685) * MachO.cs: Support reading LC_BUILD_VERSION Newer SDKs set this instead of LC_VERSION_MIN_* * MachO.cs: Add support for reading Mach-O files inside ar archives. * [tests] Augment ProductTests.MinOSVersion to test static libraries as well. * Adjust enum field names to match our naming scheme.
dalexsoto
referenced
this pull request
Mar 4, 2019
The previous implementation was broken, because: * We called GetIsARM64CallingConvention in Runtime's static constructor. * Runtime.Arch hadn't been set yet in the static constructor, which means it was Arch.DEVICE (0). * This meant GetIsARM64CallingConvention would return true on iOS/tvOS x86-64 simulator. So delay the initialization of the IsARM64CallingConvention field until we've been initialized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.