-
Notifications
You must be signed in to change notification settings - Fork 511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump mono to 2019-08@528103728fc2aedb7b6062e11255d39a0ed3f31c to add missing NS2.1 APIs #7147
Conversation
…missing NS2.1 APIs See mono/mono#17064. The 2019-08 version of the fix adds a new assembly with NS2.1 APIs that we stubbed out in 2019-06: System.Data.DataSetExtensions.dll
This needs to be ported to all branches that use mono 2019-08. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@akoeplinger is this brining a new test dll that should be added to the BCL tests? if the is the case, could you create an issue and assign me?
@VincentDondain please do the backport needed for this to be in all 2019-08 related branches since you are the Qbert. |
@mandel-macaque yes there should be a corresponding test dll. |
@monojenkins backport to d16-4 |
Build failure Test results12 tests failed, 138 tests passed.Failed tests
|
Failures are due to [FAIL] UrlProtocolTest.RegistrarTest : DidReceiveData is failing because of user agent sniffing on microsoft.com will be fixed by #7154 |
Following PR xamarin#7147 we have a new dll and therefore new tests to run. Fixes: xamarin#7148
Following PR xamarin#7147 we have a new dll and therefore new tests to run. Fixes: xamarin#7148
See mono/mono#17064.
The 2019-08 version of the fix adds a new assembly with NS2.1 APIs that we stubbed out in 2019-06: System.Data.DataSetExtensions.dll
Commit diff: mono/mono@d8441de...5281037