Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[d16-4] Bump mono to latest HEAD #7348

Closed
wants to merge 1 commit into from
Closed

[d16-4] Bump mono to latest HEAD #7348

wants to merge 1 commit into from

Conversation

dalexsoto
Copy link
Member

@dalexsoto dalexsoto commented Nov 1, 2019 •
edited by VincentDondain
Loading

New commits in mono/mono:

Diff: https://github.com/mono/mono/compare/8946e49a974ea8b75fe5b8b7e93ffd4571521a85..6ac1ff75a27fab3de52bc81b3b40d59dccd0bbd8

@dalexsoto dalexsoto added requires-approval-before-merge The pull request requires special approval before it can be merged not-notes-worthy Ignore for release notes labels Nov 1, 2019
@dalexsoto dalexsoto added this to the d16-4 milestone Nov 1, 2019
@monojenkins
Copy link
Collaborator

Build failure
✅ Build succeeded
✅ API Diff (from stable)
✅ API Diff (from PR only) (no change)
✅ Generator Diff (no change)
🔥 Test run failed 🔥

Test results

1 tests failed, 150 tests passed.

Failed tests

  • monotouch-test/watchOS 32-bits - simulator/Debug: Crashed

VincentDondain
VincentDondain approved these changes Nov 1, 2019
View reviewed changes
Copy link
Contributor

@VincentDondain VincentDondain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good but we'll need mono/mono#17622 too (:

If this is ready we can just merge it though.

@VincentDondain VincentDondain added the do-not-merge Do not merge this pull request label Nov 1, 2019
@VincentDondain
Copy link
Contributor

Adding do-not-merge as there's no equivalent android PR and we'll need an other bump so we'll probably have to replace this PR by a new one.

@dalexsoto
Copy link
Member Author

Closed in favor of #7356

@dalexsoto dalexsoto closed this Nov 1, 2019
@dalexsoto dalexsoto deleted the alex-mono-bump branch November 1, 2019 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spouliot spouliot spouliot approved these changes

@mandel-macaque mandel-macaque mandel-macaque approved these changes

@VincentDondain VincentDondain VincentDondain approved these changes

@chamons chamons Awaiting requested review from chamons

@rolfbjarne rolfbjarne Awaiting requested review from rolfbjarne rolfbjarne is a code owner

Assignees
No one assigned
Labels
do-not-merge Do not merge this pull request not-notes-worthy Ignore for release notes requires-approval-before-merge The pull request requires special approval before it can be merged
Projects
None yet
Milestone
d16-4
Development

Successfully merging this pull request may close these issues.
6 participants
@dalexsoto @monojenkins @VincentDondain @spouliot @xamarin-release-manager @mandel-macaque