Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[d16-5] [xharness] Make sure to always stop log and system capture. #7503

Merged
merged 1 commit into from
Dec 3, 2019
Merged

[d16-5] [xharness] Make sure to always stop log and system capture. #7503

merged 1 commit into from
Dec 3, 2019

Conversation

monojenkins
Copy link
Collaborator

This will hopefully stop the runaway mlaunch processes we've seen on the bots.

Ref: https://github.com/xamarin/maccore/issues/1965.

Backport of #7499.

/cc @rolfbjarne

@rolfbjarne @monojenkins
[xharness] Make sure to always stop log and system capture.
d296005 
This will hopefully stop the runaway mlaunch processes we've seen on the bots.

Ref: https://github.com/xamarin/maccore/issues/1965.
@rolfbjarne rolfbjarne added the not-notes-worthy Ignore for release notes label Nov 27, 2019
@monojenkins
Copy link
Collaborator Author

Build failure
✅ Build succeeded
✅ API Diff (from stable)
✅ API Diff (from PR only) (no change)
✅ Generator Diff (no change)
🔥 Test run failed 🔥

Test results

1 tests failed, 85 tests passed.

Failed tests

  • monotouch-test/watchOS 32-bits - simulator/Debug: Crashed

@rolfbjarne
Copy link
Member

Test failure is unrelated (https://github.com/xamarin/maccore/issues/581).

xamarin-release-manager referenced this pull request Nov 29, 2019
@monojenkins @mandel-macaque
[d16-5] [Tests] Update tests.sln to include all the BCL tests. (#7480)
9f95d86 
Update the UUIDs of the projects to ensure that they are all present
in the sln for developers to use.

Fixes: #7475
Fixes: #7476
@rolfbjarne rolfbjarne merged commit 5c5112e into xamarin:d16-5 Dec 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rolfbjarne rolfbjarne rolfbjarne approved these changes

@mandel-macaque mandel-macaque mandel-macaque approved these changes

Assignees
No one assigned
Labels
not-notes-worthy Ignore for release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@monojenkins @rolfbjarne @mandel-macaque