Silence or fix some warnings #7562
Conversation
Therzok
requested review from
chamons,
dalexsoto,
rolfbjarne and
spouliot
as code owners
| SetValue (value, originator.ObserverToken); | ||
| #pragma warning restore CS0618 |
There was a problem hiding this comment.
This needs review / comments, it hides something that should not happen.
IOW we should not depend on [Obsolete] API since we generally plan not to have them in XAMCORE_4_0. EIf a newer/better API exists then we should be using it (or we should comment why we can't)
There was a problem hiding this comment.
The obsolete method points to this method.
There was a problem hiding this comment.
The obsolete method points to this method.
yes, that's exactly my point :) something seems fishy and it needs to be reviewed (and if that's the right approach, some comments needs to be added)
There was a problem hiding this comment.
Fixing this properly would probably mean modifying the generator so we generate 2 overloads, one for AUParameterObserverToken and one for the IntPtr version (compat one).
How would one modify the generator so it generates two methods and also forward AUParameterObserverToken to AUParameterObserverToken.ObserverToken
There was a problem hiding this comment.
Moving the non-disable warning fixes to a different PR.
|
Adding do not merge until we have answers to the questions from @spouliot |
|
Build failure Test results1 tests failed, 86 tests passed.Failed tests
|
|
Need a response on #7562 (comment) |
|
Still need a response for the generator question. |
If fixing this requires generator changes, I'd consider writing up an issue and letting @dalexsoto or someone else bang that out outside of this PR. Unless that is you are motivated to do a deep dive in some 🐉 filled code :) |
|
Added an item to the list here as per @dalexsoto 's recommendation. Closing this PR. |
No description provided.