Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[msbuild] Don't use events and methods that are obsolete and do nothing. #7637

Merged
merged 1 commit into from
Dec 23, 2019
Merged

[msbuild] Don't use events and methods that are obsolete and do nothing. #7637

merged 1 commit into from
Dec 23, 2019

Commits on Dec 20, 2019

  1. [msbuild] Don't use events and methods that are obsolete and do nothing. 

    Fixes these warnings:

    IPhoneSdks.cs(22,4): warning CS0618: 'AppleSdkSettings.Changed' is obsolete: 'This event is never raised' [/work/maccore/onedotnet/xamarin-macios/msbuild/Xamarin.iOS.Tasks.Core/Xamarin.iOS.Tasks.Core.csproj]
    IPhoneSdks.cs(31,4): warning CS0618: 'AppleSdkSettings.CheckChanged()' is obsolete: 'This method does nothing' [/work/maccore/onedotnet/xamarin-macios/msbuild/Xamarin.iOS.Tasks.Core/Xamarin.iOS.Tasks.Core.csproj]
    MacOSXSdks.cs(18,4): warning CS0618: 'AppleSdkSettings.Changed' is obsolete: 'This event is never raised' [/work/maccore/onedotnet/xamarin-macios/msbuild/Xamarin.Mac.Tasks.Core/Xamarin.Mac.Tasks.Core.csproj]
    MacOSXSdks.cs(25,4): warning CS0618: 'AppleSdkSettings.CheckChanged()' is obsolete: 'This method does nothing' [/work/maccore/onedotnet/xamarin-macios/msbuild/Xamarin.Mac.Tasks.Core/Xamarin.Mac.Tasks.Core.csproj]

Also bump Xamarin.MacDev to pick up updated Xamarin.MacDev:

* xamarin/Xamarin.MacDev@0f578f5 [tests] Upgrade to NUnit 3.12 and use package references. (xamarin#65)
* xamarin/Xamarin.MacDev@55a30e2 [tests] Adjust tests to not expect the provisioning profiles in the index in any particular order. (xamarin#63)
* xamarin/Xamarin.MacDev@dc270f6 Make methods that do nothing obsolete and fix a compiler warning. (xamarin#67)
* xamarin/Xamarin.MacDev@681aef6 Remove unused csproj. (xamarin#66)
* xamarin/Xamarin.MacDev@d78a92f Update gitignore (xamarin#55)

Diff: https://github.com/xamarin/Xamarin.MacDev/compare/ca221c8fd65a6f1d6e85d77018d4a7619a2c120d..0f578f51e63b6ff93014782dbc9378e6b6bc6d75
    @rolfbjarne
    rolfbjarne committed Dec 20, 2019
    Configuration menu
    Copy the full SHA
    af38477 View commit details
    Browse the repository at this point in the history