Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to mono:2020-02 #7795

Merged
merged 35 commits into from
Mar 20, 2020
Merged

Bump to mono:2020-02 #7795

merged 35 commits into from
Mar 20, 2020

Conversation

directhex
Copy link
Contributor

No description provided.

@directhex directhex added run-all-tests Run all our tests. run-internal-tests If tests should be executed on the internal Jenkins instance. skip-api-comparison Skips API / generator diffs when testing pull requests labels Feb 4, 2020
@xamarin-release-manager
Copy link
Collaborator

Build was (probably) aborted

🔥 Jenkins job (on internal Jenkins) failed in stage(s) 'Build' 🔥 : hudson.AbortException: script returned exit code 2

🔥 Build failed 🔥

@monojenkins
Copy link
Collaborator

Build failure
Build failed or was aborted

🔥 Build failed 🔥

@rolfbjarne
Copy link
Member

Build fails with:

19:04:45 Build FAILED.
19:04:45 
19:04:45 "/Users/builder/jenkins/workspace/xamarin-macios-pr-builder/Xamarin.Mac.sln" (mmp target) (1) ->
19:04:45 "/Users/builder/jenkins/workspace/xamarin-macios-pr-builder/tools/mmp/mmp.csproj" (default target) (2) ->
19:04:45 (CoreCompile target) -> 
19:04:45   /Users/builder/jenkins/workspace/xamarin-macios-pr-builder/builds/mono-ios-sdk-destdir/ios-sources/external/linker/src/linker/Linker.Steps/MarkStep.cs(440,11): error CS8370: Feature 'recursive patterns' is not available in C# 7.3. Please use language version 8.0 or greater. [/Users/builder/jenkins/workspace/xamarin-macios-pr-builder/tools/mmp/mmp.csproj]
1

MarkStep.GetAssemblyFromCustomAttributeProvider depends on recursive
patterns, which were introduced in C# 8. This change adds a LangVersion
property to mmp.csproj and mtouch.csproj, so that these projects depend
on the latest version of C#.

In mono/linker 2eac54ad9b7e9974c8c97ff1139c968533fedef7:
 - MarkStep.IsPropertyMethod and MarkStep.GetProperty were moved to
   MethodDefinitionExtensions, and
 - MarkStep.ResolveTypeDefinition was resolved outright, in favor of
   direct calls to Mono.Cecil.TypeReference.Resolve.

These only require mechanical changes to ListExportedSymbols and
MonoTouchMarkStep.
@monojenkins
Copy link
Collaborator

Build failure
Build succeeded
API Diff (from stable)
❎ Skipped API comparison because the PR has the label 'skip-api-comparison'
🔥 Test run failed 🔥

Test results

6 tests failed, 1012 tests' device not found, 172 tests passed.

Failed tests

  • xammac tests/Mac Modern/Debug: TimedOut (Execution timed out after 1200 seconds.)
  • xammac tests/Mac Modern/Debug: TimedOut (Execution timed out after 1200 seconds.)
  • xammac tests/Mac Modern/Release: TimedOut (Execution timed out after 1200 seconds.)
  • xammac tests/Mac Modern/Release: TimedOut (Execution timed out after 1200 seconds.)
  • [NUnit] Mono BCL tests group 2/iOS Unified 32-bits - simulator/Debug: Failed
  • MTouch tests/NUnit: Failed (Execution failed with exit code 7)

@rolfbjarne rolfbjarne added skip-device-tests Skip device tests trigger-device-tests Trigger a device test run for PRs built on internal Jenkins (no effect on public Jenkins) labels Feb 6, 2020
@rolfbjarne
Copy link
Member

The MTouch test failures happen in master too. The other failures don't.

@spouliot
Copy link
Contributor

spouliot commented Feb 6, 2020

@imhameed

MTouch tests/NUnit: Failed (Execution failed with exit code 7)

should be fixed with #7798 - and, like @rolfbjarne mentioned, you can disregard it

[FAIL] TestGetBytesAllocatedForCurrentThread : Expected: 220030384 

only happened on 32bits simulator (no device tests results yet)

xammac_tests failures are timeout - due to a hang while running a test. It seems to happen at the same point every time (4 configs)
https://jenkins.mono-project.com/job/xamarin-macios-pr-builder/12518/Test_20Report/

@spouliot
Copy link
Contributor

spouliot commented Feb 6, 2020

I can repro the GC failure locally and it seems to be something that happened before (but not in our case) since it's filed as mono/mono#17140

@spouliot
Copy link
Contributor

spouliot commented Feb 6, 2020

The xammac tests did not fail for me locally :( We'll see if this happen again with newer builds...

@monojenkins
Copy link
Collaborator

monojenkins commented Feb 7, 2020

Build failure
Build succeeded
API Diff (from stable)
❎ Skipped API comparison because the PR has the label 'skip-api-comparison'
🔥 Test run failed 🔥

Test results

1 tests failed, 177 tests passed.

Failed tests

  • [NUnit] Mono BCL tests group 2/iOS Unified 32-bits - simulator/Debug: Failed

FAIL -> mono/mono#17140 😞

@xamarin-release-manager
Copy link
Collaborator

Build was (probably) aborted

🔥 Jenkins job (on internal Jenkins) failed in stage(s) 'Checkout' 🔥 : hudson.AbortException: There is already a newer build in progress (#3)

@xamarin-release-manager
Copy link
Collaborator

Build was (probably) aborted

🔥 Jenkins job (on internal Jenkins) failed in stage(s) 'Provisioning' 🔥 : hudson.AbortException: script returned exit code 1

🔥 Provisioning failed 🔥

@xamarin-release-manager
Copy link
Collaborator

Build was (probably) aborted

🔥 Jenkins job (on internal Jenkins) failed in stage(s) 'Provisioning' 🔥 : hudson.AbortException: script returned exit code 1

🔥 Provisioning failed 🔥

@spouliot
Copy link
Contributor

spouliot commented Feb 7, 2020

^ this last commit (merge from master) will allow our updated bots (to 10.15/catalina) to pick up the commit and run additional tests (including device tests)

@monojenkins
Copy link
Collaborator

Build failure
Build failed or was aborted

Build succeeded
API Diff (from stable)
❎ Skipped API comparison because the PR has the label 'skip-api-comparison'

@monojenkins
Copy link
Collaborator

Build success
Build succeeded
API Diff (from stable)
❎ Skipped API comparison because the PR has the label 'skip-api-comparison'
Test run succeeded

@xamarin-release-manager
Copy link
Collaborator

xamarin-release-manager commented Mar 12, 2020

Build was (probably) aborted

🔥 Jenkins job (on internal Jenkins) failed in stage(s) 'Running XM tests on '10.10', Running XM tests on '10.10'' 🔥

Build succeeded
✅ Packages:

API Diff (from stable)
API Diff (from PR only) (no change)
Generator Diff (no change)
🔥 Xamarin.Mac tests on 10.10 failed: Xamarin.Mac tests on macOS 10.10 failed (xammac_tests) 🔥
🔥 Test run failed 🔥

Test results

3 tests failed, 181 tests passed.

Failed tests

  • monotouch-test/iOS Unified 32-bits - simulator/Debug: Failed
  • monotouch-test/iOS Unified 32-bits - simulator/Debug (all optimizations): Failed
  • monotouch-test/iOS Unified 64-bits - simulator/Debug (LinkSdk): Failed

The failure on 10.10 is identical to the 3 above

[2020-03-12T08:26:57.171Z] 1) RegistrarTest (MonoTouchFixtures.Foundation.UrlProtocolTest.RegistrarTest)
[2020-03-12T08:26:57.171Z]      Exception
[2020-03-12T08:26:57.171Z]   Expected: null
[2020-03-12T08:26:57.171Z]   But was:  <Foundation.NSErrorException: Error Domain=NSURLErrorDomain Code=-1102 "You do not have permission to access the requested resource." UserInfo=0x7fb734a2a7f0 {NSErrorFailingURLKey=foo://server, NSLocalizedDescription=You do not have permission to access the requested resource., NSErrorFailingURLStringKey=foo://server}
[2020-03-12T08:26:57.171Z]   at MonoTouchFixtures.Foundation.UrlProtocolTest+<>c__DisplayClass2_0.<RegistrarTest>b__0 () [0x00087] in /Users/builder/jenkins/workspace/xamarin-macios/xamarin-macios/tests/monotouch-test/Foundation/UrlProtocolTest.cs:89 >
[2020-03-12T08:26:57.171Z] 
[2020-03-12T08:26:57.171Z]   at MonoTouchFixtures.Foundation.UrlProtocolTest.RegistrarTest () [0x00085] in /Users/builder/jenkins/workspace/xamarin-macios/xamarin-macios/tests/monotouch-test/Foundation/UrlProtocolTest.cs:100 
[2020-03-12T08:26:57.171Z]   at (wrapper managed-to-native) System.Reflection.RuntimeMethodInfo.InternalInvoke(System.Reflection.RuntimeMethodInfo,object,object[],System.Exception&)
[2020-03-12T08:26:57.171Z]   at System.Reflection.RuntimeMethodInfo.Invoke (System.Object obj, System.Reflection.BindingFlags invokeAttr, System.Reflection.Binder binder, System.Object[] parameters, System.Globalization.CultureInfo culture) [0x0006a] in /Library/Frameworks/Xamarin.Mac.framework/Versions/Current/src/Xamarin.Mac/mcs/class/corlib/System.Reflection/RuntimeMethodInfo.cs:395 

and related to network issues.

@mandel-macaque

This comment has been minimized.

@monojenkins
Copy link
Collaborator

Build failure
Build succeeded
API Diff (from stable)
❎ Skipped API comparison because the PR has the label 'skip-api-comparison'
🔥 Test run failed 🔥

@xamarin-release-manager
Copy link
Collaborator

Build was (probably) aborted

🔥 Jenkins job (on internal Jenkins) failed in stage(s) 'Running XM tests on '10.10', Running XM tests on '10.13', Running XM tests on '10.12'' 🔥 : hudson.AbortException: Xamarin.Mac tests on macOS 10.10 failed (xammac_tests)

Build succeeded
✅ Packages:

API Diff (from stable)
API Diff (from PR only) (no change)
Generator Diff (no change)
🔥 Xamarin.Mac tests on 10.10 failed: Xamarin.Mac tests on macOS 10.10 failed (xammac_tests) 🔥
🔥 Xamarin.Mac tests on 10.13 failed: Xamarin.Mac tests on macOS 10.13 failed (xammac_tests) 🔥
🔥 Xamarin.Mac tests on 10.12 failed: Xamarin.Mac tests on macOS 10.12 failed (xammac_tests) 🔥

@xamarin-release-manager
Copy link
Collaborator

Build was (probably) aborted

🔥 Jenkins job (on internal Jenkins) failed in stage(s) 'Running XM tests on '10.10', Running XM tests on '10.10'' 🔥

Build succeeded
✅ Packages:

API Diff (from stable)
API Diff (from PR only) (no change)
ℹ️ Generator Diff (please review changes)
🔥 Xamarin.Mac tests on 10.10 failed: Xamarin.Mac tests on macOS 10.10 failed (xammac_tests) 🔥
🔥 Test run failed 🔥

Test results

1 tests failed, 184 tests passed.

Failed tests

  • monotouch-test/iOS Unified 64-bits - simulator/Debug (LinkSdk): Failed

@monojenkins
Copy link
Collaborator

Build failure
Build succeeded
API Diff (from stable)
❎ Skipped API comparison because the PR has the label 'skip-api-comparison'
🔥 Test run failed 🔥

Test results

4 tests failed, 180 tests passed.

Failed tests

  • monotouch-test/tvOS - simulator/Debug (LinkSdk): Failed
  • monotouch-test/tvOS - simulator/Debug (static registrar): Failed
  • monotouch-test/tvOS - simulator/Release (all optimizations): Failed
  • monotouch-test/tvOS - simulator/Debug (all optimizations): Failed

@xamarin-release-manager
Copy link
Collaborator

xamarin-release-manager commented Mar 14, 2020

Build was (probably) aborted

🔥 Jenkins job (on internal Jenkins) failed in stage(s) 'Running XM tests on '10.10', Running XM tests on '10.10'' 🔥

Build succeeded
✅ Packages:

API Diff (from stable)
🔥 Failed to compare API and create generator diff 🔥
    Failed to build src/
    Search for Comparing API & creating generator diff in the log to view the complete log.
🔥 Xamarin.Mac tests on 10.10 failed: Xamarin.Mac tests on macOS 10.10 failed (xammac_tests) 🔥
🔥 Test run failed -> https://github.com/xamarin/maccore/issues/2175 🔥

Test results

2 tests failed, 183 tests passed.

Failed tests

FAIL 🤥

@xamarin-release-manager
Copy link
Collaborator

Build was (probably) aborted

🔥 Jenkins job (on internal Jenkins) failed in stage(s) 'Packaging' 🔥 : hudson.AbortException: script returned exit code 2

Build succeeded

@monojenkins
Copy link
Collaborator

Build failure
Build succeeded
API Diff (from stable)
❎ Skipped API comparison because the PR has the label 'skip-api-comparison'
🔥 Test run failed 🔥

Test results

5 tests failed, 179 tests passed.

Failed tests

  • monotouch-test/iOS Unified 32-bits - simulator/Debug (static registrar): Failed
  • monotouch-test/iOS Unified 32-bits - simulator/Release (all optimizations): Failed
  • monotouch-test/iOS Unified 64-bits - simulator/Release (all optimizations): Failed
  • monotouch-test/iOS Unified 64-bits - simulator/Debug (all optimizations): Failed
  • monotouch-test/tvOS - simulator/Release (all optimizations): Failed

@xamarin-release-manager

This comment has been minimized.

@monojenkins

This comment has been minimized.

@xamarin-release-manager

This comment has been minimized.

@monojenkins
Copy link
Collaborator

Build failure
Build succeeded
API Diff (from stable)
❎ Skipped API comparison because the PR has the label 'skip-api-comparison'
🔥 Test run failed 🔥

Test results

2 tests failed, 182 tests passed.

Failed tests

  • monotouch-test/iOS Unified 32-bits - simulator/Debug (static registrar): Failed
  • monotouch-test/iOS Unified 64-bits - simulator/Release (all optimizations): Failed

@mandel-macaque
Copy link
Member

CI failures are known: https://github.com/xamarin/maccore/issues/1956

Copy link
Contributor

@spouliot spouliot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

local (xamarin-macios) changes are fine to merge

@xamarin-release-manager
Copy link
Collaborator

xamarin-release-manager commented Mar 19, 2020

Build was (probably) aborted

🔥 Jenkins job (on internal Jenkins) failed in stage(s) 'Running XM tests on '10.10', Running XM tests on '10.10'' 🔥

Build succeeded
✅ Packages:

API Diff (from stable)
API Diff (from PR only) (no change)
ℹ️ Generator Diff (please review changes)
🔥 Xamarin.Mac tests on 10.10 failed: Xamarin.Mac tests on macOS 10.10 failed (xammac_tests) 🔥 -> https://github.com/xamarin/maccore/issues/2175
🔥 Test run failed 🔥

Test results

2 tests failed, 183 tests passed.

Failed tests

Ok 🤥 (known issues)

@mandel-macaque mandel-macaque merged commit b23c379 into master Mar 20, 2020
mandel-macaque added a commit to mandel-macaque/xamarin-macios that referenced this pull request Mar 20, 2020
Bump mono to 2020-02 head to be in sync with Android.

Co-authored-by: Imran Hameed <imhameed@microsoft.com>
Co-authored-by: Sebastien Pouliot <sebastien.pouliot@microsoft.com>
Co-authored-by: Ankit Jain <radical@gmail.com>
Co-authored-by: Manuel de la Pena <mandel@microsoft.com>
Co-authored-by: Sebastien Pouliot <sebastien.pouliot@gmail.com>
@rolfbjarne rolfbjarne added the not-notes-worthy Ignore for release notes label Sep 14, 2020
@mandel-macaque mandel-macaque deleted the mono-2020-02 branch December 7, 2021 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
not-notes-worthy Ignore for release notes run-all-tests Run all our tests. run-internal-tests If tests should be executed on the internal Jenkins instance. skip-api-comparison Skips API / generator diffs when testing pull requests skip-device-tests Skip device tests trigger-device-tests Trigger a device test run for PRs built on internal Jenkins (no effect on public Jenkins)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants