[XM] Teach XM's mmp tool to handle read only assemblies/native libs #80

chamons · 2016-05-25T17:34:56Z

https://bugzilla.xamarin.com/show_bug.cgi?id=41037
mmp should also promote any install_name_tool errors to "real" errors

- https://bugzilla.xamarin.com/show_bug.cgi?id=41037 - mmp should also promote any install_name_tool errors to "real" errors

rolfbjarne · 2016-05-25T17:37:08Z

tools/mmp/error.cs

@@ -64,7 +64,7 @@ namespace Xamarin.Bundler {
 	//					MM2010	Unknown HttpMessageHandler `{0}`. Valid values are HttpClientHandler (default), CFNetworkHandler or NSUrlSessionHandler
 	//					MM2011  Unknown TLSProvider `{0}.  Valid values are default, legacy or appletls
 	//					MM2012   Only first {0} of {1} "Referenced by" warnings shown. ** This message related to 2009 **
-	//			Warning	MM2013	Failed to resolve the reference to "{0}", referenced in "{1}". The app will not include the referenced assembly, and may fail at runtime.
+	//					Warning	MM2013	Failed to resolve the reference to "{0}", referenced in "{1}". The app will not include the referenced assembly, and may fail at runtime.


Only whitespace change?

rolfbjarne · 2016-05-25T17:37:49Z

Please fix the whitespace change, and it's 👍

spouliot · 2016-05-25T17:44:00Z

tools/mmp/driver.cs

 		static void CopyAssemblies () {
 			foreach (string asm in resolved_assemblies) {
 				var mdbfile = string.Format ("{0}.mdb", asm);
 				var configfile = string.Format ("{0}.config", asm);
 				string filename = Path.GetFileName (asm);

-				File.Copy (asm, Path.Combine (mmp_dir, filename), true);
+				// The linker later gets angry if you copy in a read only assembly
+				CopyFileAndRemoveReadOnly (asm, Path.Combine (mmp_dir, filename));


I'm not sure it's the best place to solve this as it leave the 3 other linkers (XI, XA and monolinker) code base with an identical issue.

xamarin-release-manager · 2016-05-25T19:05:08Z

Build success

New commits in spouliot/Touch.Unit: * xamarin/Touch.Unit@9266732 [Touch.Client] Add support for macOS. (xamarin#80) * xamarin/Touch.Unit@2d556a5 [TouchRunner] Fix network logging to log if we're logging to a file even if EnableNetwork is false. (xamarin#79) * xamarin/Touch.Unit@1f85e16 [TouchOptions] Fix a few issues related to command-line parsing. (xamarin#78) * xamarin/Touch.Unit@1c272a9 [TouchRunner] Rename TestElement.Update to TestElement.TestFinished to make it clearer when it's used. (xamarin#73) * xamarin/Touch.Unit@9a654ca [TouchRunner] Fix running multiple test assemblies in NUnitLite mode. (xamarin#76) * xamarin/Touch.Unit@55c747f [TouchRunner] Print test output to the console. (xamarin#75) * xamarin/Touch.Unit@ab5dce0 [TouchRunner] Keep track of the last shown test suite, and return to it when the app is relaunched. (xamarin#74) * xamarin/Touch.Unit@1a7068c [TouchRunner] Only update the UI for a single test after the test has finished running. (xamarin#72) * xamarin/Touch.Unit@ba93ddf [TouchRunner] Fix unused variable warning by only defining the variable when it's used. (xamarin#71) * xamarin/Touch.Unit@ab2aaa5 [TouchRunner] Always show 'Run all'. (xamarin#70) * xamarin/Touch.Unit@af58317 Move every Touch.Client projects to its own folder. (xamarin#69) * xamarin/Touch.Unit@8a0ec0d [TouchRunner] Improve name printing in NuGet mode. (xamarin#68) * xamarin/Touch.Unit@c7f8ff0 Ignore any 'packages' directory. (xamarin#67) Diff: https://github.com/spouliot/Touch.Unit/compare/b4e8606a85255f2456b0b20d5a0732298fa1ad36..926673287338482f3949659288ab36001413d251

New commits in spouliot/Touch.Unit: * xamarin/Touch.Unit@dafdf9f [Touch.Client] Add API to exclude tests based on categories. * xamarin/Touch.Unit@e6fb7d7 [Touch.Client] Fix paths in the .NET project files. * xamarin/Touch.Unit@9266732 [Touch.Client] Add support for macOS. (xamarin#80) * xamarin/Touch.Unit@2d556a5 [TouchRunner] Fix network logging to log if we're logging to a file even if EnableNetwork is false. (xamarin#79) * xamarin/Touch.Unit@1f85e16 [TouchOptions] Fix a few issues related to command-line parsing. (xamarin#78) * xamarin/Touch.Unit@1c272a9 [TouchRunner] Rename TestElement.Update to TestElement.TestFinished to make it clearer when it's used. (xamarin#73) * xamarin/Touch.Unit@9a654ca [TouchRunner] Fix running multiple test assemblies in NUnitLite mode. (xamarin#76) * xamarin/Touch.Unit@55c747f [TouchRunner] Print test output to the console. (xamarin#75) * xamarin/Touch.Unit@ab5dce0 [TouchRunner] Keep track of the last shown test suite, and return to it when the app is relaunched. (xamarin#74) * xamarin/Touch.Unit@1a7068c [TouchRunner] Only update the UI for a single test after the test has finished running. (xamarin#72) * xamarin/Touch.Unit@ba93ddf [TouchRunner] Fix unused variable warning by only defining the variable when it's used. (xamarin#71) * xamarin/Touch.Unit@ab2aaa5 [TouchRunner] Always show 'Run all'. (xamarin#70) * xamarin/Touch.Unit@af58317 Move every Touch.Client projects to its own folder. (xamarin#69) * xamarin/Touch.Unit@8a0ec0d [TouchRunner] Improve name printing in NuGet mode. (xamarin#68) * xamarin/Touch.Unit@c7f8ff0 Ignore any 'packages' directory. (xamarin#67) Diff: https://github.com/spouliot/Touch.Unit/compare/b4e8606a85255f2456b0b20d5a0732298fa1ad36..dafdf9f44f8fada4e47e2abd0c95c9e494377a8c

New commits in spouliot/Touch.Unit: * xamarin/Touch.Unit@9266732 [Touch.Client] Add support for macOS. (xamarin#80) * xamarin/Touch.Unit@2d556a5 [TouchRunner] Fix network logging to log if we're logging to a file even if EnableNetwork is false. (xamarin#79) * xamarin/Touch.Unit@1f85e16 [TouchOptions] Fix a few issues related to command-line parsing. (xamarin#78) * xamarin/Touch.Unit@1c272a9 [TouchRunner] Rename TestElement.Update to TestElement.TestFinished to make it clearer when it's used. (xamarin#73) * xamarin/Touch.Unit@9a654ca [TouchRunner] Fix running multiple test assemblies in NUnitLite mode. (xamarin#76) * xamarin/Touch.Unit@55c747f [TouchRunner] Print test output to the console. (xamarin#75) * xamarin/Touch.Unit@ab5dce0 [TouchRunner] Keep track of the last shown test suite, and return to it when the app is relaunched. (xamarin#74) * xamarin/Touch.Unit@1a7068c [TouchRunner] Only update the UI for a single test after the test has finished running. (xamarin#72) * xamarin/Touch.Unit@ba93ddf [TouchRunner] Fix unused variable warning by only defining the variable when it's used. (xamarin#71) * xamarin/Touch.Unit@ab2aaa5 [TouchRunner] Always show 'Run all'. (xamarin#70) * xamarin/Touch.Unit@af58317 Move every Touch.Client projects to its own folder. (xamarin#69) * xamarin/Touch.Unit@8a0ec0d [TouchRunner] Improve name printing in NuGet mode. (xamarin#68) * xamarin/Touch.Unit@c7f8ff0 Ignore any 'packages' directory. (xamarin#67) Diff: https://github.com/spouliot/Touch.Unit/compare/b4e8606a85255f2456b0b20d5a0732298fa1ad36..926673287338482f3949659288ab36001413d251

New commits in spouliot/Touch.Unit: * xamarin/Touch.Unit@dafdf9f [Touch.Client] Add API to exclude tests based on categories. * xamarin/Touch.Unit@e6fb7d7 [Touch.Client] Fix paths in the .NET project files. * xamarin/Touch.Unit@9266732 [Touch.Client] Add support for macOS. (xamarin#80) * xamarin/Touch.Unit@2d556a5 [TouchRunner] Fix network logging to log if we're logging to a file even if EnableNetwork is false. (xamarin#79) * xamarin/Touch.Unit@1f85e16 [TouchOptions] Fix a few issues related to command-line parsing. (xamarin#78) * xamarin/Touch.Unit@1c272a9 [TouchRunner] Rename TestElement.Update to TestElement.TestFinished to make it clearer when it's used. (xamarin#73) * xamarin/Touch.Unit@9a654ca [TouchRunner] Fix running multiple test assemblies in NUnitLite mode. (xamarin#76) * xamarin/Touch.Unit@55c747f [TouchRunner] Print test output to the console. (xamarin#75) * xamarin/Touch.Unit@ab5dce0 [TouchRunner] Keep track of the last shown test suite, and return to it when the app is relaunched. (xamarin#74) * xamarin/Touch.Unit@1a7068c [TouchRunner] Only update the UI for a single test after the test has finished running. (xamarin#72) * xamarin/Touch.Unit@ba93ddf [TouchRunner] Fix unused variable warning by only defining the variable when it's used. (xamarin#71) * xamarin/Touch.Unit@ab2aaa5 [TouchRunner] Always show 'Run all'. (xamarin#70) * xamarin/Touch.Unit@af58317 Move every Touch.Client projects to its own folder. (xamarin#69) * xamarin/Touch.Unit@8a0ec0d [TouchRunner] Improve name printing in NuGet mode. (xamarin#68) * xamarin/Touch.Unit@c7f8ff0 Ignore any 'packages' directory. (xamarin#67) Diff: https://github.com/spouliot/Touch.Unit/compare/b4e8606a85255f2456b0b20d5a0732298fa1ad36..dafdf9f44f8fada4e47e2abd0c95c9e494377a8c

This also required adding System.Core.dll to the MonoTouch.NUnitLite.dll, and fixing a csproj path. New commits in spouliot/Touch.Unit: * xamarin/Touch.Unit@dafdf9f [Touch.Client] Add API to exclude tests based on categories. * xamarin/Touch.Unit@e6fb7d7 [Touch.Client] Fix paths in the .NET project files. * xamarin/Touch.Unit@9266732 [Touch.Client] Add support for macOS. (#80) * xamarin/Touch.Unit@2d556a5 [TouchRunner] Fix network logging to log if we're logging to a file even if EnableNetwork is false. (#79) * xamarin/Touch.Unit@1f85e16 [TouchOptions] Fix a few issues related to command-line parsing. (#78) * xamarin/Touch.Unit@1c272a9 [TouchRunner] Rename TestElement.Update to TestElement.TestFinished to make it clearer when it's used. (#73) * xamarin/Touch.Unit@9a654ca [TouchRunner] Fix running multiple test assemblies in NUnitLite mode. (#76) * xamarin/Touch.Unit@55c747f [TouchRunner] Print test output to the console. (#75) * xamarin/Touch.Unit@ab5dce0 [TouchRunner] Keep track of the last shown test suite, and return to it when the app is relaunched. (#74) * xamarin/Touch.Unit@1a7068c [TouchRunner] Only update the UI for a single test after the test has finished running. (#72) * xamarin/Touch.Unit@ba93ddf [TouchRunner] Fix unused variable warning by only defining the variable when it's used. (#71) * xamarin/Touch.Unit@ab2aaa5 [TouchRunner] Always show 'Run all'. (#70) * xamarin/Touch.Unit@af58317 Move every Touch.Client projects to its own folder. (#69) * xamarin/Touch.Unit@8a0ec0d [TouchRunner] Improve name printing in NuGet mode. (#68) * xamarin/Touch.Unit@c7f8ff0 Ignore any 'packages' directory. (#67) Diff: https://github.com/spouliot/Touch.Unit/compare/b4e8606a85255f2456b0b20d5a0732298fa1ad36..dafdf9f44f8fada4e47e2abd0c95c9e494377a8c

This also required adding System.Core.dll to the MonoTouch.NUnitLite.dll, and fixing a csproj path. New commits in spouliot/Touch.Unit: * xamarin/Touch.Unit@dafdf9f [Touch.Client] Add API to exclude tests based on categories. * xamarin/Touch.Unit@e6fb7d7 [Touch.Client] Fix paths in the .NET project files. * xamarin/Touch.Unit@9266732 [Touch.Client] Add support for macOS. (xamarin#80) * xamarin/Touch.Unit@2d556a5 [TouchRunner] Fix network logging to log if we're logging to a file even if EnableNetwork is false. (xamarin#79) * xamarin/Touch.Unit@1f85e16 [TouchOptions] Fix a few issues related to command-line parsing. (xamarin#78) * xamarin/Touch.Unit@1c272a9 [TouchRunner] Rename TestElement.Update to TestElement.TestFinished to make it clearer when it's used. (xamarin#73) * xamarin/Touch.Unit@9a654ca [TouchRunner] Fix running multiple test assemblies in NUnitLite mode. (xamarin#76) * xamarin/Touch.Unit@55c747f [TouchRunner] Print test output to the console. (xamarin#75) * xamarin/Touch.Unit@ab5dce0 [TouchRunner] Keep track of the last shown test suite, and return to it when the app is relaunched. (xamarin#74) * xamarin/Touch.Unit@1a7068c [TouchRunner] Only update the UI for a single test after the test has finished running. (xamarin#72) * xamarin/Touch.Unit@ba93ddf [TouchRunner] Fix unused variable warning by only defining the variable when it's used. (xamarin#71) * xamarin/Touch.Unit@ab2aaa5 [TouchRunner] Always show 'Run all'. (xamarin#70) * xamarin/Touch.Unit@af58317 Move every Touch.Client projects to its own folder. (xamarin#69) * xamarin/Touch.Unit@8a0ec0d [TouchRunner] Improve name printing in NuGet mode. (xamarin#68) * xamarin/Touch.Unit@c7f8ff0 Ignore any 'packages' directory. (xamarin#67) Diff: https://github.com/spouliot/Touch.Unit/compare/b4e8606a85255f2456b0b20d5a0732298fa1ad36..dafdf9f44f8fada4e47e2abd0c95c9e494377a8c

This also required adding System.Core.dll to the MonoTouch.NUnitLite.dll, and fixing a csproj path. New commits in spouliot/Touch.Unit: * xamarin/Touch.Unit@f620668 [Touch.Client] Adjust project configurations. (xamarin#83) * xamarin/Touch.Unit@545400b [Touch.Client] Fix paths in the .NET project files. (xamarin#81) * xamarin/Touch.Unit@703586b [Touch.Client] Add API to exclude tests based on categories. (xamarin#82) * xamarin/Touch.Unit@9266732 [Touch.Client] Add support for macOS. (xamarin#80) * xamarin/Touch.Unit@2d556a5 [TouchRunner] Fix network logging to log if we're logging to a file even if EnableNetwork is false. (xamarin#79) * xamarin/Touch.Unit@1f85e16 [TouchOptions] Fix a few issues related to command-line parsing. (xamarin#78) * xamarin/Touch.Unit@1c272a9 [TouchRunner] Rename TestElement.Update to TestElement.TestFinished to make it clearer when it's used. (xamarin#73) * xamarin/Touch.Unit@9a654ca [TouchRunner] Fix running multiple test assemblies in NUnitLite mode. (xamarin#76) * xamarin/Touch.Unit@55c747f [TouchRunner] Print test output to the console. (xamarin#75) * xamarin/Touch.Unit@ab5dce0 [TouchRunner] Keep track of the last shown test suite, and return to it when the app is relaunched. (xamarin#74) * xamarin/Touch.Unit@1a7068c [TouchRunner] Only update the UI for a single test after the test has finished running. (xamarin#72) * xamarin/Touch.Unit@ba93ddf [TouchRunner] Fix unused variable warning by only defining the variable when it's used. (xamarin#71) * xamarin/Touch.Unit@ab2aaa5 [TouchRunner] Always show 'Run all'. (xamarin#70) * xamarin/Touch.Unit@af58317 Move every Touch.Client projects to its own folder. (xamarin#69) * xamarin/Touch.Unit@8a0ec0d [TouchRunner] Improve name printing in NuGet mode. (xamarin#68) * xamarin/Touch.Unit@c7f8ff0 Ignore any 'packages' directory. (xamarin#67) Diff: https://github.com/spouliot/Touch.Unit/compare/b4e8606a85255f2456b0b20d5a0732298fa1ad36..f62066880ae548bac9302d714b8c045955051014

[XM] Teach XM's mmp tool to handle read only assemblies/native libs

b7920bb

- https://bugzilla.xamarin.com/show_bug.cgi?id=41037 - mmp should also promote any install_name_tool errors to "real" errors

dnfclas added the cla-already-signed label May 25, 2016

rolfbjarne reviewed May 25, 2016
View reviewed changes

spouliot reviewed May 25, 2016
View reviewed changes

chamons closed this May 25, 2016

chamons deleted the mmp_readonly_fix branch May 25, 2016 17:49

chamons mentioned this pull request May 25, 2016

Mmp readonly fix #82

Merged

rolfbjarne added a commit to rolfbjarne/xamarin-macios that referenced this pull request Apr 5, 2019

azdevops: xamarin#80.

18bb46d

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[XM] Teach XM's mmp tool to handle read only assemblies/native libs #80

[XM] Teach XM's mmp tool to handle read only assemblies/native libs #80

chamons commented May 25, 2016

rolfbjarne May 25, 2016

rolfbjarne commented May 25, 2016

spouliot May 25, 2016

xamarin-release-manager commented May 25, 2016

[XM] Teach XM's mmp tool to handle read only assemblies/native libs #80

[XM] Teach XM's mmp tool to handle read only assemblies/native libs #80

Conversation

chamons commented May 25, 2016

rolfbjarne May 25, 2016

Choose a reason for hiding this comment

rolfbjarne commented May 25, 2016

spouliot May 25, 2016

Choose a reason for hiding this comment

xamarin-release-manager commented May 25, 2016