refactor: add support of constants for some fields #1774
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure about this one... I do like things to be typed, but I think this might be a bit too much to add and maintain if we are going this route for the whole package (which we should in order to keep things consistent) 🤔 |
|
Agreed. But we have to start somewhere. I will keep this open for another week. If you think, it would be too much maintenance by then too, we can close it |
|
Yeah fine to keep it open for a while as I currently have very little headroom (and time) for doing project maintenance and/or to think about this one (I co-founded a company last year and things are picking up a little)... |
|
Closing this as too much efforts for maintenance |
|
Sorry for being a little less response lately... But I guess this is best for now 👍🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1772