Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CP-40402: Move C# and Powershell SDK Generation to .NET Standard 2.0 / .NET 6.0 #4782

Merged
merged 21 commits into from
Oct 10, 2022
Merged

CP-40402: Move C# and Powershell SDK Generation to .NET Standard 2.0 / .NET 6.0 #4782

merged 21 commits into from
Oct 10, 2022

Conversation

danilo-delbusso
Copy link
Member

@danilo-delbusso danilo-delbusso commented Sep 5, 2022 •
edited
Loading

Best reviewed one commit at a time.

If you want to run this and don't know how, feel free to ping me.

C# SDK(move to  .NET Standard 2.0)

  1. Remove all mentions of using CookComputing.XmlRpc
  2. Remove IXmlRpcProxy and other XmlRpc mentions from Proxy.cs
  3. Remove XmlRpc references in Event.cs, Response.cs, and Proxy.cs
    • Event.cs: XmlRpcMissingMapping, XmlRpcMember, calls to session.XmlRpcProxy
    • Response.cs: XmlRpcMissingMapping
  4. Covert csproj to SDK style
  5. Target netstandard2.0
  6. Remove reference mention to CookComputing.XmlRpcV2 in csproj
  7.  Remove XmlRpc references in gen_csharp_binding.ml:
    • Remove XmlRpc returns
    • Remove XmlRpc references in Maps.cs code generation
    • Remove XmlRpc references in Proxy.cs code generation
  8. Update Session.cs to only use JsonRpc
  9. Update README
  10. Update target framework of XenSdkSample

Powershell SDK (Move to .NET 6.0):

The Powershell SDK must be moved to .NET Core to satisfy requirements. 

.NET Core 6.0 is the latest available LTS.

n.b.: Visual Studio 2022 is required to build to .NET 6.0.

  1. Remove use of WinForms in Wait-XenTask.cs
  2. Make sure ShouldContinue does not run in a separate thread when called in Connect-Xenserver.cs (in .NET Core, the ValidateServerCertificate call runs in a separate thread. This causes an InvalidOperationException when calling ShouldContinue, which must be called within the same thread as ProcessRecord)
  3. Convert csproj to SDK style
  4. Target net6.0
  5. Remove CookComputing.XmlRpcV2 from references in project file
  6. Update README
  7. Update .psd1

@danilo-delbusso danilo-delbusso changed the title Move C# and Powershell SDK Generation to .NET Core CP-40402: Move C# and Powershell SDK Generation to .NET Core Sep 5, 2022
@danilo-delbusso danilo-delbusso changed the title CP-40402: Move C# and Powershell SDK Generation to .NET Core CP-40402: Move C# and Powershell SDK Generation to .NET Standard 2.0 / .NET 6.0 Sep 5, 2022
@lindig lindig requested a review from kc284 September 5, 2022 10:36
@danilo-delbusso
CP-40402: Remove use of WinForms in PowerShell SDK
a3e5112 
Also use Visual Studio IDE whitespace formatting

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
@danilo-delbusso
CP-40402: Target .NET Standard 2.0 in C# SDK
09d8e90 
Also convert C# `csproj` to SDK style

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
@danilo-delbusso
CP-40402: Remove XML RPC mentions in C# SDK source
2ab2bf1 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
@danilo-delbusso
CP-40402: Remove XML RPC from C# SDK generation
fce1f17 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
@danilo-delbusso
CP-40402: Remove XML RPC from C# SDK README
2f99c47 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
@danilo-delbusso
CP-40402: Target .NET 6.0 in PowerShell SDK
50157d3 
Also update `.csproj` to use SDK style

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
@danilo-delbusso
CP-40402: Update PowerShell module definition for use with .NET 6.0
13db78a 
Also remove mention of XML RPC library

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
@danilo-delbusso
CP-40402: Remove XML RPC from PowerShell SDK README
f29ae0f 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
@danilo-delbusso
CP-40402: Update references in the C# SDK samples
05dcaa2 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
@danilo-delbusso
Run ShouldContinue on the main thread in Connect-Xenserver.cs
a3781bc 
In .NET Core, the ValidateServerCertificate call runs in a separate thread.
This causes an InvalidOperationException when calling ShouldContinue, which must be called within the same thread as ProcessRecord.

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
@danilo-delbusso
Format gen_csharp_binding.ml with make format
e40bd1e 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
@danilo-delbusso danilo-delbusso requested review from CitrixChris and removed request for kc284 September 12, 2022 12:25
@danilo-delbusso
CP-40402: Add missing newline to XenServer.csproj.mustache
4bb64b2 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
kc284
kc284 requested changes Sep 28, 2022
View reviewed changes
ocaml/sdk-gen/csharp/autogen/src/JsonRpc.cs Outdated Show resolved Hide resolved
ocaml/sdk-gen/csharp/autogen/src/Session.cs Outdated Show resolved Hide resolved
@danilo-delbusso
CP-40402: Revert regressions introduced in Session.cs
6be3515 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
@danilo-delbusso
CP-40402: Improve web request property initialisation
dae86ef 
Also remove semicolon incorrectly flagged as code comment, and minor whitespace issues.

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
@danilo-delbusso
Remove Newtonsoft.Json.CH.dll reference from PS SDK
7a75d53 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
@danilo-delbusso
Use NuGet for System.Management.Automation
200837e 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
@danilo-delbusso
Remove redundant or useless properties in PS module manifest
779ca2a 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
@danilo-delbusso danilo-delbusso requested review from kc284 and CitrixChris and removed request for CitrixChris and kc284 October 4, 2022 12:43
kc284 and others added 2 commits October 5, 2022 10:43
@kc284 @danilo-delbusso
Some refactoring.
d283aa8 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
@danilo-delbusso
Update powershell executable path in project debug configuration
6136002 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
@danilo-delbusso danilo-delbusso requested review from kc284 and CitrixChris and removed request for kc284 October 5, 2022 10:05
@danilo-delbusso
Set default value for AllowAutoRedirect in Session.cs
fba2bc7 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
@danilo-delbusso
Set OS condition for Powershell SDK debug configuration
8dd60f4 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
@danilo-delbusso danilo-delbusso requested review from kc284 and removed request for CitrixChris October 5, 2022 14:25
robhoes
robhoes approved these changes Oct 10, 2022
View reviewed changes
Copy link
Member

@robhoes robhoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't personally reviewed this, but several people who actually know about this code have approved.

@robhoes robhoes merged commit 162efaa into xapi-project:master Oct 10, 2022
@danilo-delbusso danilo-delbusso deleted the private/danilod/sdk branch October 10, 2022 11:38
@danilo-delbusso danilo-delbusso restored the private/danilod/sdk branch October 10, 2022 12:53
@kc284 kc284 mentioned this pull request Dec 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robhoes robhoes robhoes approved these changes

@kc284 kc284 kc284 approved these changes

@CitrixChris CitrixChris CitrixChris approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@danilo-delbusso @robhoes @kc284 @CitrixChris