CA-370082: Block multiple definitions of certificate-chain in xe cli #4824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robhoes
approved these changes
Oct 18, 2022
lindig
approved these changes
Oct 20, 2022
| force the CLI to make choices the user didn't foresee. In those cases | ||
| raises an exception to warn the user to input it only once *) | ||
| let get_unique_param param params = | ||
| match List.find_all (fun (n, _) -> n = param) params with |
There was a problem hiding this comment.
We could also introduce a predicate is_unique_key for association lists that would check that property for any association list and a given key:
val is_unique_key: key:string -> (string, 'a) list -> bool
We would have to think about the value if the key does not exist.
There was a problem hiding this comment.
There's a ternary choice here, I don't think a predicate can work to our advantage here
User were allowed to define more than one certificate-chain when installing a host certificate. The implementation picked the first one, ignoring successive ones. This could lead to a situation where the host served a certificate with certificates missing in their chain of trust, making it unverifiable. Instead detect the situation and block the operation immediately. Signed-off-by: Pau Ruiz Safont <pau.safont@citrix.com>
Signed-off-by: Pau Ruiz Safont <pau.safont@citrix.com>
psafont
force-pushed
the
private/paus/multipla
branch
from
12ddaff
to
1f2023a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User were allowed to define more than one certificate-chain when
installing a host certificate. The implementation picked the first one,
ignoring successive ones.
This could lead to a situation where the host served a certificate with
certificates missing in their chain of trust, making it unverifiable.
Instead detect the situation and block the operation immediately.
Signed-off-by: Pau Ruiz Safont pau.safont@citrix.com