-
Notifications
You must be signed in to change notification settings - Fork 284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CP-41279: add migration_compression pool option #4864
Conversation
ocaml/idl/datamodel_pool.ml
Outdated
@@ -1322,6 +1322,10 @@ let t = | |||
~default_value:(Some (VRef null_ref)) "repository_proxy_password" | |||
"Password for the authentication of the proxy used in syncing with \ | |||
the enabled repositories" | |||
; field ~lifecycle:[] ~ty:Bool ~default_value:(Some (VBool false)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should add ~qualifier:DynamicRO
. I'm not sure why the compiler didn't complain about this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, although it should be RW right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh yes, RW.
ocaml/idl/datamodel_lifecycle.ml
Outdated
@@ -19,6 +19,8 @@ let prototyped_of_field = function | |||
Some "22.27.0" | |||
| "host", "last_software_update" -> | |||
Some "22.20.0" | |||
| "pool", "migration_compression" -> | |||
Some "22.32.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should have 22.32.0-next
if the autogenerator works properly...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It gave me 22.32.0-next the first time but after some changes only gave me the above
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Odd, but it really must be 22.32.0-next
, because this change is not in 22.32.0 (which is the previous release).
Looks like you need to update the unit tests. |
Signed-off-by: Steven Woods <steven.woods@citrix.com>
30cdb23
to
7128e63
Compare
Signed-off-by: Steven Woods steven.woods@citrix.com