Support indexing by cf_role for DSG datasets #240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcherian
commented
Jun 28, 2021
| @@ -372,6 +372,7 @@ def _get_all(obj: Union[DataArray, Dataset], key: str) -> List[str]: | |||
| """ | |||
| all_mappers = ( | |||
| _get_custom_criteria, | |||
| functools.partial(_get_custom_criteria, criteria=cf_role_criteria), | |||
dcherian
commented
Jun 28, 2021
| @@ -665,7 +666,7 @@ def check_results(names, key): | |||
| successful[k] = bool(measure) | |||
| if measure: | |||
| varnames.extend(measure) | |||
| elif k in custom_criteria: | |||
| elif k in custom_criteria or k in cf_role_criteria: | |||
There was a problem hiding this comment.
we should really refactor this.
Codecov Report
@@ Coverage Diff @@
## main #240 +/- ##
=======================================
Coverage 96.76% 96.76%
=======================================
Files 14 14
Lines 1792 1793 +1
=======================================
+ Hits 1734 1735 +1
Misses 58 58
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xref #122