Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new vertical coord decode and reordering #315

Merged
merged 22 commits into from
Mar 29, 2022
Merged

new vertical coord decode and reordering #315

merged 22 commits into from
Mar 29, 2022

Commits on Mar 25, 2022

  1. new vertical coord decode and reordering 

    The vertical decoding has been added for `ocean_sigma_coordinate` and the free surface variable has been expanded dimensionally for all the calculations so that the results preserve the standard ordering of time, vertical, lat/Y, lon/X. Three of the tests do not work anymore, though. Expanding dimensionally apparently bumps the attributes off of s_rho, for one. For another, the values are very similar but do not match anymore — not sure why. Interested to see what @dcherian thinks!
    @kthyng
    kthyng committed Mar 25, 2022
    Configuration menu
    Copy the full SHA
    7ff8814 View commit details
    Browse the repository at this point in the history

Commits on Mar 26, 2022

  1. [pre-commit.ci] auto fixes from pre-commit.com hooks 

    for more information, see https://pre-commit.ci
    @pre-commit-ci
    pre-commit-ci[bot] committed Mar 26, 2022
    Configuration menu
    Copy the full SHA
    3b5197d View commit details
    Browse the repository at this point in the history

Commits on Mar 27, 2022

  1. Update doc/whats-new.rst 

    Co-authored-by: Deepak Cherian <dcherian@users.noreply.github.com>
    @kthyng @dcherian
    kthyng and dcherian authored Mar 27, 2022
    Configuration menu
    Copy the full SHA
    57299a9 View commit details
    Browse the repository at this point in the history

  2. Update cf_xarray/accessor.py 

    Co-authored-by: Deepak Cherian <dcherian@users.noreply.github.com>
    @kthyng @dcherian
    kthyng and dcherian authored Mar 27, 2022
    Configuration menu
    Copy the full SHA
    02f1250 View commit details
    Browse the repository at this point in the history

  3. preferentially use outnames over prefix

    @kthyng
    kthyng committed Mar 27, 2022
    Configuration menu
    Copy the full SHA
    8fafedc View commit details
    Browse the repository at this point in the history

  4. [pre-commit.ci] auto fixes from pre-commit.com hooks 

    for more information, see https://pre-commit.ci
    @pre-commit-ci
    pre-commit-ci[bot] committed Mar 27, 2022
    Configuration menu
    Copy the full SHA
    d5da68e View commit details
    Browse the repository at this point in the history

  5. added in transpose statement that does not work yet

    @kthyng
    kthyng committed Mar 27, 2022
    Configuration menu
    Copy the full SHA
    429349d View commit details
    Browse the repository at this point in the history

  6. Merge branch 'add_ocean_sigma_coordinate' of github.com:kthyng/cf-xar… 

    …ray into add_ocean_sigma_coordinate
    @kthyng
    kthyng committed Mar 27, 2022
    Configuration menu
    Copy the full SHA
    1720fe3 View commit details
    Browse the repository at this point in the history

  7. [pre-commit.ci] auto fixes from pre-commit.com hooks 

    for more information, see https://pre-commit.ci
    @pre-commit-ci
    pre-commit-ci[bot] committed Mar 27, 2022
    Configuration menu
    Copy the full SHA
    9c461c5 View commit details
    Browse the repository at this point in the history

Commits on Mar 28, 2022

  1. removed reordering stuff that did not work

    @kthyng
    kthyng committed Mar 28, 2022
    Configuration menu
    Copy the full SHA
    4ede9a5 View commit details
    Browse the repository at this point in the history

  2. merged

    @kthyng
    kthyng committed Mar 28, 2022
    Configuration menu
    Copy the full SHA
    df216bb View commit details
    Browse the repository at this point in the history

  3. provide a default name now

    @kthyng
    kthyng committed Mar 28, 2022
    Configuration menu
    Copy the full SHA
    8f69bc1 View commit details
    Browse the repository at this point in the history

  4. I think the tests are back how they were

    @kthyng
    kthyng committed Mar 28, 2022
    Configuration menu
    Copy the full SHA
    5bf1582 View commit details
    Browse the repository at this point in the history

  5. trying to follow dcherian suggestions

    @kthyng
    kthyng committed Mar 28, 2022
    Configuration menu
    Copy the full SHA
    6af2ebd View commit details
    Browse the repository at this point in the history

  6. small precommit change

    @kthyng
    kthyng committed Mar 28, 2022
    Configuration menu
    Copy the full SHA
    41c8acf View commit details
    Browse the repository at this point in the history

Commits on Mar 29, 2022

  1. Update cf_xarray/tests/test_accessor.py 

    Co-authored-by: Deepak Cherian <dcherian@users.noreply.github.com>
    @kthyng @dcherian
    kthyng and dcherian authored Mar 29, 2022
    Configuration menu
    Copy the full SHA
    c89d1f0 View commit details
    Browse the repository at this point in the history

  2. small fix from review

    @kthyng
    kthyng committed Mar 29, 2022
    Configuration menu
    Copy the full SHA
    6043932 View commit details
    Browse the repository at this point in the history

  3. [pre-commit.ci] auto fixes from pre-commit.com hooks 

    for more information, see https://pre-commit.ci
    @pre-commit-ci
    pre-commit-ci[bot] committed Mar 29, 2022
    Configuration menu
    Copy the full SHA
    11f8029 View commit details
    Browse the repository at this point in the history

  4. [pre-commit.ci] auto fixes from pre-commit.com hooks 

    for more information, see https://pre-commit.ci
    @pre-commit-ci
    pre-commit-ci[bot] committed Mar 29, 2022
    Configuration menu
    Copy the full SHA
    02a27a0 View commit details
    Browse the repository at this point in the history

  5. Update cf_xarray/accessor.py

    @dcherian
    dcherian authored Mar 29, 2022
    Configuration menu
    Copy the full SHA
    b100452 View commit details
    Browse the repository at this point in the history

  6. Update cf_xarray/tests/test_accessor.py

    @dcherian
    dcherian authored Mar 29, 2022
    Configuration menu
    Copy the full SHA
    64380b9 View commit details
    Browse the repository at this point in the history

  7. fixed tests I think

    @kthyng
    kthyng committed Mar 29, 2022
    Configuration menu
    Copy the full SHA
    6fbe702 View commit details
    Browse the repository at this point in the history