Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to pyproject.toml, ruff, add build CI #400

Merged
merged 26 commits into from
Jan 27, 2023
Merged

Migrate to pyproject.toml, ruff, add build CI #400

merged 26 commits into from
Jan 27, 2023

Conversation

dcherian
Copy link
Contributor

@dcherian dcherian commented Jan 27, 2023 •
edited
Loading

Closes #209

Also move to ruff so we can get rid of flake8 which means we can delete setup.cfg

Hopefully this gets us into github's dependency tracking

dcherian
dcherian commented Jan 27, 2023
View reviewed changes
pyproject.toml Outdated Show resolved Hide resolved
dcherian
dcherian commented Jan 27, 2023
View reviewed changes
pyproject.toml Outdated Show resolved Hide resolved
@dcherian dcherian changed the title Migrate to pyproject.toml Migrate to pyproject.toml, ruff Jan 27, 2023
@dcherian
Copy link
Contributor Author

@ocefpaf could you review this please

dcherian
dcherian commented Jan 27, 2023
View reviewed changes
MANIFEST.in Show resolved Hide resolved
dcherian
dcherian commented Jan 27, 2023
View reviewed changes
pyproject.toml Outdated Show resolved Hide resolved
dcherian
dcherian commented Jan 27, 2023
View reviewed changes
pyproject.toml Outdated Show resolved Hide resolved
@dcherian dcherian force-pushed the pyproject.toml branch 3 times, most recently from 886704b to 144fbd9 Compare January 27, 2023 20:23
ocefpaf
ocefpaf reviewed Jan 27, 2023
View reviewed changes
pyproject.toml Outdated Show resolved Hide resolved
ocefpaf
ocefpaf approved these changes Jan 27, 2023
View reviewed changes
Copy link
Contributor

@ocefpaf ocefpaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just some minor comments.

@dcherian
Add label test
277f405
@dcherian
Merge branch 'update-release-workflow' into pyproject.toml
f0c4a5c 
* update-release-workflow:
  Add label test
  Comment
  Update release workflows
@dcherian
Copy link
Contributor Author

Uploading to TestPyPI doesn't work

  1. Need to muck with version number
  2. Needs a branch on the main repo to access the repo secret.

Let's deal with this later

@dcherian dcherian changed the title Migrate to pyproject.toml, ruff Migrate to pyproject.toml, ruff, add build CI Jan 27, 2023
@dcherian dcherian enabled auto-merge (squash) January 27, 2023 23:08
@dcherian dcherian merged commit 736dfda into xarray-contrib:main Jan 27, 2023
dcherian added a commit to dcherian/cf-xarray that referenced this pull request Jan 30, 2023
@dcherian
Merge remote-tracking branch 'upstream/main' into update-citatoin
50d64ef 
* upstream/main:
  Update upstream dev CI (xarray-contrib#404)
  Add optional deps (xarray-contrib#403)
  Migrate to pyproject.toml, ruff, add build CI (xarray-contrib#400)
@dcherian dcherian deleted the pyproject.toml branch February 6, 2023 20:32
@weiji14 weiji14 mentioned this pull request Jun 23, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ocefpaf ocefpaf ocefpaf approved these changes

Assignees
No one assigned
Labels
test-build
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate from setup.cfg to pyproject.toml?
2 participants
@dcherian @ocefpaf