add basic ci setup #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@TomNicholas - this is probably ready to go. The remaining failure is just the pre-commit linter, which I've borrowed from Xarray. Options are:
|
|
Thank you very much @jhamman ! I would prefer option (2), because I want to make sure my linters work locally - I haven't been using them on this project beyond pycharm's default features yet - I put pre-commit in the dependencies aspirationally 😅 If they are the same ones as xarray it should work fine though. Would you like write access to this repo or shall I just merge it now? |
|
Happy to just have you merge for now. Go for it when you are ready. |
flamingbear
pushed a commit
to flamingbear/rewritten-datatree
that referenced
this pull request
Jan 19, 2024
Add basic CI setup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.