New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for paths in `contains` #319

Closed

TomNicholas wants to merge 2 commits into xarray-contrib:main from TomNicholas:contains-pathlike

Member

TomNicholas commented Feb 28, 2024

Closes Consistency between __contains__ and __getitem__ #240
Tests added
Passes pre-commit run --all-files
New functions/methods are listed in api.rst
Changes are summarized in docs/source/whats-new.rst

TomNicholas added 2 commits

February 28, 2024 13:43


          test

3bdfea3


          also check for pathlike objects using contains

80c7750

Member Author

TomNicholas commented Feb 28, 2024

This currently only works for absolute paths - perhaps it should also check for relative paths too...

Member Author

TomNicholas commented Oct 8, 2024

The original issue is tracked upstream

TomNicholas closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet