Replace .ds with immutable DatasetView #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 52ef23b.
|
@TomNicholas let us know when this is ready for testing - we're also happy to help out with the documentation/example notebooks if that's helpful! cc: @aurghs |
|
I think this PR is mostly ready to merge, but I want to pin it to the upcoming pre-release of xarray so that the indexing internals are in a well-defined state. This PR also of course depends on #41. |
Co-authored-by: Mattia Almansi <m.almansi@bopen.eu>
for more information, see https://pre-commit.ci
…ray-contrib/datatree into initial_integration_refactor
3 tasks
flamingbear
pushed a commit
to flamingbear/rewritten-datatree
that referenced
this pull request
Jan 19, 2024
* sketching out changes needed to integrate variables into DataTree * fixed some other basic conflicts * fix mypy errors * can create basic datatree node objects again * child-variable name collisions dectected correctly * in-progres * add _replace method * updated tests to assert identical instead of check .ds is expected_ds * refactor .ds setter to use _replace * refactor init to use _replace * refactor test tree to avoid init * attempt at copy methods * rewrote implementation of .copy method * xfailing test for deepcopying * pseudocode implementation of DatasetView * Revert "pseudocode implementation of DatasetView" This reverts commit 52ef23baaa4b6892cad2d69c61b43db831044630. * pseudocode implementation of DatasetView * removed duplicated implementation of copy * reorganise API docs * expose data_vars, coords etc. properties * try except with calculate_dimensions private import * add keys/values/items methods * don't use has_data when .variables would do * change asserts to not fail just because of differing types * full sketch of how DatasetView could work * added tests for DatasetView * remove commented pseudocode * explanation of basic properties * add data structures page to index * revert adding documentation in favour of that going in a different PR * correct deepcopy tests * use .data_vars in copy tests * add test for arithmetic with .ds * remove reference to wrapping node in DatasetView * clarify type through renaming variables * remove test for out-of-node access * make imports depend on most recent version of xarray Co-authored-by: Mattia Almansi <m.almansi@bopen.eu> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * remove try except for internal import * depend on latest pre-release of xarray * correct name of version * xarray pre-release under pip in ci envs * correct methods * whatsnews * fix fixture in test * whatsnew * improve docstrings * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci Co-authored-by: Mattia Almansi <m.almansi@bopen.eu> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial attempt to change
.dsto instead return an immutable view onto the node's data, instead of a mutable dataset.This closes the part (1) of #80:
That immutability also closes #38.
This PR builds on top of #41.
pre-commit run --all-filesapi.rst