Fix bug where we had extra groups in expected_groups. #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This affected _factorize_multiple. Closes #111
* fix dask case * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
dcherian
added a commit
that referenced
this pull request
Oct 17, 2022
* main: (44 commits) Rename repo to xarray-contrib/flox (#125) Propagate attrs better (#124) Update README.md (#123) Update README.md micromamba in CI (#122) Many optimizations (#120) Add xarray groupby test (#121) Update README.md Update README.md Add NASA Xarray grant [pre-commit.ci] pre-commit autoupdate (#118) Allow custom numpy aggregations for "blockwise" (#117) Don't execute hourly climatology notebook (#98) Bump actions/setup-python from 3 to 4 (#116) Fix factorizing some more. (#115) Correctly factorize values outside bin edges Better error message Avoid a copy. Fix bug where we had extra groups in expected_groups. (#112) Fix binning by nD variable ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This affected _factorize_multiple.
Closes #111
Thanks to @LunarLanding for reporting