Fix mypy errors in core.py #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
This reverts commit c08bc1c.
for more information, see https://pre-commit.ci
|
WOW, finally passing! :) |
This was referenced Sep 27, 2022
dcherian
reviewed
Sep 27, 2022
flox/core.py
Outdated
| ) | ||
| groups = (results["groups"],) | ||
| result = results[agg.name] | ||
|
|
||
| else: | ||
| if TYPE_CHECKING: | ||
| assert isinstance(array, DaskArray) # TODO: How else to narrow that .chunk is there? |
There was a problem hiding this comment.
agg should always have chunk defined? I don't understand your comment.
This code path is only if theere are dask arrays present, so adding the typecheck seems OK to me (but does it actually help?)
There was a problem hiding this comment.
array is still np.array | dask.array at this point, mypy doesn't understand that has_dask implies that.
There was a problem hiding this comment.
This isn't the daks arrays chunks property. It's chunk on Aggregation. It will exist regardless of array type.
There was a problem hiding this comment.
See line 1636, there's the array.chunks.
I'll fix the typo in the TODO.
dcherian
reviewed
Sep 28, 2022
dcherian
reviewed
Sep 28, 2022
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
|
What say you @dcherian, time to merge? |
|
Thanks @Illviljan massive effort! |
dcherian
added a commit
that referenced
this pull request
Oct 9, 2022
* main: Update ci-additional.yaml (#167) Refactor before redoing cohorts (#164) Fix mypy errors in core.py (#150) Add link to numpy_groupies (#160) Bump codecov/codecov-action from 3.1.0 to 3.1.1 (#159) Use math.prod instead of np.prod (#157) Remove None output from _get_expected_groups (#152) Fix mypy errors in xarray.py, xrutils.py, cache.py (#144) Raise error if multiple by's are used with Ellipsis (#149) pre-commit autoupdate (#148) Add mypy ignores (#146) Get pre commit bot to update (#145) Remove duplicate examples headers (#147) Add ci additional (#143) Bump mamba-org/provision-with-micromamba from 12 to 13 (#141) Add ASV benchmark CI workflow (#139) Fix func count for dtype O with numpy and numba (#138)
dcherian
added a commit
that referenced
this pull request
Oct 17, 2022
* main: (29 commits) Major fix to subset_to_blocks (#173) Performance improvements for cohorts detection (#172) Remove split_out (#170) Deprecate resample_reduce (#169) More efficient cohorts. (#165) Allow specifying output dtype (#131) Add a dtype check for numpy arrays in assert_equal (#158) Update ci-additional.yaml (#167) Refactor before redoing cohorts (#164) Fix mypy errors in core.py (#150) Add link to numpy_groupies (#160) Bump codecov/codecov-action from 3.1.0 to 3.1.1 (#159) Use math.prod instead of np.prod (#157) Remove None output from _get_expected_groups (#152) Fix mypy errors in xarray.py, xrutils.py, cache.py (#144) Raise error if multiple by's are used with Ellipsis (#149) pre-commit autoupdate (#148) Add mypy ignores (#146) Get pre commit bot to update (#145) Remove duplicate examples headers (#147) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes Fix typing #96
Fix mypy errors in core.py
Activate mypy now that it passes