-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add vector rendering #69
Conversation
bedc9db
to
ab83f30
Compare
90148e7
to
7e19824
Compare
The vector data-flow (where the data source is a |
e0b1529
to
12827a8
Compare
I'm happy to report that this change fixed things in Safari! I'm not entirely sure about the change to make the layers not disappear while computing. On the one hand, it retains some information while we wait, so that's good. But displaying a blank layer helps the user to recognize that the system is doing something -- if you're not watching the swirling "in-progress" badge. I think a new user might think that nothing changes on zoom and be confused by that. |
Happy to hear that it now works in Safari! |
That's great @davidbrochart!
I think that eventually it would be great to also support vector data sources directly as Xarray objects (e.g., static spatial features with multi-dimensional attribute data, or even dynamic spatial features like polygons with vertices evolving over time). The fact that pygeos (and shapely 2.0) support vectorized operations (numpy ufuncs) and that soon Xarray will fully support custom indexes make it possible (i.e., indexed coordinates with geometry objects as array items). dask-geopandas and dask support in Xarray might also make things easier. It would be nice to also have some convenient methods (public API) for conversion between GeoDataFrame and DataArray / Dataset objects. |
I didn't know that, for me xarray was all about gridded data. That opens up new possibilities indeed!
In this PR xarray-leaflet uses geocube internally, which does just that. But if it's all integrated in xarray, even better. Do you know when all of that will land in xarray? |
Hmm I think that's out of scope for having such methods implemented in Xarray itself, but it may probably fit nicely in an Xarray "geo" extension like Geocube. |
6dd089f
to
15249cc
Compare
15249cc
to
79da65c
Compare
Closing in favor of #75. |
This PR adds support for GeoDataFrame rendering.
nyc.mp4
Closes #22.