Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: safe default zarr write mode #107

Merged
merged 1 commit into from
Nov 8, 2023

Conversation

slevang
Copy link
Contributor

@slevang slevang commented Nov 8, 2023

Closes #106. Figured this was clearer than directly passing through a default mode kwarg, since I can't imagine ever wanting to use 'a' or 'r+' here.

@slevang slevang requested a review from nicrie November 8, 2023 01:27
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d014c87) 94.21% compared to head (0f95d04) 94.19%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #107      +/-   ##
==========================================
- Coverage   94.21%   94.19%   -0.02%     
==========================================
  Files          71       71              
  Lines        5821     5823       +2     
==========================================
+ Hits         5484     5485       +1     
- Misses        337      338       +1     
Files Coverage Δ
xeofs/models/_base_cross_model.py 92.98% <100.00%> (+0.06%) ⬆️
xeofs/models/_base_model.py 95.37% <100.00%> (+0.04%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nicrie nicrie merged commit 3003f5a into xarray-contrib:main Nov 8, 2023
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Critical bug: model.save() overwrites entire directory contents
3 participants