-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Release v1.2.0 #91
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Checks were hard coded to ensure dimensions of e.g. sample-feature. However, we want to allow more general data, with sample and feature names provided by the user.
Dimensions were hard coded but we want Hilbert transform to be performed over any general 2D Arrays
Added three methods for creating synthetic DataArray, Dataset and list of DataArrays. These methods will slowly replace mock data currently used.
Support generation of test cases (resolve #55)
Other actions like converting multiindices or removing NaNs is present in separate classes
In Complex MCA, PCA preprocessing must happen before Hilbert transform (fix #85)
Move actual implementation of method into algorithm methods, while fit, transform, inverse_transform take care of pre and post-processing
Move Hilbert transform related methods into own file (resolve refactor: complex utilties #54)
Instead of individual classes that store different model results use a single DataContainer class that structures results in a dictionary (resolve #88).
Returned scores were always (L2) normalized which can lead to confusion when compared to the scores of other packages like sklearn or eofs. Now users can decide whether to return normalized or "raw" scores.
New parameter allows to choose whether dask models will be computed immediately after decomposition or not. Before, all dask objects were delayed until the end resulting in redundant dask computations.
scores aren't (yet) supported by GWPCA
Boolean or None values cannot be serialized by xarray which required manual conversion of attributes before to_netcdf can be used. Now model attributes are streamlined internally by converting any boolean or None values to strings (resolves #89 )
Conflict between poetry and torch version that cannot be resolved. Therefore remove cca-zoo dependency and associated tests.
Adds Self in python3.10
This was referenced Oct 24, 2023
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.