Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add idealised (cartesian) sample for testing purposes #42

Merged
merged 3 commits into from
Apr 26, 2024
Merged

Add idealised (cartesian) sample for testing purposes #42

merged 3 commits into from
Apr 26, 2024

Conversation

MaxEtherington
Copy link
Contributor

Added ideal.nc, an idealised cartesian test file, sourced from my current cyclone research.

Included variables are:

  • XLAT, XLONG, DZS, U, V, W, REFL_10CM

@lpilz
Copy link
Contributor

lpilz commented Apr 25, 2024

Hey Max, thanks for the pull request. Could you also include the Times variable and check if you need other variables by calling .xwrf.postprocess()? We should actually fall back to the XTIME coordinate and I'll work on that in xwrf#169. But in order to get your enhancement merged asap, I'd suggest just adding the Times variable to the data.

Copy link
Contributor

@lpilz lpilz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :)

@lpilz lpilz merged commit 0c22df3 into xarray-contrib:main Apr 26, 2024
2 checks passed
@lpilz
Copy link
Contributor

lpilz commented Apr 26, 2024

Actually, I just saw that the west_east_stag dimensions are of size 480 and the west_east dimension is of size 80. Could you make a new pull request (pull your local git first) and either have the west_east_stag size be 81 or just not clip any of the horizontal coordinates? I think either solution would be fine. Thanks :) and sorry I didn't catch that earlier

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants