Clean up _destag_variable with respect to types and terminology #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jthielen
force-pushed
the
type-check-destagger
branch
from
afb0c87 to
a6b26a3
Compare
for more information, see https://pre-commit.ci
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Further cleanups of #93 after merge (sorry about that!), this time to help out developers/contributors who wish to build upon the private
_destag_variablefunction:As discussed in #100 (comment) and #100 (comment), this adds a type check for
xarray.Variablein_destag_variableas a safe guard for xwrf contributors against passing in anxarray.DataArrayby accident. Also, updates comments in_destag_variablefrom the original version in #37 to have a bit more accurate terminology.Related issue number
Checklist
Documentation reflects the changes where applicable