Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add earth-relative rotation of U10/V10 fields #113

Merged
merged 3 commits into from
Oct 19, 2022

Conversation

lpilz
Copy link
Collaborator

@lpilz lpilz commented Oct 13, 2022

Change Summary

Adds rotation of U10/V10 wind fields like U/V.

Related issue number

Closes #112

Checklist

  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable

@lpilz lpilz changed the title Adds earth-relative rotation of U10/V10 fields Add earth-relative rotation of U10/V10 fields Oct 13, 2022
@lpilz lpilz requested a review from jthielen October 18, 2022 21:24
@jthielen jthielen added the enhancement New feature or request label Oct 18, 2022
@jthielen jthielen added this to the v0.1 milestone Oct 18, 2022
@lpilz
Copy link
Collaborator Author

lpilz commented Oct 18, 2022

Wasn't quite sure if there is a standard_name for earth-relative 10m winds, which I just couldn't find but I guess it doesn't exist.

@jthielen
Copy link
Collaborator

Wasn't quite sure if there is a standard_name for earth-relative 10m winds, which I just couldn't find but I guess it doesn't exist.

Yeah, I haven't found a good consensus for handling these, so I've usually just skipped the standard name (like done here). If it were to be implemented, the possibilities I'd see are:

  • use the same eastward_wind style standard name, but with a scalar height auxiliary coordinate set at 10 (with appropriate metadata)
  • try to adapt the "Surface" standard name construction guidelines to have something like eastward_wind_at_10_meters_above_ground_level (which would still be provisional, as I haven't seen that style of surface specification used elsewhere)

@lpilz
Copy link
Collaborator Author

lpilz commented Oct 18, 2022

Great! Thanks for your insight. I guess, we'll just amend it once these names are actually part of the CF standards...

@lpilz lpilz merged commit a0b457c into xarray-contrib:main Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE]: Add wind rotation to U/V10 fields
2 participants