Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed transform of XTIME because it doesn't conform to Xarray unit standards #145

Merged
merged 2 commits into from
Nov 6, 2023

Conversation

lpilz
Copy link
Collaborator

@lpilz lpilz commented Oct 23, 2023

Change Summary

I removed the transform of XTIME in _decode_times so that the time coordinate is only constructed from the Times data variable and nothing else is changed.

Related issue number

Closes #131

Checklist

  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable

@lpilz lpilz linked an issue Oct 23, 2023 that may be closed by this pull request
@lpilz lpilz force-pushed the 131-bug-saving-netcdfs-from-xarray-broken branch from 246beb7 to 50f6a39 Compare October 23, 2023 11:24
@lpilz
Copy link
Collaborator Author

lpilz commented Nov 2, 2023

@jthielen Any comments? Otherwise I'll merge it beginning of next week.

Copy link
Collaborator

@jthielen jthielen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for missing this initially! This looks good to me.

@lpilz lpilz merged commit 49cbcf8 into main Nov 6, 2023
7 checks passed
@lpilz lpilz deleted the 131-bug-saving-netcdfs-from-xarray-broken branch November 6, 2023 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Saving NetCDF's from xarray broken
2 participants