Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added XTIME fallback for Time coord generation #170

Merged
merged 2 commits into from
May 9, 2024

Conversation

lpilz
Copy link
Collaborator

@lpilz lpilz commented Apr 25, 2024

Change Summary

Added XTIME as fallback for Time coordinate decoding if Times does not exist for some reason.

Related issue number

Closes #169

Checklist

  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable

@lpilz lpilz requested a review from jthielen April 25, 2024 12:27
@mgrover1
Copy link
Collaborator

mgrover1 commented May 8, 2024

I am happy to review as well @lpilz

@lpilz
Copy link
Collaborator Author

lpilz commented May 8, 2024

Awesome, any time!

@lpilz lpilz requested a review from mgrover1 May 8, 2024 21:31
Copy link
Collaborator

@mgrover1 mgrover1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great - this seems like the right logic to use here.

@mgrover1 mgrover1 merged commit 37dad39 into xarray-contrib:main May 9, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE]: Make xwrf fall back to XTIME if Times is not included in WRF file
2 participants