Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pypi build #193

Merged
merged 3 commits into from
Oct 11, 2024
Merged

Fix pypi build #193

merged 3 commits into from
Oct 11, 2024

Conversation

lpilz
Copy link
Collaborator

@lpilz lpilz commented Oct 11, 2024 •
edited
Loading

Change Summary

Change python-version number from 3.10 to 3.10.15

Related issue number

Checklist

  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable

@lpilz lpilz changed the title Fix python version number Fix pypi build Oct 11, 2024
@lpilz lpilz requested a review from andersy005 October 11, 2024 13:54
andersy005
andersy005 reviewed Oct 11, 2024
View reviewed changes
Copy link
Member

@andersy005 andersy005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

given that the culprit for this issue is the YAML parsing, we might want to use a string here instead of hard-coding the minor version

.github/workflows/pypi-release.yaml Outdated Show resolved Hide resolved
.github/workflows/pypi-release.yaml Outdated Show resolved Hide resolved
@lpilz @andersy005
Apply suggestions from code review
b29496c 
Co-authored-by: Anderson Banihirwe <13301940+andersy005@users.noreply.github.com>
@lpilz
Copy link
Collaborator Author

lpilz commented Oct 11, 2024

Yep, don't know why I didn't :D

@lpilz lpilz enabled auto-merge (squash) October 11, 2024 16:51
@lpilz lpilz merged commit 73386d6 into xarray-contrib:main Oct 11, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andersy005 andersy005 andersy005 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lpilz @andersy005