add hmac_sha384 function #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using the existing `HMAC` functor, apply the `Hash.sha384` class to create a module and exposed function for creating HMAC hashes with the SHA-384 algorithm. The inputs for these tests were copied from the HMAC-SHA512 tests below it. For each test, I made sure that I could produce the expected HMAC-SHA512 output using `openssl sha512 -hmac` on the command line, and then I switched `sha512` to `sha384`. The resulting output was used as the expected value for each of the tests, and they all passed. This makes me reasonably confident in its correctness.
|
This would be rather useful for me as well! |
xavierleroy
approved these changes
Apr 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the existing
HMACfunctor, apply theHash.sha384class tocreate a module and exposed function for creating HMAC hashes with the
SHA-384 algorithm.
The inputs for these tests were copied from the HMAC-SHA512 tests below
it. For each test, I made sure that I could produce the expected
HMAC-SHA512 output using
openssl sha512 -hmacon the command line, andthen I switched
sha512tosha384. The resulting output was used asthe expected value for each of the tests, and they all passed. This
makes me reasonably confident in its correctness.