fix(multiple_click): add edge case tests that was missing in the test…

… suite and fix it
xaviml · Sep 29, 2020 · 3db3371 · 3db3371
1 parent e6f27fd
commit 3db3371
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 1 deletion.
diff --git a/apps/controllerx/cx_core/controller.py b/apps/controllerx/cx_core/controller.py
@@ -283,7 +283,7 @@ async def multiple_click_call_action(self, kwargs) -> None:
         )
         self.click_counter[action_key] = 0
         click_action_key = self.format_multiple_click_action(action_key, click_count)
-        if action_key in self.actions_mapping:
+        if action_key in self.actions_mapping and click_count == 1:
             await self.call_action(action_key)
         elif click_action_key in self.actions_mapping:
             await self.call_action(click_action_key)

diff --git a/.../multiple_clicks/deconz_event_1_test.yaml → ...clicks/deconz_event_1002_1click_test.yaml b/.../multiple_clicks/deconz_event_1_test.yaml → ...clicks/deconz_event_1002_1click_test.yaml
diff --git a/.../multiple_clicks/deconz_event_2_test.yaml → ...clicks/deconz_event_1003_1click_test.yaml b/.../multiple_clicks/deconz_event_2_test.yaml → ...clicks/deconz_event_1003_1click_test.yaml
diff --git a/tests/integ_tests/multiple_clicks/deconz_event_1003_2clicks_test.yaml b/tests/integ_tests/multiple_clicks/deconz_event_1003_2clicks_test.yaml
@@ -0,0 +1,6 @@
+entity_state_attributes:
+  supported_features: 191
+entity_state: "on"
+fired_actions: [1003, 0.05, 1003]
+expected_calls:
+- service: fake_service