Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQUEST] Make the zigbee2mqtt topic prefix variable #137

Closed
fliphess opened this issue Sep 16, 2020 · 2 comments
Closed

[FEATURE REQUEST] Make the zigbee2mqtt topic prefix variable #137

fliphess opened this issue Sep 16, 2020 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@fliphess
Copy link
Contributor

fliphess commented Sep 16, 2020

Feature Request

Is your feature request related to a problem?

I had to make some manual changes in the code because zigbee2mqtt in my setup is not using the default zigbee2mqtt topic.
If it's not too much of a hassle I'd really like use your upstream code without changing the hardcoded mqtt topic.

Describe the solution / feature you'd like

Configure the zigbee2mqtt topic from the app.yaml file by adding a new configuration option in the integration settings:

sound_controller_bedroom:
  module: controllerx
  class: E1744MediaPlayerController
  controller: sound_controller_bedroom
  integration:
    name: z2m
    listen_to: mqtt

    topic_prefix: some/other/topic/for/zigbee2mqtt
    action_key: action

  media_player: media_player.sonos_bedroom

Describe alternatives you've considered

Changing the hardcoded topic in /controllerx/cx_core/integration/z2m.py

@fliphess fliphess added the enhancement New feature or request label Sep 16, 2020
xaviml added a commit that referenced this issue Sep 19, 2020
Make the topic variable (Fixxes: #137)
@xaviml
Copy link
Owner

xaviml commented Sep 20, 2020

This has been released in ControllerX v3.5.0

@xaviml xaviml closed this as completed Sep 20, 2020
@htvekov
Copy link
Contributor

htvekov commented Sep 20, 2020

Hi' @fliphess

Was going to ask Xavi for exact this feature, as my Tasmota wall switches MQTT communication with ControllerX/HA doesn't really belong in the zigbee2mqtt topic.

Thank you ! 😊

Ciao !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants