Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add mute as a predefined action for Media Players #238

Closed
xaviml opened this issue Jan 31, 2021 · 2 comments
Closed

Add mute as a predefined action for Media Players #238

xaviml opened this issue Jan 31, 2021 · 2 comments
Assignees
@xaviml
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@xaviml
Copy link
Owner

xaviml commented Jan 31, 2021

Feature Request

Is your feature request related to a problem?

If I want to mute my media player, I need to use a service call for it.

Describe the solution / feature you'd like

The solution is to add a new predefined action for the mute action.

Describe alternatives you've considered

Use a service call

Additional context

Request comes from here.
@xaviml xaviml added the enhancement New feature or request label Jan 31, 2021
@xaviml xaviml self-assigned this Jan 31, 2021
@xaviml xaviml mentioned this issue Jan 31, 2021
Closed
@xaviml xaviml added the good first issue Good for newcomers label Jan 31, 2021
xaviml added a commit that referenced this issue Feb 6, 2021
@xaviml
feat(media_player): add mute predefined action
b664be1 
related to #238
@xaviml
Copy link
Owner Author

xaviml commented Feb 7, 2021

This predefined action has been added to ControllerX v4.6.0

@xaviml xaviml closed this as completed Feb 7, 2021
@lensherm
Copy link

lensherm commented Feb 8, 2021

This predefined action has been added to ControllerX v4.6.0

Thank you very much @xaviml !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xaviml xaviml

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@xaviml @lensherm