Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow delay time in release_delay attribute #497

Closed
xaviml opened this issue May 31, 2022 · 2 comments
Closed

Allow delay time in release_delay attribute #497

xaviml opened this issue May 31, 2022 · 2 comments
Assignees
@xaviml
Labels
enhancement New feature or request

Comments

@xaviml
Copy link
Owner

xaviml commented May 31, 2022

Feature Request

Is your feature request related to a problem?

ControllerX allows release_delay attribute which is a boolean type. If true, it adds a delay of 100ms to release actions. There is no way to tweak this value.

Describe the solution / feature you'd like

Instead of defining a boolean type, release_delay could be directly the value to delay on release actions.

Additional context

related to #491 (#491 (comment))
@xaviml xaviml added the enhancement New feature or request label May 31, 2022
@xaviml xaviml self-assigned this May 31, 2022
@xaviml xaviml mentioned this issue May 31, 2022
Closed
@xaviml xaviml changed the title [FEATURE REQUEST] Allow delay time in release_delay attribute Jun 2, 2022
xaviml added a commit that referenced this issue Jun 3, 2022
@xaviml
feat: change release_delay type from bool to float
0f88818 
related to #497
xaviml added a commit that referenced this issue Jun 3, 2022
@xaviml
feat: change release_delay type from bool to float
f0e88a8 
related to #497
@xaviml xaviml mentioned this issue Jun 3, 2022
Merged
@xaviml
Copy link
Owner Author

xaviml commented Jun 5, 2022

Hi @Bascht74,

I just released a beta version v4.21.0b0 with the changes mention in this ticket.

You can download from HACS enabling beta versions on ControllerX. Please, let me know if you find any problems. I will be releasing the non-beta version next week or the next.

Regards,
Xavi M.

@xaviml
Copy link
Owner Author

xaviml commented Jun 15, 2022

This feature is now available in ControllerX v4.21.0.

@xaviml xaviml closed this as completed Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xaviml xaviml

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@xaviml